Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: chrome/browser/sync/sync_setup_flow.cc

Issue 3792007: Fix some problems with the ENTER_PASSPHRASE state in sync setup.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/sync_setup_flow.h ('k') | chrome/browser/sync/sync_setup_wizard.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/sync_setup_flow.cc
===================================================================
--- chrome/browser/sync/sync_setup_flow.cc (revision 62569)
+++ chrome/browser/sync/sync_setup_flow.cc (working copy)
@@ -465,16 +465,21 @@
return current_state_ == SyncSetupWizard::GAIA_SUCCESS;
case SyncSetupWizard::CREATE_PASSPHRASE:
return current_state_ == SyncSetupWizard::CONFIGURE;
+ case SyncSetupWizard::ENTER_PASSPHRASE:
+ return current_state_ == SyncSetupWizard::CONFIGURE ||
+ current_state_ == SyncSetupWizard::SETTING_UP;
case SyncSetupWizard::SETUP_ABORTED_BY_PENDING_CLEAR:
return current_state_ == SyncSetupWizard::CONFIGURE;
case SyncSetupWizard::SETTING_UP:
return current_state_ == SyncSetupWizard::CONFIGURE ||
- current_state_ == SyncSetupWizard::CREATE_PASSPHRASE;
+ current_state_ == SyncSetupWizard::CREATE_PASSPHRASE ||
+ current_state_ == SyncSetupWizard::ENTER_PASSPHRASE;
case SyncSetupWizard::FATAL_ERROR:
return true; // You can always hit the panic button.
case SyncSetupWizard::DONE_FIRST_TIME:
case SyncSetupWizard::DONE:
- return current_state_ == SyncSetupWizard::SETTING_UP;
+ return current_state_ == SyncSetupWizard::SETTING_UP ||
+ current_state_ == SyncSetupWizard::ENTER_PASSPHRASE;
default:
NOTREACHED() << "Unhandled State: " << state;
return false;
@@ -654,7 +659,10 @@
}
void SyncSetupFlow::OnPassphraseEntry(const std::string& passphrase) {
- if (configuration_pending_) {
+ if (current_state_ == SyncSetupWizard::ENTER_PASSPHRASE) {
+ service_->SetSecondaryPassphrase(passphrase);
+ Advance(SyncSetupWizard::SETTING_UP);
+ } else if (configuration_pending_) {
configuration_.secondary_passphrase = passphrase;
OnConfigurationComplete();
}
« no previous file with comments | « chrome/browser/sync/sync_setup_flow.h ('k') | chrome/browser/sync/sync_setup_wizard.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698