Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 379021: Fix GetCachedFile(use_root=True)... (Closed)

Created:
11 years, 1 month ago by Dirk Pranke
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews_googlegroups.com, M-A Ruel
Visibility:
Public.

Description

Fix GetCachedFile(use_root=True) Fix GetCachedFile() to skip local mods when use_root is True. The files that exist in the root of the tree don't even seem to exist in the normal source checkouts, and we were looking at a different file as a result. BUG=none R=maruel@chromium.org TEST=locally modify a PRESUBMIT.py file and look for duplicate results. If you get duplicates, this didn't fix it Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31586

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M gcl.py View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dirk Pranke
11 years, 1 month ago (2009-11-10 03:35:30 UTC) #1
M-A Ruel
lgtm
11 years, 1 month ago (2009-11-10 13:49:37 UTC) #2
M-A Ruel
11 years, 1 month ago (2009-11-10 13:50:05 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698