src/objects.cc - Issue 3781014: Fix missing check for GC failure in number dictionary code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 3781014: Fix missing check for GC failure in number dictionary code. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

===================================================================

--- src/objects.cc (revision 5634)

+++ src/objects.cc (working copy)

@@ -8591,7 +8591,9 @@

details = PropertyDetails(details.attributes(),

details.type(),

DetailsAt(entry).index());

- SetEntry(entry, NumberDictionaryShape::AsObject(key), value, details);

+ Object* okey = NumberDictionaryShape::AsObject(key);

Mads Ager (chromium) 2010/10/18 10:04:16 I don't like the name. key_object?

+ if (okey->IsFailure()) return okey;

+ SetEntry(entry, okey, value, details);

return this;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »