Fix FTP directory listing for ftp.cisco.com.

Fix FTP directory listing for ftp.cisco.com.

BUG=58963
TEST=net_unittests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62515

[Paweł Hajdan Jr., 2010-10-13 10:45:28]

The good thing about the design of this directory listing parser is that it
doesn't fail silently. I have tried the same FTP site in Firefox, and while it
doesn't "fail", it silently eats some entries.

After applying this fix, all entries that should be there are displayed. We
can't display size for some of them, but I think it's a fair tradeoff.

[wtc, 2010-10-13 17:22:03]

LGTM.

http://codereview.chromium.org/3774002/diff/1/5
File net/ftp/ftp_directory_listing_parser_ls.cc (right):

http://codereview.chromium.org/3774002/diff/1/5#newcode144
net/ftp/ftp_directory_listing_parser_ls.cc:144: // Some FTP servers mix up the
file size with owning group name,
Nit: "mix up" is a little confusing here.  What you meant is
that there is no whitespace between owning group name and
file size, right?  This seems to be a bug caused by a file
size filling the right-justified file size column.

Nit: Add quotes around group1234 on the next line.

http://codereview.chromium.org/3774002/diff/1/6
File net/ftp/ftp_directory_listing_parser_ls_unittest.cc (right):

http://codereview.chromium.org/3774002/diff/1/6#newcode80
net/ftp/ftp_directory_listing_parser_ls_unittest.cc:80: // mixed up
(http://crbug.com/58963).
Nit: same complaint here -- "mixed up" is a little confusing.

[wtc, 2010-10-13 17:23:36]

On 2010/10/13 10:45:28, Paweł Hajdan Jr. wrote:
>
> After applying this fix, all entries that should be there are displayed. We
> can't display size for some of them, but I think it's a fair tradeoff.

Do we display "0" or "unknown" as the file size for such a
problematic entry?  Ideally we should display "unknwon" or
nothing, because "0" would be inaccurate.