Fix FTP directory listing for ftp.cisco.com.

net/ftp/ftp_directory_listing_parser_ls.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/ftp/ftp_directory_listing_parser_ls.h"
 
 #include <vector>
 
 #include "base/string_number_conversions.h"
 #include "base/string_split.h"
@@ skipping 122 matching lines @@
 
   FtpDirectoryListingEntry entry;
   if (columns[0][0] == 'l') {
     entry.type = FtpDirectoryListingEntry::SYMLINK;
   } else if (columns[0][0] == 'd') {
     entry.type = FtpDirectoryListingEntry::DIRECTORY;
   } else {
     entry.type = FtpDirectoryListingEntry::FILE;
   }
 
-  if (!base::StringToInt64(columns[2 + column_offset], &entry.size))
-    return false;
+  if (!base::StringToInt64(columns[2 + column_offset], &entry.size)) {
+    // Some FTP servers do not separate owning group name from file size,
+    // like "group1234". We still want to display the file name for that entry,
+    // but can't really get the size (What if the group is named "group1",
+    // and the size is in fact 234? We can't distinguish between that
+    // and "group" with size 1234). Use a dummy value for the size.
+    // TODO(phajdan.jr): Use a value that means "unknown" instead of 0 bytes.
+    entry.size = 0;
+  }
   if (entry.size < 0)
     return false;
   if (entry.type != FtpDirectoryListingEntry::FILE)
     entry.size = -1;
 
   if (!FtpUtil::LsDateListingToTime(columns[3 + column_offset],
                                     columns[4 + column_offset],
                                     columns[5 + column_offset],
                                     current_time_,
                                     &entry.last_modified)) {
@@ skipping 22 matching lines @@
   return !entries_.empty();
 }
 
 FtpDirectoryListingEntry FtpDirectoryListingParserLs::PopEntry() {
   FtpDirectoryListingEntry entry = entries_.front();
   entries_.pop();
   return entry;
 }
 
 }  // namespace net