Issue 3765002: Copied Evan's http://codereview.chromium.org/3691007 (base_unittests: move...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3765002: Copied Evan's http://codereview.chromium.org/3691007 (base_unittests: move... (Closed)

Created:
10 years, 2 months ago by Alexander Potapenko

Modified:
9 years, 6 months ago

Reviewers:
Timur Iskhodzhanov, Evan Martin

CC:
chromium-reviews, Alexander Potapenko, Paweł Hajdan Jr., Timur Iskhodzhanov, pam+watch_chromium.org, brettw-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Copied Evan's http://codereview.chromium.org/3691007 (base_unittests: move local functions into an anonymous namespace) and made the necessary changes to sanity suppressions. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62521

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -28 lines)			Patch
	M	base/tools_sanity_unittest.cc	View		2 chunks	+8 lines, -8 lines	0 comments	Download
	M	tools/valgrind/memcheck/suppressions.txt	View		2 chunks	+20 lines, -20 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

10 years, 2 months ago (2010-10-14 15:23:16 UTC) #2

Thanks for doing it!

On Thu, Oct 14, 2010 at 1:26 AM,  <glider@chromium.org> wrote:
> Reviewers: Timur Iskhodzhanov, Evan Martin,
>
> Message:
> TBR
>
> Description:
> Copied Evan's http://codereview.chromium.org/3691007 (base_unittests: move
> local functions into an anonymous namespace) and made the necessary changes
> to
> sanity suppressions.
>
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62521
>
> Please review this at http://codereview.chromium.org/3765002/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     base/tools_sanity_unittest.cc
>  M     tools/valgrind/memcheck/suppressions.txt
>
>
>

Expand Messages | Collapse Messages