Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 3691007: base_unittests: move local functions into an anonymous namespace (Closed)

Created:
10 years, 2 months ago by Evan Martin
Modified:
9 years, 7 months ago
CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

base_unittests: move local functions into an anonymous namespace Symbols by default have global linkage, which means these made it into the .o file (in case some other file used them), even though they're intended to only be used within the object.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M base/tools_sanity_unittest.cc View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Martin
Found this by having the linker print unused symbols.
10 years, 2 months ago (2010-10-12 18:03:13 UTC) #1
Timur Iskhodzhanov
On one hand, I totally believe we should make this change to comply with the ...
10 years, 2 months ago (2010-10-12 18:29:33 UTC) #2
stoyan
10 years, 2 months ago (2010-10-12 18:40:32 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698