Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 376001: ntp.html -> override.html (Closed)

Created:
11 years, 1 month ago by Kathy Walrath
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org
Visibility:
Public.

Description

ntp.html -> override.html This is exactly what you reviewed before, Erik. I plan to update the screenshots next week. BUG=none TEST=none TBR=erikkay Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31158

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+693 lines, -531 lines) Patch
M chrome/common/extensions/docs/api_index.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/api_other.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/autoupdate.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/background_pages.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/bookmarks.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/browserAction.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/content_scripts.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/devguide.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/devtools.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/events.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/extension.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/getstarted.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/hosting.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/i18n.html View 1 chunk +1 line, -1 line 0 comments Download
A chrome/common/extensions/docs/images/ntp-blank.png View Binary file 0 comments Download
A chrome/common/extensions/docs/images/ntp-default.png View Binary file 0 comments Download
M chrome/common/extensions/docs/index.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/manifest.html View 1 chunk +1 line, -1 line 1 comment Download
M chrome/common/extensions/docs/match_patterns.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/npapi.html View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/docs/ntp.html View 1 1 chunk +0 lines, -448 lines 0 comments Download
M chrome/common/extensions/docs/options.html View 1 chunk +1 line, -1 line 0 comments Download
A chrome/common/extensions/docs/override.html View 1 1 chunk +528 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/overview.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/packaging.html View 1 chunk +1 line, -1 line 0 comments Download
chrome/common/extensions/docs/pageAction.html View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/docs/static/ntp.html View 1 chunk +0 lines, -52 lines 0 comments Download
A chrome/common/extensions/docs/static/override.html View 1 1 chunk +134 lines, -0 lines 0 comments Download
chrome/common/extensions/docs/tabs.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/template/api_template.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/test.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/themes.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/toolstrip.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/tut_debugging.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/tutorials.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/windows.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/xhr.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
David Glasser
(This is my first time using Chromium Code Reviews; I hope I'm using proper etiquette!) ...
11 years ago (2009-12-01 18:28:32 UTC) #1
Kathy Walrath
11 years ago (2009-12-01 22:00:59 UTC) #2
Oops. Thanks for catching this. I've fixed it:
http://codereview.chromium.org/449072

Responding to the code review was fine. Another possibility is filing
a bug (http://code.google.com/p/chromium/issues/entry) with the labels
Feature-Extensions & Area-Content. (Or just assign to me, and I'll put
those labels on.)

-k-

On Tue, Dec 1, 2009 at 10:28 AM,  <glasser@google.com> wrote:
> (This is my first time using Chromium Code Reviews; I hope I'm using proper
> etiquette!)
>
>
> http://codereview.chromium.org/376001/diff/2001/2035
> File chrome/common/extensions/docs/manifest.html (right):
>
> http://codereview.chromium.org/376001/diff/2001/2035#newcode265
> chrome/common/extensions/docs/manifest.html:265: "<a
> href="ntp.html">chrome_url_overrides</a>": {...},
> You missed updating this link to override.html; the broken link is live
> on the site at http://code.google.com/chrome/extensions/manifest.html
>
> http://codereview.chromium.org/376001
>

Powered by Google App Engine
This is Rietveld 408576698