Issue 3744009: chromium-os:5494 Networks with identical names not handled properly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3744009: chromium-os:5494 Networks with identical names not handled properly. (Closed)

Created:
10 years, 2 months ago by stevenjb

Modified:
9 years, 7 months ago

Reviewers:
Charlie Lee

CC:
chromium-reviews, Paweł Hajdan Jr., nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

chromium-os:5494 Networks with identical names not handled properly. Changed lookups based on name to use service_path instead. Added wifi_network() and cellular_network() to network_library and removed wifi_name, wifi_strength, celular_name, cellular_service_path, and cellular_strength to simplify API. BUG=chromium-os:5494 TEST=Network menu tests. Set up two networks with the same name, one encrypted and one not. Confirm that all operations on each work as expected. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62839

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -66 lines)			Patch
M	chrome/browser/chromeos/cros/cros_mock.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/cros_mock.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/cros/mock_network_library.h	View		1 chunk	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_library.h	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_library.cc	View	1	4 chunks	+12 lines, -14 lines	0 comments	Download
M	chrome/browser/chromeos/login/network_screen.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/network_screen_browsertest.cc	View		3 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/network_list.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/status/network_dropdown_button.cc	View		2 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/status/network_menu.cc	View	1 2	6 chunks	+17 lines, -12 lines	0 comments	Download
M	chrome/browser/chromeos/status/network_menu_button.cc	View		2 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM. Thanks for fixing this bug.

Expand Messages | Collapse Messages

Issue 3744009: chromium-os:5494 Networks with identical names not handled properly. (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Rebase from trunk. #

Messages