chrome/browser/chromeos/cros/network_library.h - Issue 3744009: chromium-os:5494 Networks with identical names not handled properly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/cros/network_library.h

Issue 3744009: chromium-os:5494 Networks with identical names not handled properly. (Closed)

Patch Set: Rebase from trunk. Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/cros/network_library.h

diff --git a/chrome/browser/chromeos/cros/network_library.h b/chrome/browser/chromeos/cros/network_library.h

index 668783cdd9c4625048d3e10178dead249bdf20c4..7f7a7b1f6d14c0c26de130194b2c0bbdb153ef83 100644

--- a/chrome/browser/chromeos/cros/network_library.h

+++ b/chrome/browser/chromeos/cros/network_library.h

@@ -311,20 +311,20 @@ class NetworkLibrary {

virtual void AddObserver(Observer* observer) = 0;

virtual void RemoveObserver(Observer* observer) = 0;

+ // Return the active Ethernet network (or a default structure if inactive).

virtual const EthernetNetwork& ethernet_network() const = 0;

virtual bool ethernet_connecting() const = 0;

virtual bool ethernet_connected() const = 0;

- virtual const std::string& wifi_name() const = 0;

+ // Return the active Wifi network (or a default structure if none active).

+ virtual const WifiNetwork& wifi_network() const = 0;

virtual bool wifi_connecting() const = 0;

virtual bool wifi_connected() const = 0;

- virtual int wifi_strength() const = 0;

- virtual const std::string& cellular_name() const = 0;

- virtual const std::string& cellular_service_path() const = 0;

+ // Return the active Cellular network (or a default structure if none active).

+ virtual const CellularNetwork& cellular_network() const = 0;

virtual bool cellular_connecting() const = 0;

virtual bool cellular_connected() const = 0;

- virtual int cellular_strength() const = 0;

// Return true if any network is currently connected.

virtual bool Connected() const = 0;