gclient: fix bug where ssh urls with a username weren't parse correctly

gclient: fix bug where ssh urls with a username weren't parse correctly

ssh://test@example.org/test.git was not parsed correctly because we
would split at the '@' assuming what followed was a revision.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31444

[M-A Ruel, 2009-11-07 19:29:40]

http://codereview.chromium.org/372045/diff/1/2
File gclient_scm.py (right):

http://codereview.chromium.org/372045/diff/1/2#newcode130
Line 130: regex = "(ssh://(?:[\w]+@)?[-\w:\.]+/[-\w\.]+)(?:@([\w/]+))?"
Doesn't the regex work with svn url? If so, no need for the condition.

[msb, 2009-11-07 19:52:58]

On Sat, Nov 7, 2009 at 11:29 AM,  <maruel@chromium.org> wrote:
>
> http://codereview.chromium.org/372045/diff/1/2
> File gclient_scm.py (right):
>
> http://codereview.chromium.org/372045/diff/1/2#newcode130
> Line 130: regex = "(ssh://(?:[\w]+@)?[-\w:\.]+/[-\w\.]+)(?:@([\w/]+))?"
> Doesn't the regex work with svn url? If so, no need for the condition.
>

Only ssh:// supports username@ so the meaning of @ can be ambiguous:
username@ or @revision.
For all other url types, a simple split('@') will do.

> http://codereview.chromium.org/372045
>

[msb, 2009-11-07 20:00:00]

On Sat, Nov 7, 2009 at 11:52 AM, Mandeep Baines <msb@google.com> wrote:
> On Sat, Nov 7, 2009 at 11:29 AM, =A0<maruel@chromium.org> wrote:
>>
>> http://codereview.chromium.org/372045/diff/1/2
>> File gclient_scm.py (right):
>>
>> http://codereview.chromium.org/372045/diff/1/2#newcode130
>> Line 130: regex =3D "(ssh://(?:[\w]+@)?[-\w:\.]+/[-\w\.]+)(?:@([\w/]+))?=
"
>> Doesn't the regex work with svn url? If so, no need for the condition.
>>
>
> Only ssh:// supports username@ so the meaning of @ can be ambiguous:
> username@ or @revision.
> For all other url types, a simple split('@') will do.
>

I didn't really answer your question. The regex won't work for all url
types because there are
some developers that are using filesystem paths for urls:

bar/foo.git

or

file://bar/foo.git

These won't parse correctly.

These are handy for having a second git tree that you use for doing
builds. Its a clone of your working git tree.
Build branch foo while you work on bar.

>> http://codereview.chromium.org/372045
>>
>

[M-A Ruel, 2009-11-09 16:39:23]

lgtm with fix.

http://codereview.chromium.org/372045/diff/1/2
File gclient_scm.py (right):

http://codereview.chromium.org/372045/diff/1/2#newcode130
Line 130: regex = "(ssh://(?:[\w]+@)?[-\w:\.]+/[-\w\.]+)(?:@([\w/]+))?"
You need to use r"" btw.

[msb, 2009-11-09 17:56:08]

maruel@chromium.org (maruel@chromium.org) wrote:
> lgtm with fix.
>
>
> http://codereview.chromium.org/372045/diff/1/2
> File gclient_scm.py (right):
>
> http://codereview.chromium.org/372045/diff/1/2#newcode130
> Line 130: regex = "(ssh://(?:[\w]+@)?[-\w:\.]+/[-\w\.]+)(?:@([\w/]+))?"
> You need to use r"" btw.
>

Cool. Thanks:) Didn't know about r"".

> http://codereview.chromium.org/372045