Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 372036: gclient: make sync more verbose on git (Closed)

Created:
11 years, 1 month ago by Mandeep Singh Baines
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel, David McMahon
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

gclient: make sync more verbose on git Requirement for build system. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31362

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M gclient_scm.py View 2 chunks +8 lines, -1 line 1 comment Download

Messages

Total messages: 4 (0 generated)
Mandeep Singh Baines
11 years, 1 month ago (2009-11-06 22:47:48 UTC) #1
M-A Ruel
http://codereview.chromium.org/372036/diff/1/2 File gclient_scm.py (right): http://codereview.chromium.org/372036/diff/1/2#newcode157 Line 157: self._RunGit(['rebase', '-v', new_base], redirect_stdout=False) Shouldn't -v only when ...
11 years, 1 month ago (2009-11-06 22:56:14 UTC) #2
msb
maruel@chromium.org (maruel@chromium.org) wrote: > > http://codereview.chromium.org/372036/diff/1/2 > File gclient_scm.py (right): > > http://codereview.chromium.org/372036/diff/1/2#newcode157 > Line ...
11 years, 1 month ago (2009-11-06 23:21:51 UTC) #3
M-A Ruel
11 years, 1 month ago (2009-11-06 23:24:20 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698