Issue 372033: Cancel unused timeout events. Without this change they can...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 372033: Cancel unused timeout events. Without this change they can... (Closed)

Created:
11 years, 1 month ago by dank

Modified:
9 years, 7 months ago

Reviewers:
Timur Iskhodzhanov

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, not_the_right_glider, Timur Iskhodzhanov, dank, stuartmorgan, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Cancel unused timeout events. Without this change they can accumulate for a while, wasting memory and causing unneeded wakeups. BUG=25641 TEST=green valgrind or heapchecker on net_unittests Previously reviewed as http://codereview.chromium.org/370005/ TBR=timurrrr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31306

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -9 lines)			Patch
	M	base/message_pump_libevent.cc	View		3 chunks	+14 lines, -1 line	0 comments	Download
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

thanks for the reviews, committing

Expand Messages | Collapse Messages