Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 371035: Set SDKROOT in the project-wide xcode_settings block instead of doing it in target_defaults (Closed)

Created:
11 years, 1 month ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
TVL
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Set SDKROOT in the project-wide xcode_settings block instead of doing it in target_defaults. This is equivalent to how Xcode sets SDKROOT from the Project Info window's General tab. Making this setting project-wide means that the selected SDK will show up properly in that UI. BUG=26976 TEST=Build still works. SDK (typically "Mac OS X 10.5") shows up in Project Info:General. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31307

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M build/common.gypi View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
11 years, 1 month ago (2009-11-06 21:29:30 UTC) #1
TVL
11 years, 1 month ago (2009-11-06 21:31:21 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698