Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: build/common.gypi

Issue 371035: Set SDKROOT in the project-wide xcode_settings block instead of doing it in target_defaults (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 'variables': { 9 'variables': {
10 # .gyp files should set chromium_code to 1 if they build Chromium-specific 10 # .gyp files should set chromium_code to 1 if they build Chromium-specific
(...skipping 723 matching lines...) Expand 10 before | Expand all | Expand 10 after
734 'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES', 734 'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES',
735 'GCC_OBJC_CALL_CXX_CDTORS': 'YES', # -fobjc-call-cxx-cdtors 735 'GCC_OBJC_CALL_CXX_CDTORS': 'YES', # -fobjc-call-cxx-cdtors
736 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden 736 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
737 'GCC_THREADSAFE_STATICS': 'NO', # -fno-threadsafe-statics 737 'GCC_THREADSAFE_STATICS': 'NO', # -fno-threadsafe-statics
738 'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror 738 'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror
739 'GCC_VERSION': '4.2', 739 'GCC_VERSION': '4.2',
740 'GCC_WARN_ABOUT_MISSING_NEWLINE': 'YES', # -Wnewline-eof 740 'GCC_WARN_ABOUT_MISSING_NEWLINE': 'YES', # -Wnewline-eof
741 # MACOSX_DEPLOYMENT_TARGET maps to -mmacosx-version-min 741 # MACOSX_DEPLOYMENT_TARGET maps to -mmacosx-version-min
742 'MACOSX_DEPLOYMENT_TARGET': '<(mac_deployment_target)', 742 'MACOSX_DEPLOYMENT_TARGET': '<(mac_deployment_target)',
743 'PREBINDING': 'NO', # No -Wl,-prebind 743 'PREBINDING': 'NO', # No -Wl,-prebind
744 'SDKROOT': 'macosx<(mac_sdk)', # -isysroot
745 'USE_HEADERMAP': 'NO', 744 'USE_HEADERMAP': 'NO',
746 'WARNING_CFLAGS': ['-Wall', '-Wendif-labels'], 745 'WARNING_CFLAGS': ['-Wall', '-Wendif-labels'],
747 'conditions': [ 746 'conditions': [
748 ['chromium_mac_pch', {'GCC_PRECOMPILE_PREFIX_HEADER': 'YES'}, 747 ['chromium_mac_pch', {'GCC_PRECOMPILE_PREFIX_HEADER': 'YES'},
749 {'GCC_PRECOMPILE_PREFIX_HEADER': 'NO'} 748 {'GCC_PRECOMPILE_PREFIX_HEADER': 'NO'}
750 ], 749 ],
751 ], 750 ],
752 }, 751 },
753 'target_conditions': [ 752 'target_conditions': [
754 ['_type!="static_library"', { 753 ['_type!="static_library"', {
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
924 }, 923 },
925 }, 924 },
926 }, 925 },
927 }], 926 }],
928 ], 927 ],
929 'scons_settings': { 928 'scons_settings': {
930 'sconsbuild_dir': '<(DEPTH)/sconsbuild', 929 'sconsbuild_dir': '<(DEPTH)/sconsbuild',
931 'tools': ['ar', 'as', 'gcc', 'g++', 'gnulink', 'chromium_builders'], 930 'tools': ['ar', 'as', 'gcc', 'g++', 'gnulink', 'chromium_builders'],
932 }, 931 },
933 'xcode_settings': { 932 'xcode_settings': {
933 # DON'T ADD ANYTHING NEW TO THIS BLOCK UNLESS YOU REALLY REALLY NEED IT!
934 # This block adds *project-wide* configuration settings to each project
935 # file. It's almost always wrong to put things here. Specify your
936 # custom xcode_settings in target_defaults to add them to targets instead.
937
938 # In an Xcode Project Info window, the "Base SDK for All Configurations"
939 # setting sets the SDK on a project-wide basis. In order to get the
940 # configured SDK to show properly in the Xcode UI, SDKROOT must be set
941 # here at the project level.
942 'SDKROOT': 'macosx<(mac_sdk)', # -isysroot
943
934 # The Xcode generator will look for an xcode_settings section at the root 944 # The Xcode generator will look for an xcode_settings section at the root
935 # of each dict and use it to apply settings on a file-wide basis. Most 945 # of each dict and use it to apply settings on a file-wide basis. Most
936 # settings should not be here, they should be in target-specific 946 # settings should not be here, they should be in target-specific
937 # xcode_settings sections, or better yet, should use non-Xcode-specific 947 # xcode_settings sections, or better yet, should use non-Xcode-specific
938 # settings in target dicts. SYMROOT is a special case, because many other 948 # settings in target dicts. SYMROOT is a special case, because many other
939 # Xcode variables depend on it, including variables such as 949 # Xcode variables depend on it, including variables such as
940 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 950 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
941 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 951 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
942 # files to appear (when present) in the UI as actual files and not red 952 # files to appear (when present) in the UI as actual files and not red
943 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 953 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
944 # and therefore SYMROOT, needs to be set at the project level. 954 # and therefore SYMROOT, needs to be set at the project level.
945 'SYMROOT': '<(DEPTH)/xcodebuild', 955 'SYMROOT': '<(DEPTH)/xcodebuild',
946 }, 956 },
947 } 957 }
948 958
949 # Local Variables: 959 # Local Variables:
950 # tab-width:2 960 # tab-width:2
951 # indent-tabs-mode:nil 961 # indent-tabs-mode:nil
952 # End: 962 # End:
953 # vim: set expandtab tabstop=2 shiftwidth=2: 963 # vim: set expandtab tabstop=2 shiftwidth=2:
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698