Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 371001: Don't load the Java plugin prior to update 12, since they don't work in Chrom... (Closed)

Created:
11 years, 1 month ago by jam
Modified:
9 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews_googlegroups.com, darin (slow to review), jam
Visibility:
Public.

Description

Don't load the Java plugin prior to update 12, since they don't work in Chrome anymore. By blocking loading them, the plugin installer UI is triggered. BUG=26451 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31159

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M webkit/glue/plugins/plugin_constants_win.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/glue/plugins/plugin_list_win.cc View 1 1 chunk +15 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
jam
11 years, 1 month ago (2009-11-05 21:38:17 UTC) #1
Peter Kasting
LGTM with version comment addressed http://codereview.chromium.org/371001/diff/1/2 File webkit/glue/plugins/plugin_list_win.cc (right): http://codereview.chromium.org/371001/diff/1/2#newcode320 Line 320: // Bug 26451: ...
11 years, 1 month ago (2009-11-05 22:01:01 UTC) #2
jam
http://codereview.chromium.org/371001/diff/1/2 File webkit/glue/plugins/plugin_list_win.cc (right): http://codereview.chromium.org/371001/diff/1/2#newcode320 Line 320: // Bug 26451: we only work with newer ...
11 years, 1 month ago (2009-11-05 23:05:03 UTC) #3
Peter Kasting
11 years, 1 month ago (2009-11-05 23:27:15 UTC) #4
http://codereview.chromium.org/371001/diff/4001/4002
File webkit/glue/plugins/plugin_list_win.cc (right):

http://codereview.chromium.org/371001/diff/4001/4002#newcode330
Line 330: if (major == 6 && minor == 0 && update < 120)
Shouldn't this be:
if ((major < 6) || ((major == 6) && (minor == 0) && (update < 120)))
?

http://codereview.chromium.org/371001/diff/4001/4002#newcode331
Line 331: return false;  // Java SE6 Update 12 or older.
This comment doesn't match the code, does it?  In the code you're bailing on
"older than U12" but here you claim you're bailing on "U12 or older".  Which is
the right behavior?

Powered by Google App Engine
This is Rietveld 408576698