Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: webkit/glue/plugins/plugin_list_win.cc

Issue 371001: Don't load the Java plugin prior to update 12, since they don't work in Chrom... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/plugins/plugin_constants_win.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/plugins/plugin_list_win.cc
===================================================================
--- webkit/glue/plugins/plugin_list_win.cc (revision 31079)
+++ webkit/glue/plugins/plugin_list_win.cc (working copy)
@@ -317,6 +317,21 @@
if (filename == kWanWangProtocolHandlerPlugin)
return false;
+ // We only work with newer versions of the Java plugin which use NPAPI only
+ // and don't depend on XPCOM.
+ if (filename == kJavaPlugin1 || filename == kJavaPlugin2) {
+ std::vector<std::wstring> ver;
+ SplitString(info.version, '.', &ver);
+ int major, minor, update;
+ if (ver.size() == 4 &&
+ StringToInt(ver[0], &major) &&
+ StringToInt(ver[1], &minor) &&
+ StringToInt(ver[2], &update)) {
+ if (major == 6 && minor == 0 && update < 120)
Peter Kasting 2009/11/05 23:27:16 Shouldn't this be: if ((major < 6) || ((major == 6
+ return false; // Java SE6 Update 12 or older.
Peter Kasting 2009/11/05 23:27:16 This comment doesn't match the code, does it? In
+ }
+ }
+
// Special WMP handling
// If both the new and old WMP plugins exist, only load the new one.
« no previous file with comments | « webkit/glue/plugins/plugin_constants_win.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698