Fix broken trybot compiles by moving test cases inside the anonymous namespac...

Fix broken trybot compiles by moving test cases inside the anonymous namespace.

BUG=None
TEST=Happy trybots.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62351

[Ilya Sherman, 2010-10-12 22:49:29]

LGTM

[Marc-Antoine Ruel (Google), 2010-10-13 00:05:29]

http://codereview.chromium.org/3697009/diff/4001/5001
File chrome/browser/browser_navigator_browsertest.cc (right):

http://codereview.chromium.org/3697009/diff/4001/5001#newcode17
chrome/browser/browser_navigator_browsertest.cc:17: namespace {
Test base classes shouldn't be in an anonymous namespace.

http://codereview.chromium.org/3697009/diff/4001/5001#newcode76
chrome/browser/browser_navigator_browsertest.cc:76:
IN_PROC_BROWSER_TEST_F(BrowserNavigatorTest, Disposition_CurrentTab) {
Tests shouldn't be in a anonymous namespace.

[rohitrao (ping after 24h), 2010-10-13 00:13:56]

On 2010/10/13 00:05:29, DO NOT USE!! wrote:
> Test base classes shouldn't be in an anonymous namespace.
> Tests shouldn't be in a anonymous namespace.

Why shouldn't they be?  Is this documented anywhere?

We have a lot of tests that put everything into an anonymous namespace, and a
lot of tests that don't.

[rohitrao (ping after 24h), 2010-10-13 00:16:39]

That email came out completely unintelligibly.  It was supposed to read:

On 2010/10/13 00:05:29, DO NOT USE!! wrote:
> Test base classes shouldn't be in an anonymous namespace.
> Tests shouldn't be in a anonymous namespace.

Why shouldn't they be?  Is this documented anywhere?

We have a lot of tests that put everything into an anonymous namespace, and a
lot of tests that don't.

[Marc-Antoine Ruel (Google), 2010-10-13 00:21:17]

On 2010/10/13 00:16:39, rohitrao wrote:
> That email came out completely unintelligibly.  It was supposed to read:
> 
> On 2010/10/13 00:05:29, DO NOT USE!! wrote:
> > Test base classes shouldn't be in an anonymous namespace.
> > Tests shouldn't be in a anonymous namespace.
> 
> Why shouldn't they be?  Is this documented anywhere?
> 
> We have a lot of tests that put everything into an anonymous namespace, and a
> lot of tests that don't.

It's a matter of the way the macro works, C++ and different g++ version.

It seems it's only a requirement for TEST_F() and not IN_PROC_BROWSER_TEST_F().

[rohitrao (ping after 24h), 2010-10-13 00:25:37]

Ah, I see.  I don't think gcc on Mac complains about this, which is why all the
mac unittests have TEST_F inside the namespace.  This is probably also why I get
compile failures when I try to do the same thing in a cross-platform test :)

I'll go through and change all these tests when I get a chance.