Fix broken trybot compiles by moving test cases inside the anonymous namespac...

chrome/browser/browser_navigator_browsertest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser.h"
 #include "chrome/browser/browser_list.h"
 #include "chrome/browser/browser_navigator.h"
 #include "chrome/browser/browser_window.h"
 #include "chrome/browser/profile.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/browser/tab_contents/tab_contents_view.h"
 #include "chrome/browser/tabs/tab_strip_model.h"
 #include "chrome/test/in_process_browser_test.h"
 #include "chrome/test/ui_test_utils.h"
 #include "ipc/ipc_message.h"
 
 namespace {

[Marc-Antoine Ruel (Google), 2010/10/13 00:05:29]

Test base classes shouldn't be in an anonymous namespace.

 
 class BrowserNavigatorTest : public InProcessBrowserTest,
                              public NavigatorDelegate {
  public:
   // Overridden from NavigatorDelegate:
   virtual void UpdateUIForNavigationInTab(TabContents* contents,
                                           PageTransition::Type transition,
                                           bool user_initiated) {
     // Nothing needed.
   }
@@ skipping 36 matching lines @@
     p.disposition = disposition;
     browser::Navigate(&p, this);
 
     // Nothing should have happened as a result of Navigate();
     EXPECT_EQ(1, browser()->tab_count());
     EXPECT_EQ(1u, BrowserList::size());
     EXPECT_EQ(old_url, browser()->GetSelectedTabContents()->GetURL());
   }
 };
 
-}  // namespace
-
 // This test verifies that when a navigation occurs within a tab, the tab count
 // of the Browser remains the same and the current tab bears the loaded URL.
 IN_PROC_BROWSER_TEST_F(BrowserNavigatorTest, Disposition_CurrentTab) {

[Marc-Antoine Ruel (Google), 2010/10/13 00:05:29]

Tests shouldn't be in a anonymous namespace.

   browser::NavigateParams p(MakeNavigateParams());
   browser::Navigate(&p, this);
   ui_test_utils::WaitForNavigationInCurrentTab(browser());
   EXPECT_EQ(GetGoogleURL(), browser()->GetSelectedTabContents()->GetURL());
   // We should have one window with one tab.
   EXPECT_EQ(1u, BrowserList::size());
   EXPECT_EQ(1, browser()->tab_count());
 }
 
 IN_PROC_BROWSER_TEST_F(BrowserNavigatorTest, Disposition_SingletonTab) {
@@ skipping 285 matching lines @@
   // Navigate() should have inserted a new tab at slot 0 in the tabstrip.
   EXPECT_EQ(browser(), p.browser);
   EXPECT_EQ(0, browser()->tabstrip_model()->GetIndexOfTabContents(
       static_cast<const TabContents*>(p.target_contents)));
 
   // We should have one window - the browser() provided by the framework.
   EXPECT_EQ(1u, BrowserList::size());
   EXPECT_EQ(2, browser()->tab_count());
 }
 
+}  // namespace