Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 368006: Fix the "ls -l" FTP LIST format parser to understand correctly (Closed)

Created:
11 years, 1 month ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
Reviewers:
eroman, wtc
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix the "ls -l" FTP LIST format parser to understand correctly listings sent by VMS MultiNet servers emulating Unix. TEST=Covered by net_unittests. BUG=22193, 25520 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31217

Patch Set 1 #

Total comments: 1

Patch Set 2 : make the code more obvious #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -2 lines) Patch
A net/data/ftp/dir-listing-ls-3 View 1 chunk +7 lines, -0 lines 0 comments Download
A net/data/ftp/dir-listing-ls-3.expected View 1 chunk +53 lines, -0 lines 0 comments Download
A net/data/ftp/dir-listing-ls-4 View 1 chunk +10 lines, -0 lines 0 comments Download
A net/data/ftp/dir-listing-ls-4.expected View 1 chunk +80 lines, -0 lines 0 comments Download
M net/ftp/ftp_directory_listing_buffer_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/ftp/ftp_directory_listing_parsers.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/ftp/ftp_directory_listing_parsers.cc View 1 1 chunk +9 lines, -1 line 0 comments Download
M net/ftp/ftp_directory_listing_parsers_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Paweł Hajdan Jr.
11 years, 1 month ago (2009-11-05 15:58:42 UTC) #1
wtc
I have a "drive-by" comment. I'll let eroman do the review. http://codereview.chromium.org/368006/diff/1/7 File net/ftp/ftp_directory_listing_parsers.cc (right): ...
11 years, 1 month ago (2009-11-05 19:01:20 UTC) #2
Paweł Hajdan Jr.
On 2009/11/05 19:01:20, wtc wrote: > I have a "drive-by" comment. I'll let eroman do ...
11 years, 1 month ago (2009-11-05 20:59:37 UTC) #3
eroman
11 years, 1 month ago (2009-11-05 21:38:32 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698