net/ftp/ftp_directory_listing_parsers.h - Issue 368006: Fix the "ls -l" FTP LIST format parser to understand correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/ftp/ftp_directory_listing_parsers.h

Issue 368006: Fix the "ls -l" FTP LIST format parser to understand correctly (Closed)

Patch Set: make the code more obvious Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/ftp/ftp_directory_listing_parsers.h

diff --git a/net/ftp/ftp_directory_listing_parsers.h b/net/ftp/ftp_directory_listing_parsers.h

index 230c641814d9ec7c7a4af9086121377bae53f8c6..2cf0c4fd28193b4cef7cb754c7097ec90bccc349 100644

--- a/net/ftp/ftp_directory_listing_parsers.h

+++ b/net/ftp/ftp_directory_listing_parsers.h

@@ -55,6 +55,8 @@ class FtpLsDirectoryListingParser : public FtpDirectoryListingParser {

virtual FtpDirectoryListingEntry PopEntry();

private:

+ bool received_nonempty_line_;

std::queue<FtpDirectoryListingEntry> entries_;

DISALLOW_COPY_AND_ASSIGN(FtpLsDirectoryListingParser);