Issue 365006: Disable AssertionTest.Assertion while I figure out how I broke it...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 365006: Disable AssertionTest.Assertion while I figure out how I broke it... (Closed)

Created:
11 years, 1 month ago by cpu_(ooo_6.6-7.5)

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disable AssertionTest.Assertion while I figure out how I broke it BUG=26715 TBR=beng Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30984

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/common/logging_chrome_uitest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

11 years, 1 month ago (2009-11-04 19:56:26 UTC) #2

OK

On Wed, Nov 4, 2009 at 11:55 AM, <cpu@chromium.org> wrote:

> Reviewers: Ben Goodger,
>
> Description:
> Disable AssertionTest.Assertion while I figure out how I broke it
>
> BUG=26715
> TBR=beng
>
>
>
> Please review this at http://codereview.chromium.org/365006
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/common/logging_chrome_uitest.cc
>
>
> Index: chrome/common/logging_chrome_uitest.cc
> ===================================================================
> --- chrome/common/logging_chrome_uitest.cc      (revision 30929)
> +++ chrome/common/logging_chrome_uitest.cc      (working copy)
> @@ -80,7 +80,7 @@
>  };
>
>  // Launch the app in assertion test mode, then close the app.
> -TEST_F(AssertionTest, Assertion) {
> +TEST_F(AssertionTest, DISABLED_Assertion) {
>   if (UITest::in_process_renderer()) {
>     // in process mode doesn't do the crashing.
>     expected_errors_ = 0;
>
>
>

Expand Messages | Collapse Messages