Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 363012: Only send renderer resize messages for RWHV sizing caused by (Closed)

Created:
11 years, 1 month ago by tony
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, Evan Stade
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Only send renderer resize messages for RWHV sizing caused by TCV's size allocate message. This avoids a spurious size-allocate being sent to the renderers when creating a new tab. The extra size-allocate is called by the build-in GtkFixed's size allocate method. Another way to think of this is that we only size our RWH directly and decouple it's sizing from the GTK+ widget's sizing. BUG=26495 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31031

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M chrome/browser/renderer_host/render_widget_host_view_gtk.cc View 3 chunks +5 lines, -12 lines 0 comments Download
M chrome/browser/tab_contents/interstitial_page.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_gtk.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tony
11 years, 1 month ago (2009-11-04 22:24:24 UTC) #1
Evan Martin
11 years, 1 month ago (2009-11-04 22:26:15 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698