Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5712)

Unified Diff: chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Issue 363012: Only send renderer resize messages for RWHV sizing caused by (Closed)
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/tab_contents/interstitial_page.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/render_widget_host_view_gtk.cc
diff --git a/chrome/browser/renderer_host/render_widget_host_view_gtk.cc b/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
index e89aef2cbe47debe0333e769c382306da71f6c6a..939c8f136ab60865f98fe4f28dd65dcdaaefe5e2 100644
--- a/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
+++ b/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
@@ -66,8 +66,6 @@ class RenderWidgetHostViewGtkWidget {
GDK_LEAVE_NOTIFY_MASK);
GTK_WIDGET_SET_FLAGS(widget, GTK_CAN_FOCUS);
- g_signal_connect(widget, "size-allocate",
- G_CALLBACK(SizeAllocate), host_view);
g_signal_connect(widget, "expose-event",
G_CALLBACK(ExposeEvent), host_view);
g_signal_connect(widget, "key-press-event",
@@ -100,14 +98,6 @@ class RenderWidgetHostViewGtkWidget {
}
private:
- static gboolean SizeAllocate(GtkWidget* widget, GtkAllocation* allocation,
- RenderWidgetHostViewGtk* host_view) {
- host_view->requested_size_ = gfx::Size(allocation->width,
- allocation->height);
- host_view->GetRenderWidgetHost()->WasResized();
- return FALSE;
- }
-
static gboolean ExposeEvent(GtkWidget* widget, GdkEventExpose* expose,
RenderWidgetHostViewGtk* host_view) {
const gfx::Rect damage_rect(expose->area);
@@ -417,8 +407,11 @@ void RenderWidgetHostViewGtk::SetSize(const gfx::Size& size) {
gtk_widget_set_size_request(view_.get(), width, height);
#endif
- requested_size_ = gfx::Size(width, height);
- host_->WasResized();
+ if (requested_size_.width() != width ||
+ requested_size_.height() != height) {
+ requested_size_ = gfx::Size(width, height);
+ host_->WasResized();
+ }
}
}
« no previous file with comments | « no previous file | chrome/browser/tab_contents/interstitial_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698