Revert the isSystemKeys patch.

Revert the isSystemKeys patch.

It broke handling of shortcuts that happen in the renderer (cmd-z, cmd-shift-v). Long-term, they should all be handled in the browser, but they aren't yet.

With this patch, cmd-left/right will again no longer work for web pages with a horizontal scrollbar.

BUG=26664, 25856
TEST=Cmd-z, cmd-shift-z, cmd-shift-v should work again. cmd-left/right should no longer work on pages with a horizontal scrollbar.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31014

[Nico, 2009-11-04 20:11:55]

Seems like the lesser of two evils for now.

[jeremy, 2009-11-04 20:13:42]

LGTM

On Wed, Nov 4, 2009 at 10:11 PM, <thakis@chromium.org> wrote:

>
> Reviewers: jeremy, Avi, James Su,
>
> Message:
> Seems like the lesser of two evils for now.
>
> Description:
> Revert the isSystemKeys patch.
>
> It broke handling of shortcuts that happen in the renderer (cmd-z,
> cmd-shift-v).
> Long-term, they should all be handled in the browser, but they aren't yet.
>
> With this patch, cmd-left/right will again no longer work for web pages
> with a
> horizontal scrollbar.
>
> BUG=26664,25856
> TEST=Cmd-z, cmd-shift-z, cmd-shift-v should work again. cmd-left/right
> should no
> longer work on pages with a horizontal scrollbar.
>
> Please review this at http://codereview.chromium.org/363008
>
> Affected files:
>  M webkit/api/src/mac/WebInputEventFactory.mm
>
>
> Index: webkit/api/src/mac/WebInputEventFactory.mm
> diff --git a/webkit/api/src/mac/WebInputEventFactory.mm
> b/webkit/api/src/mac/WebInputEventFactory.mm
> index
>
5f29c50f7c5627f9c789527e4d18d38f0296da1f..74a7a8713a9c89b4a654b2539cc020ecea375260
> 100644
> --- a/webkit/api/src/mac/WebInputEventFactory.mm
> +++ b/webkit/api/src/mac/WebInputEventFactory.mm
> @@ -919,14 +919,6 @@ WebKeyboardEvent
> WebInputEventFactory::keyboardEvent(NSEvent* event)
>
>     result.timeStampSeconds = [event timestamp];
>
> -    // Windows and Linux set that if alt is down. WebKit looks at this to
> decide
> -    // if it should handle a key or not. E.g. alt-left/right shouldn't be
> used
> -    // by webkit to scroll the current page, because we want to get that
> key
> -    // back for it to do history navigation. Hence, the corresponding
> situation
> -    // on OS X is to set this for cmd key presses.
> -    if (result.modifiers & WebInputEvent::MetaKey)
> -        result.isSystemKey = true;
> -
>     return result;
>  }
>
> @@ -946,15 +938,6 @@ WebKeyboardEvent
> WebInputEventFactory::keyboardEvent(wchar_t character,
>     result.nativeKeyCode = character;
>     result.text[0] = character;
>     result.unmodifiedText[0] = character;
> -
> -    // Windows and Linux set that if alt is down. WebKit looks at this to
> decide
> -    // if it should handle a key or not. E.g. alt-left/right shouldn't be
> used
> -    // by webkit to scroll the current page, because we want to get that
> key
> -    // back for it to do history navigation. Hence, the corresponding
> situation
> -    // on OS X is to set this for cmd key presses.
> -    if (result.modifiers & WebInputEvent::MetaKey)
> -        result.isSystemKey = true;
> -
>     return result;
>  }
>
>
>
>

[pink (ping after 24hrs), 2009-11-04 22:16:07]

lgtm