Pull the OpenType sanitiser library from code.google.com/ots/, as per our dis...

Pull the OpenType sanitiser library from code.google.com/ots/, as per our discussion on the (internal) group.

Note: WebFont feature is still disabled by default. I'll change the default value when code review & security review for the sanitiser is finished.

BUG=17818
TEST=none

[Yusuke Sato, 2009-11-04 08:37:17]

Adam, could you review this?

[agl, 2009-11-04 16:22:10]

http://codereview.chromium.org/363001/diff/1/3
File DEPS (right):

http://codereview.chromium.org/363001/diff/1/3#newcode66
Line 66: "src/third_party/ots/src":
Can you not just pull in http://ots.googlecode.com/svn/trunk? If not, you should
use the "+ Var("ots_revision") pattern to make sure that they don't get out of
date. (See the previous entry.)

http://codereview.chromium.org/363001/diff/1/2
File third_party/ots/ots.gyp (right):

http://codereview.chromium.org/363001/diff/1/2#newcode1
Line 1: # Copyright (c) 2009 The Chromium Authors. All rights reserved.
This is fine but this file could also live upstream.

[dglazkov, 2009-11-04 16:46:59]

Yaar, can you look at this in re: WebKit.gyp dependencies?

[Yusuke Sato, 2009-11-05 00:21:28]

Thanks. Fixed all.

http://codereview.chromium.org/363001/diff/1/3
File DEPS (right):

http://codereview.chromium.org/363001/diff/1/3#newcode66
Line 66: "src/third_party/ots/src":
Sure. Changed to "http://.../svn/trunk@N".

On 2009/11/04 16:22:10, agl wrote:
> Can you not just pull in http://ots.googlecode.com/svn/trunk? If not, you
should
> use the "+ Var("ots_revision") pattern to make sure that they don't get out of
> date. (See the previous entry.)

http://codereview.chromium.org/363001/diff/1/2
File third_party/ots/ots.gyp (right):

http://codereview.chromium.org/363001/diff/1/2#newcode1
Line 1: # Copyright (c) 2009 The Chromium Authors. All rights reserved.
Moved to upstream.
http://code.google.com/p/ots/source/detail?r=4

On 2009/11/04 16:22:10, agl wrote:
> This is fine but this file could also live upstream.

[Yusuke Sato, 2009-11-05 05:16:38]

WebKit.gyp change is here:
https://bugs.webkit.org/show_bug.cgi?id=31106

--Yusuke

On 2009/11/04 16:46:59, Dimitri Glazkov wrote:
> Yaar, can you look at this in re: WebKit.gyp dependencies?

[yaar, 2009-11-05 06:19:40]

Yusuke,

You will also need to add the ots dependency to
third_party/WebKit/WebKit/chromium/DEPS (as part of your webkit patch).

-Yaar

On Wed, Nov 4, 2009 at 9:16 PM, <yusukes@chromium.org> wrote:

> WebKit.gyp change is here:
> https://bugs.webkit.org/show_bug.cgi?id=31106
>
> --Yusuke
>
>
> On 2009/11/04 16:46:59, Dimitri Glazkov wrote:
>
>> Yaar, can you look at this in re: WebKit.gyp dependencies?
>>
>
>
>
> http://codereview.chromium.org/363001
>

[Yusuke Sato, 2009-11-06 01:38:34]

Just uploaded a new patch set that contains the WebKit/chromium/DEPS change.

agl:
Can you please take another look at this CL?

--Yusuke


On 2009/11/05 06:19:40, yaar wrote:
> Yusuke,
> 
> You will also need to add the ots dependency to
> third_party/WebKit/WebKit/chromium/DEPS (as part of your webkit patch).
> 
> -Yaar
> 
> On Wed, Nov 4, 2009 at 9:16 PM, <mailto:yusukes@chromium.org> wrote:
> 
> > WebKit.gyp change is here:
> > https://bugs.webkit.org/show_bug.cgi?id=31106
> >
> > --Yusuke
> >
> >
> > On 2009/11/04 16:46:59, Dimitri Glazkov wrote:
> >
> >> Yaar, can you look at this in re: WebKit.gyp dependencies?
> >>
> >
> >
> >
> > http://codereview.chromium.org/363001
> >
>

[Yusuke Sato, 2009-11-09 09:30:25]

Added build/features_override.gypi to the patch set.

[agl, 2009-11-09 23:31:02]

LGTM

[Yusuke Sato, 2009-11-13 02:19:07]

Landed in r31878.