Issue 362008: gclient: Make revinfo work on git.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 362008: gclient: Make revinfo work on git. (Closed)

Created:
11 years, 1 month ago by Mandeep Singh Baines

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

gclient: Make revinfo work on git. * Add revinfo as part of SCMWrapper interface. * Implement revinfo for git and svn. * Add unit tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31280

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -16 lines)			Patch
M	gclient.py	View	1 chunk	+2 lines, -2 lines	1 comment	Download
M	gclient_scm.py	View	3 chunks	+9 lines, -1 line	0 comments	Download
M	tests/gclient_scm_test.py	View	9 chunks	+51 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

msb

ping msb@chromium.org (msb@chromium.org) wrote: > Reviewers: Marc-Antoine Ruel, > > Description: > gclient: Make revinfo ...

11 years, 1 month ago (2009-11-05 19:29:48 UTC) #2

M-A Ruel

11 years, 1 month ago (2009-11-05 19:33:35 UTC) #3

lgtm with one line removed.

http://codereview.chromium.org/362008/diff/1/2
File gclient.py (right):

http://codereview.chromium.org/362008/diff/1/2#newcode816
Line 816: # TODO(aharper): SVN/SCMWrapper cleanup (non-local commandset)
shouldn't the TODO be removed?

Expand Messages | Collapse Messages