Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 361032: Added validation to adding new search engines (Closed)

Created:
11 years, 1 month ago by GeorgeY
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Added validation to adding new search engines - 3rd iteration :) BUG=21882 TEST=none

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 3

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
MM chrome/browser/cocoa/edit_search_engine_cocoa_controller_unittest.mm View 2 3 5 4 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/search_engines/edit_search_engine_controller.cc View 1 2 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
GeorgeY
11 years, 1 month ago (2009-11-06 00:03:32 UTC) #1
tfarina (gmail-do not use)
http://codereview.chromium.org/361032/diff/2001/3002 File chrome/browser/search_engines/edit_search_engine_controller.cc (right): http://codereview.chromium.org/361032/diff/2001/3002#newcode59 Line 59: return true; // Always allow no keyword. The ...
11 years, 1 month ago (2009-11-06 12:40:26 UTC) #2
GeorgeY
http://codereview.chromium.org/361032/diff/2001/3002 File chrome/browser/search_engines/edit_search_engine_controller.cc (right): http://codereview.chromium.org/361032/diff/2001/3002#newcode59 Line 59: return true; // Always allow no keyword. On ...
11 years, 1 month ago (2009-11-06 17:35:47 UTC) #3
georgey1
BTW, this is how it is implemented in original code. I could either remove validity ...
11 years, 1 month ago (2009-11-06 17:46:38 UTC) #4
jcampan
http://codereview.chromium.org/361032/diff/2001/3002 File chrome/browser/search_engines/edit_search_engine_controller.cc (right): http://codereview.chromium.org/361032/diff/2001/3002#newcode42 Line 42: if (url_input.find(L"%s") == std::wstring::npos) Just talked with Scott ...
11 years, 1 month ago (2009-11-06 18:10:47 UTC) #5
georgey1
OK, reverting this, np On Fri, Nov 6, 2009 at 10:10 AM, <jcampan@chromium.org> wrote: > ...
11 years, 1 month ago (2009-11-06 18:13:16 UTC) #6
GeorgeY
11 years, 1 month ago (2009-11-06 19:21:35 UTC) #7
tfarina (gmail-do not use)
http://codereview.chromium.org/361032/diff/6002/7001 File chrome/browser/search_engines/edit_search_engine_controller.cc (right): http://codereview.chromium.org/361032/diff/6002/7001#newcode55 Line 55: return false; // Do not allow empty keyword. ...
11 years, 1 month ago (2009-11-06 19:26:15 UTC) #8
jcampan
LGTM
11 years, 1 month ago (2009-11-06 20:07:48 UTC) #9
tfarina (gmail-do not use)
The mac failures seems real. Maybe you need to update some tests in edit_search_engine_cocoa_controller_unittest.mm to ...
11 years, 1 month ago (2009-11-06 20:14:29 UTC) #10
GeorgeY
On 2009/11/06 20:14:29, tfarina wrote: > The mac failures seems real. > > Maybe you ...
11 years, 1 month ago (2009-11-06 20:44:23 UTC) #11
GeorgeY
All tests on mac are working, cl re-uploaded
11 years, 1 month ago (2009-11-06 22:07:29 UTC) #12
tfarina (gmail-do not use)
11 years, 1 month ago (2009-11-06 22:14:35 UTC) #13
LG

Powered by Google App Engine
This is Rietveld 408576698