Add VBOOT to top-level Makefile

Add VBOOT to top-level Makefile

This CL adds argument "VBOOT" to top-level Makefile and config.mk that points
to a verify boot implementation.

Change-Id: Ib468cc7a6a7c3ce3db56b90d73c6022ac30fa046

BUG=none
TEST=Run "make all" successfully

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=092ef63

[Che-Liang Chiou, 2010-10-05 09:05:59]

robotboy: u-boot Makefile in general
Randall: whether Makefile includes all necessary files of vboot_reference
Hung-Te: FYI

[Hung-Te, 2010-10-05 10:08:02]

ACK

[Randall Spangler, 2010-10-05 16:13:23]

LGTM

Linking in vboot firmware requires only vboot_fw library (from firmware/lib) and
the interface headers (from firmware/include).

[robotboy, 2010-10-05 17:05:01]

http://codereview.chromium.org/3515011/diff/1/3
File config.mk (right):

http://codereview.chromium.org/3515011/diff/1/3#newcode140
config.mk:140: CPPFLAGS += -I$(VBOOT)/include/vboot -I$(TOPDIR)/include/vboot
Do we need the -I$(TOPDIR)/include/vboot here?  I assume that the
$(VBOOT)/include/vboot makes all of the vboot_reference headers happy, and that
we could just add vboot/ in front of any headers we reference in
$(TOPDIR)/include/vboot and rely on the -I$(TOPDIR)/include below.  Or am I
missing something?  Generally I prefer to reduce the number of entries in the
search path for headers by being more explicit in the #includes.

Thanks,
    Anton

[robotboy, 2010-10-05 17:23:01]

On 2010/10/05 17:05:01, robotboy wrote:
> http://codereview.chromium.org/3515011/diff/1/3
> File config.mk (right):
> 
> http://codereview.chromium.org/3515011/diff/1/3#newcode140
> config.mk:140: CPPFLAGS += -I$(VBOOT)/include/vboot -I$(TOPDIR)/include/vboot
> Do we need the -I$(TOPDIR)/include/vboot here?  I assume that the
> $(VBOOT)/include/vboot makes all of the vboot_reference headers happy, and
that
> we could just add vboot/ in front of any headers we reference in
> $(TOPDIR)/include/vboot and rely on the -I$(TOPDIR)/include below.  Or am I
> missing something?  Generally I prefer to reduce the number of entries in the
> search path for headers by being more explicit in the #includes.
> 
> Thanks,
>     Anton

Hmm, possibly answering my own question, is this needed because the vboot
headers try to include sysincludes.h and they won't find it in our u-boot
specific vboot location without this extra path in the search?  I can't think of
a good way around that in the short term...

LGTM.

-Anton

[Che-Liang Chiou, 2010-10-06 02:22:07]

Hi Anton,

Thanks for your comments and suggestions.  I made a $(TOPDIR)/includes/vboot
directory for a local sysincludes.h, but Randall in a separate CL told me that I
should not use a local sysincludes.h.

I remove $(TOPDIR)/include/vboot since it is not needed anymore.

http://codereview.chromium.org/3515011/diff/1/3
File config.mk (right):

http://codereview.chromium.org/3515011/diff/1/3#newcode140
config.mk:140: CPPFLAGS += -I$(VBOOT)/include/vboot -I$(TOPDIR)/include/vboot
On 2010/10/05 17:05:01, robotboy wrote:
> Do we need the -I$(TOPDIR)/include/vboot here?  I assume that the
> $(VBOOT)/include/vboot makes all of the vboot_reference headers happy, and
that
> we could just add vboot/ in front of any headers we reference in
> $(TOPDIR)/include/vboot and rely on the -I$(TOPDIR)/include below.  Or am I
> missing something?  Generally I prefer to reduce the number of entries in the
> search path for headers by being more explicit in the #includes.
> 
> Thanks,
>     Anton

Done.

[robotboy, 2010-10-06 17:34:24]

LGTM, thanks.