Issue 3604006: Revert 61462 - Add truncate and cancel for FileWriter; write and more tests w...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3604006: Revert 61462 - Add truncate and cancel for FileWriter; write and more tests w... (Closed)

Created:
10 years, 2 months ago by ericu

Modified:
9 years, 7 months ago

Reviewers:
Eric U.

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr., jam, darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 61462 - Add truncate and cancel for FileWriter; write and more tests will come in later CLs. This CL also contains a fair amount of plumbing for the write call itself. BUG=none TEST=none Review URL: http://codereview.chromium.org/3599011 TBR=ericu@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61463

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+91 lines, -229 lines)			Patch
M	base/file_util_proxy.h	View	2 chunks	+2 lines, -11 lines	0 comments	Download
M	base/file_util_proxy.cc	View	4 chunks	+7 lines, -50 lines	0 comments	Download
M	chrome/browser/file_system/file_system_dispatcher_host.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/common/file_system/file_system_dispatcher.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/common/file_system/webfilesystem_callback_dispatcher.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/file_system/webfilesystem_callback_dispatcher.cc	View	3 chunks	+25 lines, -12 lines	0 comments	Download
M	webkit/fileapi/file_system_callback_dispatcher.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	webkit/fileapi/file_system_operation.h	View	3 chunks	+6 lines, -25 lines	0 comments	Download
M	webkit/fileapi/file_system_operation.cc	View	14 chunks	+46 lines, -55 lines	0 comments	Download
M	webkit/fileapi/file_system_operation_unittest.cc	View	2 chunks	+0 lines, -58 lines	0 comments	Download
M	webkit/glue/plugins/pepper_file_system.cc	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	webkit/tools/test_shell/simple_file_system.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages