Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4320)

Unified Diff: chrome/common/file_system/webfilesystem_callback_dispatcher.cc

Issue 3604006: Revert 61462 - Add truncate and cancel for FileWriter; write and more tests w... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/file_system/webfilesystem_callback_dispatcher.cc
===================================================================
--- chrome/common/file_system/webfilesystem_callback_dispatcher.cc (revision 61462)
+++ chrome/common/file_system/webfilesystem_callback_dispatcher.cc (working copy)
@@ -18,6 +18,30 @@
using WebKit::WebString;
using WebKit::WebVector;
+namespace {
+
+WebKit::WebFileError PlatformFileErrorToWebFileError(
+ base::PlatformFileError error_code) {
+ switch (error_code) {
+ case base::PLATFORM_FILE_ERROR_NOT_FOUND:
+ return WebKit::WebFileErrorNotFound;
+ case base::PLATFORM_FILE_ERROR_INVALID_OPERATION:
+ case base::PLATFORM_FILE_ERROR_EXISTS:
+ case base::PLATFORM_FILE_ERROR_NOT_A_DIRECTORY:
+ return WebKit::WebFileErrorInvalidModification;
+ case base::PLATFORM_FILE_ERROR_ACCESS_DENIED:
+ return WebKit::WebFileErrorNoModificationAllowed;
+ case base::PLATFORM_FILE_ERROR_FAILED:
+ return WebKit::WebFileErrorInvalidState;
+ case base::PLATFORM_FILE_ERROR_ABORT:
+ return WebKit::WebFileErrorAbort;
+ default:
+ return WebKit::WebFileErrorInvalidModification;
+ }
+}
+
+}
+
WebFileSystemCallbackDispatcher::WebFileSystemCallbackDispatcher(
WebFileSystemCallbacks* callbacks)
: callbacks_(callbacks) {
@@ -32,11 +56,6 @@
const base::PlatformFileInfo& file_info) {
WebFileInfo web_file_info;
web_file_info.modificationTime = file_info.last_modified.ToDoubleT();
- web_file_info.length = file_info.size;
- if (file_info.is_directory)
- web_file_info.type = WebFileInfo::TypeDirectory;
- else
- web_file_info.type = WebFileInfo::TypeFile;
callbacks_->didReadMetadata(web_file_info);
}
@@ -59,11 +78,5 @@
void WebFileSystemCallbackDispatcher::DidFail(
base::PlatformFileError error_code) {
- callbacks_->didFail(
- webkit_glue::PlatformFileErrorToWebFileError(error_code));
+ callbacks_->didFail(PlatformFileErrorToWebFileError(error_code));
}
-
-void WebFileSystemCallbackDispatcher::DidWrite(int64 bytes, bool complete) {
- NOTREACHED();
-}
-
« no previous file with comments | « chrome/common/file_system/webfilesystem_callback_dispatcher.h ('k') | webkit/fileapi/file_system_callback_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698