Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 360035: Fix first run ui hanging. The threads need to get started earlier.... (Closed)

Created:
11 years, 1 month ago by jam
Modified:
9 years, 7 months ago
Reviewers:
kuchhal
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Fix first run ui hanging. The threads need to get started earlier. BUG=26614 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31046

Patch Set 1 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/browser/browser_main.cc View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
11 years, 1 month ago (2009-11-05 00:03:21 UTC) #1
kuchhal
11 years, 1 month ago (2009-11-05 00:10:06 UTC) #2
lgtm.

On Wed, Nov 4, 2009 at 4:03 PM, <jam@chromium.org> wrote:

> Reviewers: kuchhal,
>
> Description:
> Fix first run ui hanging.  The threads need to get started earlier.
>
> BUG=26614
>
> Please review this at http://codereview.chromium.org/360035
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/browser_main.cc
>
>
> Index: chrome/browser/browser_main.cc
> ===================================================================
> --- chrome/browser/browser_main.cc      (revision 30973)
> +++ chrome/browser/browser_main.cc      (working copy)
> @@ -620,6 +620,13 @@
>     }
>   }
>
> +  // Create the child threads.  We need to do this since
> ChromeThread::PostTask
> +  // silently deletes a posted task if the target message loop isn't
> created.
> +  // Note: must be done before FirstRun code is run.
> +  browser_process->db_thread();
> +  browser_process->file_thread();
> +  browser_process->io_thread();
> +
>   // Importing other browser settings is done in a browser-like process
>   // that exits when this task has finished.
>  #if defined(OS_WIN)
> @@ -701,12 +708,6 @@
>   net::EnsureWinsockInit();
>  #endif  // defined(OS_WIN)
>
> -  // Create the child threads.  We need to do this since
> ChromeThread::PostTask
> -  // silently deletes a posted task if the target message loop isn't
> created.
> -  browser_process->db_thread();
> -  browser_process->file_thread();
> -  browser_process->io_thread();
> -
>   // Initialize and maintain DNS prefetcher module.
>   chrome_browser_net::DnsPrefetcherInit dns_prefetch(user_prefs,
> local_state);
>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698