Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 360018: Removed command_buffer dependency on vectormath (indirectly via core/types.h)... (Closed)

Created:
11 years, 1 month ago by apatrick
Modified:
9 years, 7 months ago
Reviewers:
Greg Spencer
CC:
o3d-review_googlegroups.com
Visibility:
Public.

Description

Removed command_buffer dependency on vectormath (indirectly via core/types.h). Changed common.gypi to automatically select cb_service of d3d9 pr gl in chrome builds. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30987

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -143 lines) Patch
MM build/common.gypi View 1 chunk +56 lines, -22 lines 0 comments Download
MM command_buffer/command_buffer.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
MM command_buffer/service/cross/cmd_parser.h View 1 chunk +0 lines, -1 line 0 comments Download
MM command_buffer/service/cross/common_decoder.h View 1 chunk +109 lines, -110 lines 0 comments Download
MM command_buffer/service/cross/gapi_decoder.h View 1 chunk +0 lines, -1 line 0 comments Download
MM command_buffer/service/cross/resource.h View 2 chunks +1 line, -2 lines 0 comments Download
M gpu_plugin/gpu_plugin.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu_plugin/np_utils/np_browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu_plugin/np_utils/np_headers.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
apatrick
11 years, 1 month ago (2009-11-04 20:19:31 UTC) #1
Greg Spencer
11 years, 1 month ago (2009-11-04 20:22:46 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698