Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: build/common.gypi

Issue 360018: Removed command_buffer dependency on vectormath (indirectly via core/types.h)... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/o3d/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | command_buffer/command_buffer.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 30977)
+++ build/common.gypi (working copy)
@@ -20,38 +20,72 @@
'seleniumdir': 'third_party/selenium_rc/files',
'skiadir': 'third_party/skia/include',
'zlibdir': 'third_party/zlib',
- # If the DEPS file exists two levels up, then we're in a Chrome tree.
- 'o3d_in_chrome%': '<!(python <(DEPTH)/o3d/build/file_exists.py <(DEPTH)/DEPS)',
+
+ # Hack to ensure that these variables (specifically "renderer" and
+ # "cb_service") are available later in the file. Long term solution is late
+ # evaluation of variables.
+ 'variables': {
+ # If the DEPS file exists two levels up, then we're in a Chrome tree.
+ 'o3d_in_chrome%': '<!(python <(DEPTH)/o3d/build/file_exists.py <(DEPTH)/DEPS)',
+ 'conditions' : [
+ # These have to come first because GYP doesn't like it when
+ # they're part of the same conditional as a conditions clause that
+ # uses them.
+ ['OS == "win"',
+ {
+ 'cgdir': 'third_party/cg/files/win',
+ 'renderer%': 'd3d9',
+ 'cb_service%': 'none',
+ 'swiftshaderdir': 'o3d-internal/third_party/swiftshader/files',
+ },
+ ],
+ ['OS == "mac"',
+ {
+ 'cgdir': 'third_party/cg/files/mac',
+ 'renderer%': 'gl',
+ 'cb_service%': 'none',
+ 'swiftshaderdir': '',
+ },
+ ],
+ ['OS == "linux"',
+ {
+ 'cgdir': 'third_party/cg/files/linux',
+ 'renderer%': 'gl',
+ 'cb_service%': 'none',
+ 'swiftshaderdir': '',
+ },
+ ],
+ ],
+ },
+ 'o3d_in_chrome%': '<(o3d_in_chrome)',
+ 'renderer%': '<(renderer)',
+ 'cgdir%': '<(cgdir)',
+ 'swiftshaderdir%': '<(swiftshaderdir)',
+ 'cb_service%': '<(cb_service)',
+
# We default to building everything only if the assets exist.
# (and the teapot is the least likely asset to change).
# This is so that chrome developers get a much reduced dependency set.
'o3d_developer%': '<!(python <(DEPTH)/o3d/build/file_exists.py '
'<(DEPTH)/o3d/o3d_assets/samples/convert_assets/teapot.zip)',
'selenium_screenshots%': 0,
- 'cb_service%': 'none',
+
'conditions' : [
- # These have to come first because GYP doesn't like it when
- # they're part of the same conditional as a conditions clause that
- # uses them.
- ['OS == "win"',
+ ['o3d_in_chrome == "True"',
{
- 'cgdir': 'third_party/cg/files/win',
- 'renderer%': 'd3d9',
- 'swiftshaderdir': 'o3d-internal/third_party/swiftshader/files',
+ 'renderer': 'cb',
+ 'conditions': [
+ ['OS == "win"',
+ {
+ 'cb_service': 'd3d9',
+ },
+ {
+ 'cb_service': 'gl',
+ },
+ ],
+ ],
},
],
- ['OS == "mac"',
- {
- 'cgdir': 'third_party/cg/files/mac',
- 'renderer%': 'gl',
- },
- ],
- ['OS == "linux"',
- {
- 'cgdir': 'third_party/cg/files/linux',
- 'renderer%': 'gl',
- },
- ],
],
},
'target_defaults': {
Property changes on: build\common.gypi
___________________________________________________________________
Added: svn:eol-style
+ LF
« no previous file with comments | « no previous file | command_buffer/command_buffer.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698