Issue 360002: Fix for broken mini_installer_test...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 360002: Fix for broken mini_installer_test... (Closed)

Created:
11 years, 1 month ago by cpu_(ooo_6.6-7.5)

Modified:
9 years, 7 months ago

Reviewers:
kuchhal

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix for broken mini_installer_test - Definitely broken. Nice to have these tests BUG=none TEST=none TBR=kuchhal Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30944

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/app/client_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

I need to clean this up, but right now I need to fix the tree.

11 years, 1 month ago (2009-11-04 05:33:03 UTC) #1

kuchhal

11 years, 1 month ago (2009-11-04 16:39:14 UTC) #2

lgtm.

On Tue, Nov 3, 2009 at 9:33 PM, <cpu@chromium.org> wrote:

> Reviewers: kuchhal,
>
> Message:
> I need to clean this up, but right now I need to fix the tree.
>
>
> Description:
> Fix for broken mini_installer_test
> - Definitely broken. Nice to have these tests
>
> BUG=none
> TEST=none
>
> TBR=kuchhal
>
>
> Please review this at http://codereview.chromium.org/360002
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/app/client_util.cc
>
>
> Index: chrome/app/client_util.cc
> ===================================================================
> --- chrome/app/client_util.cc   (revision 30934)
> +++ chrome/app/client_util.cc   (working copy)
> @@ -139,7 +139,7 @@
>   }
>
>   *file = dir;
> -  file->append(*version);
> +  file->append(*version).append(L"\\");
>   return LoadChromeWithDirectory(file);
>  }
>
>
>
>

Expand Messages | Collapse Messages