Issue 3591019: AU: Delta Performer: properly detect idempotent operations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3591019: AU: Delta Performer: properly detect idempotent operations (Closed)

Created:
10 years, 2 months ago by adlr

Modified:
9 years ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
ssh://git@chromiumos-git/update_engine.git

Visibility:
Public.

Description

AU: Delta Performer: properly detect idempotent operations Idempotent operations can be restarted after being aborted. This CL enables the delta performer to find many idempotent operations. The algorithm given is pretty good, tho it may incorrectly mark some idempotent operations as non-idempotent. For example, a BSDIFF operation may write a block that it reads with the same data; that's idempotent, but missed by this algorithm. This function just looks to see if the src/dst blocks are non-intersecting and, if non intersecting, declares it idempotent. BUG=7394 TEST=unittest Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=353777c

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -11 lines)			Patch
M	delta_performer.h	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	delta_performer.cc	View	3 chunks	+19 lines, -11 lines	0 comments	Download
M	delta_performer_unittest.cc	View	2 chunks	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adlr

10 years, 2 months ago (2010-10-08 17:37:37 UTC) #3

pushed. i didn't put in the exactly overlapping change, but filed bug
http://code.google.com/p/chromium-os/issues/detail?id=7543

On Thu, Oct 7, 2010 at 9:08 PM, <petkov@chromium.org> wrote:

> LGTM
>
>
>
> http://codereview.chromium.org/3591019/show
>

Expand Messages | Collapse Messages