Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1708)

Unified Diff: delta_performer_unittest.cc

Issue 3591019: AU: Delta Performer: properly detect idempotent operations (Closed) Base URL: ssh://git@chromiumos-git/update_engine.git
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « delta_performer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: delta_performer_unittest.cc
diff --git a/delta_performer_unittest.cc b/delta_performer_unittest.cc
index 8717e07a6f2c1f9dd9feef2e937dd7bea6b84d03..904553e54b2c0fd69a7cf388a0876bbe6bb144a0 100755
--- a/delta_performer_unittest.cc
+++ b/delta_performer_unittest.cc
@@ -16,6 +16,7 @@
#include "update_engine/delta_diff_generator.h"
#include "update_engine/delta_performer.h"
+#include "update_engine/extent_ranges.h"
#include "update_engine/graph_types.h"
#include "update_engine/payload_signer.h"
#include "update_engine/prefs_mock.h"
@@ -347,4 +348,20 @@ TEST(DeltaPerformerTest, NewFullUpdateTest) {
}
}
+TEST(DeltaPerformerTest, IsIdempotentOperationTest) {
+ DeltaArchiveManifest_InstallOperation op;
+ EXPECT_TRUE(DeltaPerformer::IsIdempotentOperation(op));
+ *(op.add_dst_extents()) = ExtentForRange(0, 5);
+ EXPECT_TRUE(DeltaPerformer::IsIdempotentOperation(op));
+ *(op.add_src_extents()) = ExtentForRange(4, 1);
+ EXPECT_FALSE(DeltaPerformer::IsIdempotentOperation(op));
+ op.clear_src_extents();
+ *(op.add_src_extents()) = ExtentForRange(5, 3);
+ EXPECT_TRUE(DeltaPerformer::IsIdempotentOperation(op));
+ *(op.add_dst_extents()) = ExtentForRange(20, 6);
+ EXPECT_TRUE(DeltaPerformer::IsIdempotentOperation(op));
+ *(op.add_src_extents()) = ExtentForRange(19, 2);
+ EXPECT_FALSE(DeltaPerformer::IsIdempotentOperation(op));
+}
+
} // namespace chromeos_update_engine
« no previous file with comments | « delta_performer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698