Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 3590023: Merge 69161 - 2010-10-05 Fady Samuel <fsamuel@chromium.org>... (Closed)

Created:
10 years, 2 months ago by Fady Samuel
Modified:
9 years, 6 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/517/
Visibility:
Public.

Description

Merge 69161 - 2010-10-05 Fady Samuel <fsamuel@chromium.org>; Reviewed by Darin Adler. REGRESSION (r65539): One pixel white gaps when scrolling Trac changeset pages https://bugs.webkit.org/show_bug.cgi?id=45131 Added a layout test to check for paint rects that touch the border of an adjacent sell, when border-collapse: separate is set for the table. * fast/table/simple_paint.html: Don't do rtl as it doesn't exercise some of the new paint code. * fast/table/simple_paint_separate_borders-expected.checksum: Added. * fast/table/simple_paint_separate_borders-expected.png: Added. * fast/table/simple_paint_separate_borders-expected.txt: Added. * fast/table/simple_paint_separate_borders.html: Added. 2010-10-05 Fady Samuel <fsamuel@chromium.org>; Reviewed by Darin Adler. REGRESSION (r65539): One pixel white gaps when scrolling Trac changeset pages https://bugs.webkit.org/show_bug.cgi?id=45131 When border-collapse: separate property is set on the table, paintObject may skip repainting cells, if the dirty region only touches one row/col of pixels. Test: fast/table/simple_paint_separate_borders.html * rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paintObject): Don't subtract one from the right and bottom of the dirty paint rect. TBR=fsamuel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69233

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7754 lines, -22 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +3626 lines, -0 lines 0 comments Download
M LayoutTests/fast/table/simple_paint.html View 2 chunks +21 lines, -17 lines 0 comments Download
M LayoutTests/fast/table/simple_paint-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/table/simple_paint-expected.png View Binary file 0 comments Download
M WebCore/ChangeLog View 1 chunk +4102 lines, -0 lines 0 comments Download
M WebCore/rendering/RenderTableSection.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Fady Samuel
10 years, 2 months ago (2010-10-06 21:13:04 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698