Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Unified Diff: WebCore/ChangeLog

Side-by-side diff isn't available for this file because of its large size.
Issue 3590023: Merge 69161 - 2010-10-05 Fady Samuel <fsamuel@chromium.org>... (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/517/
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « LayoutTests/fast/table/simple_paint-expected.png ('k') | WebCore/rendering/RenderTableSection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog (revision 69232)
+++ WebCore/ChangeLog (working copy)
@@ -1,3 +1,4105 @@
+2010-10-05 Fady Samuel <fsamuel@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ REGRESSION (r65539): One pixel white gaps when scrolling Trac changeset pages
+ https://bugs.webkit.org/show_bug.cgi?id=45131
+
+ When border-collapse: separate property is set on the table, paintObject
+ may skip repainting cells, if the dirty region only touches one row/col of pixels.
+
+ Test: fast/table/simple_paint_separate_borders.html
+
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::paintObject):
+ Don't subtract one from the right and bottom of the dirty paint rect.
+
+2010-10-05 Sanjeev Radhakrishnan <sanjeevr@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ PluginDocument now holds on to the created plugin node so that the pluginNode() and pluginWidget() methods can return the correct node.
+ https://bugs.webkit.org/show_bug.cgi?id=47129
+
+ * html/PluginDocument.cpp:
+ (WebCore::PluginDocumentParser::createDocumentStructure):
+ (WebCore::PluginDocument::pluginWidget):
+ (WebCore::PluginDocument::pluginNode):
+ * html/PluginDocument.h:
+ (WebCore::PluginDocument::setPluginNode):
+
+2010-10-05 Andreas Kling <kling@webkit.org>
+
+ Reviewed by Tor Arne Vestbø.
+
+ [Qt] Re-enable single-NPP_SetWindow quirk for 64-bit
+ https://bugs.webkit.org/show_bug.cgi?id=45363
+
+ This is still causing trouble for people, so let's put the
+ quirk back until we can figure this out properly.
+
+ * plugins/PluginPackage.cpp:
+ (WebCore::PluginPackage::determineQuirks):
+
+2010-10-05 Jian Li <jianli@chromium.org>
+
+ Reviewed by Nate Chapin.
+
+ [V8] Add FileReader to active DOM map
+ https://bugs.webkit.org/show_bug.cgi?id=47205
+
+ We need to have a custom FileReader V8 constructor in order to add object
+ into active DOM map to prevent it from GC-ed when it is still in-use.
+
+ * Android.v8bindings.mk:
+ * WebCore.gypi:
+ * bindings/scripts/CodeGeneratorV8.pm:
+ * bindings/v8/custom/V8FileReaderCustom.cpp: Added.
+ (WebCore::V8FileReader::constructorCallback):
+ * fileapi/FileReader.idl:
+
+2010-10-05 Vincent Scheib <scheib@chromium.org>
+
+ Reviewed by Kenneth Russell.
+
+ [chromium] 51304 GPU compositor resorts to "slow" text rendering for base page layer
+ https://bugs.webkit.org/show_bug.cgi?id=47193
+
+ Test: Accelerated compositor test infrastructure still coming online. Tested manually.
+
+ * platform/graphics/chromium/LayerRendererChromium.cpp:
+ (WebCore::LayerRendererChromium::setRootLayerCanvasSize):
+ (WebCore::LayerRendererChromium::prepareToDrawLayers):
+ (WebCore::LayerRendererChromium::drawLayers):
+
+2010-10-05 Nico Weber <thakis@chromium.org>
+
+ Reviewed by Andreas Kling.
+
+ Fix clang build
+ https://bugs.webkit.org/show_bug.cgi?id=47198
+
+ * page/Chrome.h:
+ Declare ViewportArguments as struct, not as class.
+
+2010-10-05 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=47204
+
+ Make isSelfCollapsingBlock use logical height instead of height in all its checks.
+
+ Added fast/blockflow/self-collapsing-block.html
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::isSelfCollapsingBlock):
+
+2010-10-05 Eric Uhrhane <ericu@chromium.org>
+
+ Reviewed by David Levin.
+
+ Relax restrictions on FileWriter::didWrite calls
+ https://bugs.webkit.org/show_bug.cgi?id=47139
+
+ No new tests; they're still waiting on the first implementation.
+
+ * fileapi/FileWriter.cpp:
+ (WebCore::FileWriter::FileWriter):
+ (WebCore::FileWriter::write):
+ (WebCore::FileWriter::didWrite):
+ * fileapi/FileWriter.h:
+
+2010-10-05 Daniel Cheng <dcheng@chromium.org>
+
+ Reviewed by Tony Chang.
+
+ [chromium] getData('text/uri-list') should return the same thing that was passed to setData('text/uri-list')
+ https://bugs.webkit.org/show_bug.cgi?id=46943
+
+ We no longer parse the input of setData('text/uri-list') and only store
+ the valid URLs that were parsed out.
+
+ Test: editing/pasteboard/dataTransfer-setData-getData.html
+
+ * platform/chromium/ChromiumDataObject.cpp:
+ (WebCore::ChromiumDataObject::clearData):
+ (WebCore::ChromiumDataObject::clearAllExceptFiles):
+ (WebCore::ChromiumDataObject::types):
+ (WebCore::ChromiumDataObject::getData):
+ (WebCore::ChromiumDataObject::setData):
+ * platform/chromium/ChromiumDataObject.h:
+
+2010-10-05 Martin Robinson <mrobinson@igalia.com>
+
+ Reviewed by Xan Lopez.
+
+ [GTK] Support FontPlatformData::isFixedPitch for custom fonts
+ https://bugs.webkit.org/show_bug.cgi?id=47124
+
+ Instead of determining whether or not a font is a fixed-width font
+ lazily, do it up front. For fonts not backed by Fontconfig patterns,
+ fetch information about whether or not the font is fixed-width from
+ the FreeType face.
+
+ No new tests as this should not change functionality.
+
+ * platform/graphics/cairo/FontPlatformDataFreeType.cpp:
+ (WebCore::FontPlatformData::FontPlatformData): Initialize the m_fixedWidth member
+ from the Fontconfig pattern or the FreeType face.
+ (WebCore::FontPlatformData::operator=): Copy over the m_fixedWidth member.
+ (WebCore::FontPlatformData::isFixedPitch): Just return the value of the m_fixedWidth member.
+ * platform/graphics/cairo/FontPlatformDataFreeType.h: Added an m_fixedWidth member.
+
+2010-10-05 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=47199
+
+ Make float positioning work in block layout with block children.
+ It doesn't work yet from inside line layout, since line layout is unpatched.
+
+ Added fast/blockflow/floats-in-block-layout.html
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::adjustFloatingBlock):
+ (WebCore::RenderBlock::setLogicalLeftForChild):
+ (WebCore::RenderBlock::setLogicalTopForChild):
+ (WebCore::RenderBlock::insertFloatingObject):
+ (WebCore::RenderBlock::positionNewFloats):
+ (WebCore::RenderBlock::logicalLeftOffsetForLine):
+ (WebCore::RenderBlock::logicalRightOffsetForLine):
+ * rendering/RenderBlock.h:
+ (WebCore::RenderBlock::FloatingObject::type):
+ (WebCore::RenderBlock::FloatingObject::renderer):
+ (WebCore::RenderBlock::logicalRightForFloat):
+ (WebCore::RenderBlock::setLogicalTopForFloat):
+ (WebCore::RenderBlock::setLogicalLeftForFloat):
+ (WebCore::RenderBlock::setLogicalHeightForFloat):
+ (WebCore::RenderBlock::setLogicalWidthForFloat):
+
+2010-10-05 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ [Qt] Web process crash when pressing modifiers in input field
+ https://bugs.webkit.org/show_bug.cgi?id=44935
+
+ Revert part of the http://trac.webkit.org/changeset/69105 due to a
+ test regression. Unix: Add ASSERTs to plugin related code. These
+ will fail if Qt WebKit2 is used with plugins, unless code is not
+ fixed before.
+
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::setXKeyEventSpecificFields): Use qKeyEvent, Use ASSERT as a reminder.
+
+2010-10-05 Chris Rogers <crogers@google.com>
+
+ Reviewed by Kenneth Russell.
+
+ Add AudioBasicProcessorNode files
+ https://bugs.webkit.org/show_bug.cgi?id=46495
+
+ No new tests since audio API is not yet implemented.
+
+ * webaudio/AudioBasicProcessorNode.cpp: Added.
+ (WebCore::AudioBasicProcessorNode::AudioBasicProcessorNode):
+ (WebCore::AudioBasicProcessorNode::initialize):
+ (WebCore::AudioBasicProcessorNode::uninitialize):
+ (WebCore::AudioBasicProcessorNode::process):
+ (WebCore::AudioBasicProcessorNode::pullInputs):
+ (WebCore::AudioBasicProcessorNode::reset):
+ (WebCore::AudioBasicProcessorNode::checkNumberOfChannelsForInput):
+ (WebCore::AudioBasicProcessorNode::numberOfChannels):
+ * webaudio/AudioBasicProcessorNode.h: Added.
+ (WebCore::AudioBasicProcessorNode::processor):
+
+2010-10-05 Chris Marrin <cmarrin@apple.com>
+
+ Unreviewed.
+
+ The platform/graphics/gpu folder was mistakenly inside the filters folder.
+ I moved it to the right place in the Group Tree.
+
+ * WebCore.xcodeproj/project.pbxproj:
+
+2010-10-05 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Adam Roben.
+
+ Fix ownership of GraphicsContext3D in SharedGraphicsContext3D to prevent early deallocation and crash
+ https://bugs.webkit.org/show_bug.cgi?id=47197
+
+ This is work in progress and the crash only happens with ACCELERATED_2D_CANVAS turned on (which is off
+ by default). Many existing test cases will crash before and after this patch.
+
+ * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
+ (WebCore::SharedGraphicsContext3D::create):
+
+2010-10-05 Tony Chang <tony@chromium.org>
+
+ Reviewed by Kent Tamura.
+
+ [chromium] properly paint really small scrollbar arrows on linux
+ https://bugs.webkit.org/show_bug.cgi?id=47109
+
+ * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
+ (WebCore::ScrollbarThemeChromiumLinux::buttonSize): Clamp button size based on available size. This matches what
+ we do on Win.
+
+2010-10-05 Nate Chapin <japhet@chromium.org>
+
+ Reviewed by David Levin.
+
+ Remove unused CachedResource::Status values (New and NotCached).
+ https://bugs.webkit.org/show_bug.cgi?id=47132
+
+ Refactor only, no new tests.
+
+ * loader/CachedResource.h:
+ * loader/CachedResourceLoader.cpp:
+ (WebCore::CachedResourceLoader::checkCacheObjectStatus):
+
+2010-10-04 Jeremy Orlow <jorlow@chromium.org>
+
+ Reviewed by Nate Chapin.
+
+ Rename get* and open*Cursor per the spec on IDBIndex
+ https://bugs.webkit.org/show_bug.cgi?id=46906
+
+ The spec changed so that:
+ IDBIndex.get -> getKey
+ IDBIndex.getObject -> get
+ IDBIndex.openCursor -> openKeyCursor
+ IDBIndex.openObjectCursor -> openCursor
+
+ Existing tests cover since this is just renaming stuff.
+
+ * storage/IDBIndex.cpp:
+ (WebCore::IDBIndex::openCursor):
+ (WebCore::IDBIndex::openKeyCursor):
+ (WebCore::IDBIndex::get):
+ (WebCore::IDBIndex::getKey):
+ * storage/IDBIndex.h:
+ * storage/IDBIndex.idl:
+ * storage/IDBIndexBackendImpl.cpp:
+ (WebCore::IDBIndexBackendImpl::openCursor):
+ (WebCore::IDBIndexBackendImpl::openKeyCursor):
+ (WebCore::IDBIndexBackendImpl::get):
+ (WebCore::IDBIndexBackendImpl::getKey):
+ * storage/IDBIndexBackendImpl.h:
+ * storage/IDBIndexBackendInterface.h:
+
+2010-10-05 Keith Kyzivat <keith.kyzivat@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Fix breakage in RVCT 2.2 compile
+ https://bugs.webkit.org/show_bug.cgi?id=47187
+
+ Fix bug in RVCT 2.2 compile for Symbian^3 in html/canvas/Int32Array.h and
+ html/canvas/Uin8Array.h
+ For RVCT2.2, the using clause is unneeded, and can be omitted.
+
+ A Test case cannot be made for this since this is a build-related issue.
+
+ * html/canvas/Int32Array.h:
+ * html/canvas/Uint8Array.h:
+
+2010-10-04 Andrei Popescu <andreip@google.com>
+
+ Reviewed by Jeremy Orlow.
+
+ IDBDatabase::createObjectStore/removeObjectStore and IDBObjectStore::createIndex/removeIndex should be synchronous.
+ https://bugs.webkit.org/show_bug.cgi?id=46883
+
+ Makes the schema manipulation methods synchronous. Modifies the transaction
+ logic to support tasks that may have pending events as well as tasks that
+ don't have such events.
+
+ * storage/IDBDatabase.cpp:
+ (WebCore::IDBDatabase::createObjectStore):
+ (WebCore::IDBDatabase::removeObjectStore):
+ * storage/IDBDatabase.h:
+ * storage/IDBDatabase.idl:
+ * storage/IDBDatabaseBackendImpl.cpp:
+ (WebCore::IDBDatabaseBackendImpl::createObjectStore):
+ (WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
+ (WebCore::IDBDatabaseBackendImpl::removeObjectStore):
+ (WebCore::IDBDatabaseBackendImpl::removeObjectStoreInternal):
+ * storage/IDBDatabaseBackendImpl.h:
+ * storage/IDBDatabaseBackendInterface.h:
+ * storage/IDBIndexBackendImpl.cpp:
+ (WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
+ * storage/IDBIndexBackendImpl.h:
+ (WebCore::IDBIndexBackendImpl::create):
+ (WebCore::IDBIndexBackendImpl::id):
+ (WebCore::IDBIndexBackendImpl::setId):
+ * storage/IDBObjectStore.cpp:
+ (WebCore::IDBObjectStore::createIndex):
+ (WebCore::IDBObjectStore::removeIndex):
+ * storage/IDBObjectStore.h:
+ * storage/IDBObjectStore.idl:
+ * storage/IDBObjectStoreBackendImpl.cpp:
+ (WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
+ (WebCore::IDBObjectStoreBackendImpl::createIndex):
+ (WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
+ (WebCore::IDBObjectStoreBackendImpl::removeIndex):
+ (WebCore::IDBObjectStoreBackendImpl::removeIndexInternal):
+ * storage/IDBObjectStoreBackendImpl.h:
+ (WebCore::IDBObjectStoreBackendImpl::create):
+ (WebCore::IDBObjectStoreBackendImpl::id):
+ (WebCore::IDBObjectStoreBackendImpl::setId):
+ (WebCore::IDBObjectStoreBackendImpl::autoIncrement):
+ * storage/IDBObjectStoreBackendInterface.h:
+ * storage/IDBTransactionBackendImpl.cpp:
+ (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
+ (WebCore::IDBTransactionBackendImpl::objectStore):
+ (WebCore::IDBTransactionBackendImpl::scheduleTask):
+ (WebCore::IDBTransactionBackendImpl::abort):
+ (WebCore::IDBTransactionBackendImpl::didCompleteTaskEvents):
+ (WebCore::IDBTransactionBackendImpl::run):
+ (WebCore::IDBTransactionBackendImpl::taskTimerFired):
+ (WebCore::IDBTransactionBackendImpl::taskEventTimerFired):
+ * storage/IDBTransactionBackendImpl.h:
+
+2010-10-05 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Darin Adler.
+
+ WAI-ARIA 'marquee' role live region uses aria-live="polite", should use aria-live="off"
+ https://bugs.webkit.org/show_bug.cgi?id=47185
+
+ Test: platform/mac/accessibility/aria-liveregion-marquee-default.html
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::ariaLiveRegionStatus):
+
+2010-10-05 Martin Robinson <mrobinson@igalia.com>
+
+ Reviewed by Xan Lopez.
+
+ [GTK] Interior scrollbars do not draw their background properly
+ https://bugs.webkit.org/show_bug.cgi?id=47096
+
+ Correct the method that the GTK+ theme drawing code uses to
+ draw scrolled window backgrounds. Now it uses gtk_paint_shadow,
+ the same as the actual code from GTK+.
+
+ No new tests as this is very hard to write tests for. The bug only
+ manifests on some GTK+ themes and we have no test harness mechanism
+ for testing rendering with non-default GTK+ themes.
+
+ * platform/gtk/ScrollbarThemeGtk.cpp:
+ (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): No longer
+ initialize the widget state, as it's unused by the callee.
+ (WebCore::ScrollbarThemeGtk::paint): Remove an inaccurate comment.
+ * platform/gtk/gtk2drawing.c:
+ (moz_gtk_scrolled_window_paint): Paint scrolled window backgrounds
+ with gtk_paint_shadow instead of gtk_paint_box.
+
+2010-10-05 Kwang Yul Seo <skyul@company100.net>
+
+ Reviewed by Kent Tamura.
+
+ [BREWMP] Use PlatformRefPtr instead of OwnPtr in FileSystem
+ https://bugs.webkit.org/show_bug.cgi?id=47025
+
+ PlatformRefPtr is a better choice here because all Brew MP instances are
+ reference counted.
+
+ * platform/brew/FileSystemBrew.cpp:
+ (WebCore::getFileSize):
+ (WebCore::fileExists):
+ (WebCore::deleteFile):
+ (WebCore::deleteEmptyDirectory):
+ (WebCore::canonicalPath):
+ (WebCore::makeAllDirectories):
+ (WebCore::openTemporaryFile):
+
+2010-10-05 Martin Robinson <mrobinson@igalia.com>
+
+ Reviewed by Gustavo Noronha Silva.
+
+ [GTK] Complex text rendering does not render custom fonts
+ https://bugs.webkit.org/show_bug.cgi?id=41091
+
+ For fonts that do not have a FontConfig pattern (including custom
+ fonts), fall back to the simple text rendering path. This is a work-
+ -around for not supporting Pango rendering with non-FontConfig fonts.
+
+ Test: platform/gtk/fonts/font-face-with-complex-text.html
+
+ * platform/graphics/gtk/FontGtk.cpp:
+ (WebCore::Font::drawComplexText): Fall back to the simple path for custom fonts.
+ (WebCore::Font::floatWidthForComplexText): Ditto.
+ (WebCore::Font::offsetForPositionForComplexText): Ditto.
+ (WebCore::Font::selectionRectForComplexText): Ditto.
+
+2010-10-05 Kwang Yul Seo <skyul@company100.net>
+
+ Reviewed by Kent Tamura.
+
+ [BREWMP] Use PlatformRefPtr in getDisplayInfo
+ https://bugs.webkit.org/show_bug.cgi?id=47023
+
+ Use PlatformRefPtr to release IBitmap* automatically.
+
+ * platform/brew/ScreenBrew.cpp:
+ (WebCore::getDisplayInfo):
+
+2010-10-05 Kristian Monsen <kristianm@google.com>
+
+ Reviewed by Steve Block.
+
+ Including JavaScriptCore/config.h from WebCore/config.h
+ instead of from WebCorePrefix.h.
+ https://bugs.webkit.org/show_bug.cgi?id=47179
+
+ No new tests, just changing where files are included.
+
+ * WebCorePrefix.h:
+ * config.h:
+
+2010-10-05 Jakob Petsovits <jpetsovits@rim.com>
+
+ Reviewed by Andreas Kling.
+
+ [Qt] Make build work with QT_NO_CURSOR
+ https://bugs.webkit.org/show_bug.cgi?id=46097
+
+ Add a missing include.
+
+ * platform/qt/QWebPageClient.h:
+
+2010-10-05 Jakob Petsovits <jpetsovits@rim.com>
+
+ Reviewed by Andreas Kling.
+
+ [Qt] Make build work with QT_NO_CURSOR
+ https://bugs.webkit.org/show_bug.cgi?id=46097
+
+ createCustomCursor() is a static function and not used
+ in that file if QT_NO_CURSOR is defined, so rather than
+ making it return 0, it should not exist altogether.
+
+ * platform/qt/CursorQt.cpp:
+ (WebCore::createCustomCursor):
+
+2010-10-05 Adam Roben <aroben@apple.com>
+
+ Windows linker warning fix
+
+ * WebCore.vcproj/WebCore.vcproj: Exclude JSDOMTokenList.cpp from the
+ build, since it is already being compiled via DerivedSources.cpp. Also
+ let VS reorder some files.
+
+2010-10-05 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ [Qt] Web process crash when pressing modifiers in input field
+ https://bugs.webkit.org/show_bug.cgi?id=44935
+
+ Fix null pointer dereference by not using
+ PlatformKeyboardEvent::m_qtEvent. This member is not set when
+ event comes from WebKit2. Unix: Add ASSERTs to plugin related
+ code. These will fail if WebKit2 is used with plugins, unless code
+ is not fixed before. Symbian: Add ASSERT to code which uses
+ qtEvent(). It will fail when WebKit2 is enabled for Symbian, if
+ code is not fixed before.
+
+ * platform/PlatformKeyboardEvent.h:
+ * platform/qt/PlatformKeyboardEventQt.cpp:
+ (WebCore::isVirtualKeyCodeRepresentingCharacter): Added.
+ (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): Avoid using m_qtEvent.
+ (WebCore::PlatformKeyboardEvent::nativeModifiers): Added. Use ASSERT as a reminder.
+ (WebCore::PlatformKeyboardEvent::nativeScanCode): Added. Use ASSERT as a reminder.
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::setXKeyEventSpecificFields):
+ * plugins/symbian/PluginViewSymbian.cpp:
+ (WebCore::PluginView::handleKeyboardEvent): Add ASSERT as a reminder.
+
+2010-10-05 Kwang Yul Seo <skyul@company100.net>
+
+ Reviewed by Csaba Osztrogonác.
+
+ Add ENABLE(ACCELERATED_2D_CANVAS) guard to LoopBlinnLocalTriangulator.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=47115
+
+ LoopBlinnLocalTriangulator.cpp depends on LoopBlinnMathUtils.cpp which is guarded by
+ ENABLE(ACCELERATED_2D_CANVAS).
+
+ * platform/graphics/gpu/LoopBlinnLocalTriangulator.cpp:
+
+2010-10-05 Satish Sampath <satish@chromium.org>
+
+ Reviewed by Kent Tamura.
+
+ Added event onwebkitspeechchange to invoke on new speech input results.
+ https://bugs.webkit.org/show_bug.cgi?id=47127
+
+ * dom/EventNames.h: Added webkitspeechchange event name.
+ * html/HTMLAttributeNames.in: Added onwebkitspeechchange attribute name.
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::parseMappedAttribute): Handle new attribute set.
+ (WebCore::HTMLInputElement::dispatchWebkitSpeechChangeEvent): Invoke the event handler.
+ * html/HTMLInputElement.h:
+ * html/HTMLInputElement.idl: Added attribute to IDL.
+ * rendering/TextControlInnerElements.cpp:
+ (WebCore::InputFieldSpeechButtonElement::setRecognitionResult): Invoke new event handler instead of onChange
+
+2010-10-05 Satish Sampath <satish@chromium.org>
+
+ Reviewed by Jeremy Orlow.
+
+ Rename @webkitspeech to @x-webkit-speech to follow HTML5 convention
+ https://bugs.webkit.org/show_bug.cgi?id=46873
+
+ The @webkitspeech attribute is renamed to @x-webkit-speech per the HTML5 spec for extension
+ attributes. The DOM attribute in IDL was renamed to 'webkitSpeech' as well. But the generated
+ code for the attribute did not match the generated code for the IDL, so I modified
+ dom/make_names.pl to generate the appropriate name for such extension attributes.
+
+ * bindings/generic/RuntimeEnabledFeatures.h: Rename flag accessor to match IDL attribute name.
+ (WebCore::RuntimeEnabledFeatures::webkitSpeechEnabled):
+ * dom/make_names.pl: Additions to generate names for x-webkit-xxxx attributes that match the
+ generated code from IDL and remember the original names including the x- prefix when writing
+ out the cpp files.
+ * html/HTMLAttributeNames.in: Rename @webkitspeech to @x-webkit-speech
+ * html/HTMLInputElement.idl: Rename @webkitspeech to @webkitSpeech
+
+2010-10-04 Andrey Kosyakov <caseq@chromium.org>
+
+ Reviewed by Yury Semikhatsky.
+
+ Web Inspector: [Chromium][Extension API] provide tab id of inspected tab in extension API
+ https://bugs.webkit.org/show_bug.cgi?id=47080
+
+ * inspector/front-end/ExtensionServer.js: Added support for platform-specific extensions API.
+ (WebInspector.ExtensionServer.prototype._buildExtensionAPIInjectedScript):
+
+2010-10-05 Sanjeev Radhakrishnan <sanjeevr@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ Fixed implementation of pluginWidgetFromDocument to search for the "embed" element rather than just use the first child.
+ https://bugs.webkit.org/show_bug.cgi?id=47129
+
+ * html/PluginDocument.cpp:
+ (WebCore::PluginDocumentParser::pluginWidgetFromDocument):
+
+2010-10-05 Chris Rogers <crogers@google.com>
+
+ Reviewed by Kenneth Russell.
+
+ Add BiquadDSPKernel files
+ https://bugs.webkit.org/show_bug.cgi?id=46528
+
+ No new tests since audio API is not yet implemented.
+
+ * webaudio/BiquadDSPKernel.cpp: Added.
+ (WebCore::BiquadDSPKernel::process):
+ * webaudio/BiquadDSPKernel.h: Added.
+ (WebCore::BiquadDSPKernel::BiquadDSPKernel):
+ (WebCore::BiquadDSPKernel::reset):
+ (WebCore::BiquadDSPKernel::biquadProcessor):
+
+2010-10-05 Chris Rogers <crogers@google.com>
+
+ Reviewed by James Robinson.
+
+ Fix AudioContext to use new HRTFDatabaseLoader API
+ https://bugs.webkit.org/show_bug.cgi?id=46858
+
+ No new tests since audio API is not yet implemented.
+
+ * webaudio/AudioContext.cpp:
+ (WebCore::AudioContext::AudioContext):
+ (WebCore::AudioContext::isRunnable):
+ * webaudio/AudioContext.h:
+ * webaudio/AudioContext.idl:
+
+2010-10-05 Chris Rogers <crogers@google.com>
+
+ Reviewed by Kenneth Russell.
+
+ Add AudioPannerNode files
+ https://bugs.webkit.org/show_bug.cgi?id=46505
+
+ No new tests since audio API is not yet implemented.
+
+ * webaudio/AudioPannerNode.cpp: Added.
+ (WebCore::fixNANs):
+ (WebCore::AudioPannerNode::AudioPannerNode):
+ (WebCore::AudioPannerNode::~AudioPannerNode):
+ (WebCore::AudioPannerNode::pullInputs):
+ (WebCore::AudioPannerNode::process):
+ (WebCore::AudioPannerNode::reset):
+ (WebCore::AudioPannerNode::initialize):
+ (WebCore::AudioPannerNode::uninitialize):
+ (WebCore::AudioPannerNode::listener):
+ (WebCore::AudioPannerNode::setPanningModel):
+ (WebCore::AudioPannerNode::getAzimuthElevation):
+ (WebCore::AudioPannerNode::dopplerRate):
+ (WebCore::AudioPannerNode::distanceConeGain):
+ (WebCore::AudioPannerNode::notifyAudioSourcesConnectedToNode):
+ * webaudio/AudioPannerNode.h: Added.
+ (WebCore::AudioPannerNode::create):
+ (WebCore::AudioPannerNode::panningModel):
+ (WebCore::AudioPannerNode::position):
+ (WebCore::AudioPannerNode::setPosition):
+ (WebCore::AudioPannerNode::orientation):
+ (WebCore::AudioPannerNode::setOrientation):
+ (WebCore::AudioPannerNode::velocity):
+ (WebCore::AudioPannerNode::setVelocity):
+ (WebCore::AudioPannerNode::distanceModel):
+ (WebCore::AudioPannerNode::setDistanceModel):
+ (WebCore::AudioPannerNode::refDistance):
+ (WebCore::AudioPannerNode::setRefDistance):
+ (WebCore::AudioPannerNode::maxDistance):
+ (WebCore::AudioPannerNode::setMaxDistance):
+ (WebCore::AudioPannerNode::rolloffFactor):
+ (WebCore::AudioPannerNode::setRolloffFactor):
+ (WebCore::AudioPannerNode::coneInnerAngle):
+ (WebCore::AudioPannerNode::setConeInnerAngle):
+ (WebCore::AudioPannerNode::coneOuterAngle):
+ (WebCore::AudioPannerNode::setConeOuterAngle):
+ (WebCore::AudioPannerNode::coneOuterGain):
+ (WebCore::AudioPannerNode::setConeOuterGain):
+ (WebCore::AudioPannerNode::distanceGain):
+ (WebCore::AudioPannerNode::coneGain):
+ * webaudio/AudioPannerNode.idl: Added.
+
+2010-10-04 Alejandro G. Castro <alex@igalia.com>
+
+ Reviewed by Martin Robinson.
+
+ [Cairo] Port drawTiledShadow to the new ContextShadow
+ https://bugs.webkit.org/show_bug.cgi?id=45902
+
+ Ported the drawTiledShadow function to the ContextShadow, it
+ renders shadows for rects faster than the simple blurring using
+ tiling of a smaller rect. We will remove the old function in a
+ next patch when starting to use ContextShadows for cairo
+ rendering.
+
+ * platform/graphics/ContextShadow.h:
+ * platform/graphics/cairo/ContextShadowCairo.cpp:
+ (WebCore::ContextShadow::drawRectShadowWithoutTiling):
+ (WebCore::ContextShadow::drawRectShadow):
+
+2010-10-05 Chris Rogers <crogers@google.com>
+
+ Reviewed by Kenneth Russell.
+
+ Add BiquadProcessor files
+ https://bugs.webkit.org/show_bug.cgi?id=46527
+
+ No new tests since audio API is not yet implemented.
+
+ * webaudio/BiquadProcessor.cpp: Added.
+ (WebCore::BiquadProcessor::BiquadProcessor):
+ (WebCore::BiquadProcessor::~BiquadProcessor):
+ (WebCore::BiquadProcessor::createKernel):
+ (WebCore::BiquadProcessor::process):
+ * webaudio/BiquadProcessor.h: Added.
+ (WebCore::BiquadProcessor::filterCoefficientsDirty):
+ (WebCore::BiquadProcessor::parameter1):
+ (WebCore::BiquadProcessor::parameter2):
+ (WebCore::BiquadProcessor::parameter3):
+ (WebCore::BiquadProcessor::type):
+
+2010-10-05 Chris Rogers <crogers@google.com>
+
+ Reviewed by Kenneth Russell.
+
+ Add EqualPowerPanner files
+ https://bugs.webkit.org/show_bug.cgi?id=45077
+
+ No new tests since audio API is not yet implemented.
+
+ * platform/audio/EqualPowerPanner.cpp: Added.
+ (WebCore::EqualPowerPanner::EqualPowerPanner):
+ (WebCore::EqualPowerPanner::pan):
+ * platform/audio/EqualPowerPanner.h: Added.
+ (WebCore::EqualPowerPanner::reset):
+
+2010-10-05 Chris Rogers <crogers@google.com>
+
+ Reviewed by Kenneth Russell.
+
+ Add HighPass2FilterNode files
+ https://bugs.webkit.org/show_bug.cgi?id=46533
+
+ No new tests since audio API is not yet implemented.
+
+ * webaudio/HighPass2FilterNode.cpp: Added.
+ (WebCore::HighPass2FilterNode::HighPass2FilterNode):
+ * webaudio/HighPass2FilterNode.h: Added.
+ (WebCore::HighPass2FilterNode::create):
+ (WebCore::HighPass2FilterNode::cutoff):
+ (WebCore::HighPass2FilterNode::resonance):
+ (WebCore::HighPass2FilterNode::biquadProcessor):
+ * webaudio/HighPass2FilterNode.idl: Added.
+
+2010-10-05 Chris Rogers <crogers@google.com>
+
+ Reviewed by Kenneth Russell.
+
+ Add LowPass2FilterNode files
+ https://bugs.webkit.org/show_bug.cgi?id=46532
+
+ No new tests since audio API is not yet implemented.
+
+ * webaudio/LowPass2FilterNode.cpp: Added.
+ (WebCore::LowPass2FilterNode::LowPass2FilterNode):
+ * webaudio/LowPass2FilterNode.h: Added.
+ (WebCore::LowPass2FilterNode::create):
+ (WebCore::LowPass2FilterNode::cutoff):
+ (WebCore::LowPass2FilterNode::resonance):
+ (WebCore::LowPass2FilterNode::biquadProcessor):
+ * webaudio/LowPass2FilterNode.idl: Added.
+
+2010-10-04 Alejandro G. Castro <alex@igalia.com>
+
+ Reviewed by Kent Tamura.
+
+ Fixed compilation problem added in commit 69082. The interface of
+ the function has two parameters with the same name.
+
+ * rendering/RenderBlock.h:
+
+2010-10-04 Chris Rogers <crogers@google.com>
+
+ Reviewed by Kenneth Russell.
+
+ Add AudioUtilities files
+ https://bugs.webkit.org/show_bug.cgi?id=47011
+
+ No new tests since audio API is not yet implemented.
+
+ * platform/audio/AudioUtilities.cpp: Added.
+ (WebCore::AudioUtilities::decibelsToLinear):
+ (WebCore::AudioUtilities::linearToDecibels):
+ (WebCore::AudioUtilities::discreteTimeConstantForSampleRate):
+ * platform/audio/AudioUtilities.h: Added.
+
+2010-10-04 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=47112
+
+ Convert addOverhangingFloats and addIntrudingFloats to be block-flow-aware.
+
+ Also clean up how floats are placed to use a bit instead of the magic -1 value on top().
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::layoutBlock):
+ (WebCore::RenderBlock::layoutBlockChild):
+ (WebCore::RenderBlock::insertFloatingObject):
+ (WebCore::RenderBlock::removeFloatingObject):
+ (WebCore::RenderBlock::removeFloatingObjectsBelow):
+ (WebCore::RenderBlock::positionNewFloats):
+ (WebCore::RenderBlock::markLinesDirtyInBlockRange):
+ (WebCore::RenderBlock::clearFloats):
+ (WebCore::RenderBlock::addOverhangingFloats):
+ (WebCore::RenderBlock::addIntrudingFloats):
+ * rendering/RenderBlock.h:
+ (WebCore::RenderBlock::FloatingObject::FloatingObject):
+ (WebCore::RenderBlock::FloatingObject::isPlaced):
+ (WebCore::RenderBlock::FloatingObject::setIsPlaced):
+ * rendering/RenderBlockLineLayout.cpp:
+ (WebCore::RenderBlock::determineStartPosition):
+
+2010-10-04 Nico Weber <thakis@chromium.org>
+
+ Reviewed by Kenneth Russell.
+
+ Fix broken C++ in PODInterval and PODIntervalTree
+ https://bugs.webkit.org/show_bug.cgi?id=47063
+
+ See http://clang.llvm.org/compatibility.html#dep_lookup . Since
+ valueToString needs to work with non-class types, it needs to be
+ declared before it's used. And since it needs to handle many types, it
+ needs to be a template function, for which clients will need to
+ provide specializations for the types they care about. Partial template
+ specialization is only supported for structs, so wrap the function in
+ a struct, too.
+
+ * platform/graphics/gpu/PODInterval.h:
+ (WebCore::PODInterval::toString):
+ * platform/graphics/gpu/PODIntervalTree.h:
+ (WebCore::PODIntervalTree::checkInvariantsFromNode):
+ * platform/graphics/gpu/PODRedBlackTree.h:
+ (WebCore::PODRedBlackTree::dumpFromNode):
+
+2010-10-04 Yael Aharon <yael.aharon@nokia.com>
+
+ Reviewed by Antonio Gomes.
+
+ Spatial Navigation: Add support for <input type="radio">
+ https://bugs.webkit.org/show_bug.cgi?id=46993
+
+ When using Spatial Navigation, every radio button should be focusable and
+ users should be able to navigate from one button to the next without moving the selection.
+
+ Tests: fast/events/spatial-navigation/snav-radio-group.html
+ fast/events/spatial-navigation/snav-radio.html
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::isKeyboardFocusable):
+ Every radio button should be keyboard focusable, if using Spatial Navigation.
+ (WebCore::HTMLInputElement::defaultEventHandler):
+ Disable the algorithm for selecting the next radio button within a group, if using Spatial Navigation.
+
+2010-10-04 Renata Hodovan <reni@inf.u-szeged.hu>
+
+ Reviewed by Andreas Kling.
+
+ SVGFEGaussianBlurElement doesn't support dynamic invalidation, when attributes change.
+ https://bugs.webkit.org/show_bug.cgi?id=47074
+ The patch also implements the simple setStdDeviation method.
+
+ Tests: svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr.html
+ svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr.html
+ svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call.html
+ svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop.html
+
+ * svg/SVGFEGaussianBlurElement.cpp:
+ (WebCore::SVGFEGaussianBlurElement::setStdDeviation):
+ (WebCore::SVGFEGaussianBlurElement::svgAttributeChanged):
+ * svg/SVGFEGaussianBlurElement.h:
+
+2010-10-04 Patrick Gansterer <paroga@paroga.com>
+
+ Reviewed by Darin Adler.
+
+ Add Base64DecodePolicy option at base64Decode()
+ https://bugs.webkit.org/show_bug.cgi?id=41510
+
+ Add an option for ignoring characters in base64 data.
+ This is necessary for decoding data urls.
+
+ Also add an overload to decode WebCore::String directly.
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::atob):
+ * page/Page.cpp:
+ (WebCore::Page::userStyleSheetLocationChanged):
+ * platform/text/Base64.cpp:
+ (WebCore::base64Encode):
+ (WebCore::base64Decode):
+ (WebCore::base64DecodeInternal):
+ * platform/text/Base64.h:
+ (WebCore::):
+
+2010-10-04 Ryuan Choi <bunhere@gmail.com>
+
+ Unreviewed build fix.
+
+ [WML] Build fix for r68854
+ https://bugs.webkit.org/show_bug.cgi?id=47043
+
+ Include HTMLParserIdioms.h.
+
+ No features added, so no new tests.
+
+ * wml/WMLAElement.cpp:
+ * wml/WMLImageLoader.cpp:
+
+2010-10-04 Ryuan Choi <ryuan.choi@samsung.com>
+
+ Unreviewed build fix.
+
+ [CMAKE] Build fix for r68901
+ https://bugs.webkit.org/show_bug.cgi?id=47042
+
+ Move plugins/PluginPackage.cpp
+
+ No features added, so no new tests.
+
+ * CMakeLists.txt:
+
+2010-10-04 Eric Uhrhane <ericu@chromium.org>
+
+ Reviewed by David Levin.
+
+ Hook FileEntry::createWriter to DOMFileSystem::createWriter
+ https://bugs.webkit.org/show_bug.cgi?id=46908
+
+ No new tests--still waiting for the first complete implementation.
+
+ * fileapi/FileEntry.cpp:
+ (WebCore::FileEntry::createWriter):
+
+2010-10-04 Yael Aharon <yael.aharon@nokia.com>
+
+ Reviewed by Antonio Gomes.
+
+ Spatial Navigation: select element does not release focus with Spatial Navigation
+ https://bugs.webkit.org/show_bug.cgi?id=46896
+
+ When using Spatial Navigation, once a select element is focused, you cannot use arrow keys
+ to navigate out of the select element. That is because select element currently uses the
+ arrow keys to change the selected element.
+ Change the behavior of select element so it does not change selection, if Spatial Navigation
+ is on.
+
+ This patch is addressing the case where Spatial Navigation is used
+ in a mobile device, and the flag ENABLE_NO_LISTBOX_RENDERING is on.
+ In the future we can add support for the case where the flag is off, and
+ the user needs to traverse the select element inline.
+
+ Tests: fast/events/spatial-navigation/snav-multiple-select.html
+ fast/events/spatial-navigation/snav-single-select.html
+
+ * dom/SelectElement.cpp:
+ (WebCore::SelectElement::menuListDefaultEventHandler):
+
+2010-10-04 Sriram Neelakandan <sriram.neelakandan@gmail.com>
+
+ Reviewed by Andreas Kling.
+
+ [Qt] QNetworkReplyHandler forces buffered output for FormData with files
+ https://bugs.webkit.org/show_bug.cgi?id=46259
+
+ No new tests. Existing form submit tests should cover this change.
+
+ * platform/network/qt/QNetworkReplyHandler.cpp:
+ (WebCore::FormDataIODevice::FormDataIODevice):
+ (WebCore::FormDataIODevice::computeSize):
+ Add computeSize() for computing form device size
+ (WebCore::QNetworkReplyHandler::start):
+ Call computeSize(), fill Content-Length and prevent UploadData buffering
+ * platform/network/qt/QNetworkReplyHandler.h:
+ (WebCore::FormDataIODevice::getFormDataSize):
+
+2010-10-04 Chang Shu <chang.shu@nokia.com>
+
+ Reviewed by Antonio Gomes.
+
+ Fixed the typo that searches the wrong direction in the no-focus-node case.
+ As a result, after page is loaded, pressing key "arrowdown" will bring the
+ focus to the 1st element instead of the last element.
+ https://bugs.webkit.org/show_bug.cgi?id=46901
+
+ Test: fast/events/spatial-navigation/snav-1st-stop.html
+
+ * page/FocusController.cpp:
+ (WebCore::FocusController::advanceFocusDirectionally):
+
+2010-10-04 Simon Fraser <simon.fraser@apple.com>
+
+ No review.
+
+ Touch cf/SocketStreamHandle.h and add an #ifdef to qt/SocketStreamHandle.h
+ to fail at compile time if Mac includes that header.
+
+ * platform/network/cf/SocketStreamHandle.h:
+ * platform/network/qt/SocketStreamHandle.h:
+
+2010-10-04 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=47136
+ WebSocket tests are crashing
+
+ The Mac xcode project was finding qt/SocketStreamHandle.h because of
+ an inadvertent change in r68951. Thus the header and implementation didn't match,
+ and memory corruption ensued.
+
+ * WebCore.xcodeproj/project.pbxproj:
+
+2010-10-04 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by James Robinson.
+
+ Move SharedGraphicsContext3D from ChromeClient to Page
+ https://bugs.webkit.org/show_bug.cgi?id=47113
+
+ * html/canvas/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
+ * page/ChromeClient.h:
+ * page/Page.cpp:
+ (WebCore::Page::sharedGraphicsContext3D):
+ * page/Page.h:
+ * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
+ (WebCore::SharedGraphicsContext3D::create):
+ * platform/graphics/gpu/SharedGraphicsContext3D.h:
+
+2010-10-04 Jeremy Orlow <jorlow@chromium.org>
+
+ Reviewed by Nate Chapin.
+
+ Implement IndexedDB's oncomplete and ontimeout.
+ https://bugs.webkit.org/show_bug.cgi?id=47106
+
+ Add ontimeout and oncomplete to IDBTransaction and plumb
+ them. Test this behavior in the existing IDBTransaction-basics
+ test.
+
+ * WebCore.gypi:
+ * storage/IDBTransaction.cpp:
+ (WebCore::IDBTransaction::IDBTransaction):
+ (WebCore::IDBTransaction::mode):
+ (WebCore::IDBTransaction::objectStore):
+ (WebCore::IDBTransaction::abort):
+ (WebCore::IDBTransaction::onAbort):
+ (WebCore::IDBTransaction::onComplete):
+ (WebCore::IDBTransaction::onTimeout):
+ (WebCore::IDBTransaction::stop):
+ (WebCore::IDBTransaction::onAbortTimerFired):
+ (WebCore::IDBTransaction::onCompleteTimerFired):
+ (WebCore::IDBTransaction::onTimeoutTimerFired):
+ * storage/IDBTransaction.h:
+ * storage/IDBTransactionBackendImpl.cpp:
+ (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
+ (WebCore::IDBTransactionBackendImpl::commit):
+ * storage/IDBTransactionCallbacks.h:
+
+2010-10-04 Enrica Casucci <enrica@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Crash at WebCore::nextCandidate + 27
+ https://bugs.webkit.org/show_bug.cgi?id=47118
+ <rdar://problem/7282934>
+
+ When we canonicalize a Position to create a VisiblePosition, the position
+ is passed by reference. In canonicalPosition we call updateLayoutIgnorePendingStylesheets
+ that can produce a lot of side effects, including changing the selection.
+ This becomes a serious problem whne the position passed as reference is one of
+ the selection endpoints.
+
+ Test: editing/selection/focus-crash.html
+
+ * editing/VisiblePosition.cpp:
+ (WebCore::VisiblePosition::canonicalPosition):
+
+2010-10-04 Alexey Proskuryakov <ap@apple.com>
+
+ Reviewed by Adam Barth.
+
+ https://bugs.webkit.org/show_bug.cgi?id=37812
+ Assertion failure when appcache/fail-on-update.html is run twice in a row
+
+ Test: http/tests/appcache/fail-on-update-2.html
+
+ For some reason, I can't reproduce this assertion failure with ToT, but the fixes I made
+ previously are still good, and covered by the new test.
+
+ * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache):
+ Handle the case when the cache is already obsolete by the time cache selection occurs.
+
+ * loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::failedLoadingMainResource):
+ It's not true that loading from appcache always succeeds - it can be aborted.
+
+ * loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::store):
+ Calling ensureOriginRecord(group->origin()) can change lastInsertRowID!
+
+2010-10-04 Erik Arvidsson <arv@chromium.org>
+
+ Reviewed by James Robinson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=47122
+ Crash in classList when class attribute is empty.
+
+ Tests: fast/dom/HTMLElement/class-list.html
+
+ * html/DOMTokenList.cpp:
+ (WebCore::DOMTokenList::length):
+ (WebCore::DOMTokenList::containsInternal):
+ (WebCore::DOMTokenList::classNames):
+
+2010-10-04 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Use isHTMLSpace in more places, and optimize it
+ https://bugs.webkit.org/show_bug.cgi?id=47103
+
+ * css/CSSParser.cpp:
+ (WebCore::parseColorInt): Use isHTMLSpace instead of a separate isCSSWhitespace function.
+ (WebCore::parseAlphaValue): Ditto.
+ (WebCore::CSSParser::text): Ditto.
+
+ * dom/SpaceSplitString.h: Removed isClassWhitespace.
+
+ * dom/SpaceSplitString.cpp:
+ (WebCore::SpaceSplitStringData::createVector): Use isHTMLSpace instead of isClassWhitespace.
+ * dom/StyledElement.cpp:
+ (WebCore::StyledElement::classAttributeChanged): Ditto.
+ * html/DOMTokenList.cpp:
+ (WebCore::validateToken): Ditto.
+ (WebCore::DOMTokenList::removeInternal): Ditto.
+
+ * html/parser/HTMLParserIdioms.h: Added histogram data an changed so that non-spaces take
+ only a single branch and plain old spaces take only two branches.
+
+2010-10-04 Justin Schuh <jschuh@chromium.org>
+
+ Reviewed by James Robinson.
+
+ HTMLMediaElement delayed load should fire asynchronously
+ https://bugs.webkit.org/show_bug.cgi?id=45765
+
+ Test: media/remove-from-document-before-load.html
+
+ * dom/Document.cpp:
+ (WebCore::Document::Document):
+ (WebCore::Document::decrementLoadEventDelayCount):
+ (WebCore::Document::loadEventDelayTimerFired):
+ * dom/Document.h:
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::HTMLMediaElement):
+ (WebCore::HTMLMediaElement::asyncEventTimerFired):
+ (WebCore::HTMLMediaElement::setShouldDelayLoadEvent):
+ * html/HTMLMediaElement.h:
+
+2010-10-04 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ ResourceHandle's public/protected/private sections are fragmented
+ https://bugs.webkit.org/show_bug.cgi?id=47038
+
+ Minor cleanup.
+
+ * platform/network/ResourceHandle.h:
+
+2010-10-04 Alexey Proskuryakov <ap@apple.com>
+
+ Reviewed by Adam Barth.
+
+ https://bugs.webkit.org/show_bug.cgi?id=43506
+ <rdar://problem/8289284> foreign-iframe-main.html occasionally crashes (during the next test,
+ idempotent-update.html)
+
+ Application cache doesn't use ResourceLoader machinery (for better or worse), so we need to
+ abort update process explicitly.
+
+ Note that in principle, update could piggyback on any other existing frame - or even run
+ frameless - but currently, it's tied to the first frame that requested update.
+
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::stopLoading):
+ * loader/appcache/ApplicationCacheGroup.cpp:
+ (WebCore::ApplicationCacheGroup::stopLoadingInFrame):
+ * loader/appcache/ApplicationCacheGroup.h:
+ * loader/appcache/ApplicationCacheHost.cpp:
+ (WebCore::ApplicationCacheHost::~ApplicationCacheHost):
+ (WebCore::ApplicationCacheHost::stopLoadingInFrame):
+ * loader/appcache/ApplicationCacheHost.h:
+
+2010-10-04 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Rename RedirectScheduler to NavigationScheduler
+ https://bugs.webkit.org/show_bug.cgi?id=47037
+
+ This class schedules more than just redirects. In fact, it schedules
+ most kinds of navigations.
+
+ * Android.mk:
+ * CMakeLists.txt:
+ * GNUmakefile.am:
+ * WebCore.gypi:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/generic/BindingDOMWindow.h:
+ (WebCore::::createWindow):
+ (WebCore::::open):
+ * bindings/generic/BindingFrame.h:
+ (WebCore::::navigateIfAllowed):
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::setLocation):
+ (WebCore::createWindow):
+ (WebCore::JSDOMWindow::open):
+ * bindings/js/JSDocumentCustom.cpp:
+ (WebCore::JSDocument::setLocation):
+ * bindings/js/JSLocationCustom.cpp:
+ (WebCore::JSLocation::reload):
+ * bindings/v8/custom/V8LocationCustom.cpp:
+ (WebCore::V8Location::reloadCallback):
+ * dom/Document.cpp:
+ (WebCore::Document::implicitClose):
+ (WebCore::Document::processHttpEquiv):
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::setResourceTrackingEnabled):
+ (WebCore::InspectorController::reloadPage):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::setDefersLoading):
+ (WebCore::FrameLoader::submitForm):
+ (WebCore::FrameLoader::stopLoading):
+ (WebCore::FrameLoader::didOpenURL):
+ (WebCore::FrameLoader::didExplicitOpen):
+ (WebCore::FrameLoader::cancelAndClear):
+ (WebCore::FrameLoader::clear):
+ (WebCore::FrameLoader::receivedFirstData):
+ (WebCore::FrameLoader::checkCompleted):
+ (WebCore::FrameLoader::provisionalLoadStarted):
+ (WebCore::FrameLoader::completed):
+ (WebCore::FrameLoader::prepareForCachedPageRestore):
+ * loader/FrameLoader.h:
+ * loader/NavigationScheduler.cpp: Added.
+ (WebCore::ScheduledNavigation::ScheduledNavigation):
+ (WebCore::ScheduledNavigation::~ScheduledNavigation):
+ (WebCore::ScheduledNavigation::shouldStartTimer):
+ (WebCore::ScheduledNavigation::didStartTimer):
+ (WebCore::ScheduledNavigation::didStopTimer):
+ (WebCore::ScheduledNavigation::delay):
+ (WebCore::ScheduledNavigation::lockHistory):
+ (WebCore::ScheduledNavigation::lockBackForwardList):
+ (WebCore::ScheduledNavigation::wasDuringLoad):
+ (WebCore::ScheduledNavigation::isLocationChange):
+ (WebCore::ScheduledNavigation::wasUserGesture):
+ (WebCore::ScheduledURLNavigation::ScheduledURLNavigation):
+ (WebCore::ScheduledURLNavigation::fire):
+ (WebCore::ScheduledURLNavigation::didStartTimer):
+ (WebCore::ScheduledURLNavigation::didStopTimer):
+ (WebCore::ScheduledURLNavigation::url):
+ (WebCore::ScheduledURLNavigation::referrer):
+ (WebCore::ScheduledRedirect::ScheduledRedirect):
+ (WebCore::ScheduledRedirect::shouldStartTimer):
+ (WebCore::ScheduledLocationChange::ScheduledLocationChange):
+ (WebCore::ScheduledRefresh::ScheduledRefresh):
+ (WebCore::ScheduledRefresh::fire):
+ (WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation):
+ (WebCore::ScheduledHistoryNavigation::fire):
+ (WebCore::ScheduledFormSubmission::ScheduledFormSubmission):
+ (WebCore::ScheduledFormSubmission::fire):
+ (WebCore::ScheduledFormSubmission::didStartTimer):
+ (WebCore::ScheduledFormSubmission::didStopTimer):
+ (WebCore::NavigationScheduler::NavigationScheduler):
+ (WebCore::NavigationScheduler::~NavigationScheduler):
+ (WebCore::NavigationScheduler::redirectScheduledDuringLoad):
+ (WebCore::NavigationScheduler::locationChangePending):
+ (WebCore::NavigationScheduler::clear):
+ (WebCore::NavigationScheduler::scheduleRedirect):
+ (WebCore::NavigationScheduler::mustLockBackForwardList):
+ (WebCore::NavigationScheduler::scheduleLocationChange):
+ (WebCore::NavigationScheduler::scheduleFormSubmission):
+ (WebCore::NavigationScheduler::scheduleRefresh):
+ (WebCore::NavigationScheduler::scheduleHistoryNavigation):
+ (WebCore::NavigationScheduler::timerFired):
+ (WebCore::NavigationScheduler::schedule):
+ (WebCore::NavigationScheduler::startTimer):
+ (WebCore::NavigationScheduler::cancel):
+ * loader/NavigationScheduler.h: Added.
+ * loader/RedirectScheduler.cpp: Removed.
+ * loader/RedirectScheduler.h: Removed.
+ * loader/SubframeLoader.cpp:
+ (WebCore::SubframeLoader::loadOrRedirectSubframe):
+ * loader/appcache/ApplicationCacheGroup.cpp:
+ (WebCore::ApplicationCacheGroup::selectCache):
+ * page/Frame.cpp:
+ (WebCore::Frame::Frame):
+ * page/Frame.h:
+ (WebCore::Frame::navigationScheduler):
+ * page/History.cpp:
+ (WebCore::History::back):
+ (WebCore::History::forward):
+ (WebCore::History::go):
+ * page/XSSAuditor.cpp:
+ (WebCore::XSSAuditor::findInRequest):
+
+2010-10-04 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Sam Weinig.
+
+ Remove ENABLE_SANDBOX
+ https://bugs.webkit.org/show_bug.cgi?id=47032
+
+ I'm not sure there's a reason for this to be behind a compile flag
+ anymore.
+
+ * Configurations/FeatureDefines.xcconfig:
+ * GNUmakefile.am:
+ * features.pri:
+ * html/HTMLIFrameElement.cpp:
+ (WebCore::parseSandboxAttribute):
+ (WebCore::HTMLIFrameElement::parseMappedAttribute):
+
+2010-10-04 Huahui Wu <mediadependent@gmail.com>
+
+ Reviewed by Darin Adler.
+
+ Fix a compiler error for ANDROID introduced by bug 45221.
+ https://bugs.webkit.org/show_bug.cgi?id=47095
+
+ It's a small fix for a compiler error, so there is no new test.
+
+ * platform/android/PlatformTouchEventAndroid.cpp:
+ (WebCore::PlatformTouchEvent::PlatformTouchEvent):
+
+2010-10-04 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ AX: doAXRangeForLine does not work
+ https://bugs.webkit.org/show_bug.cgi?id=47101
+
+ Asking for NSAccessibilityRangeForLine was returning a null range for any line number > 0.
+ The code was using a SelectionController to extend to the next line. Rather than change the implementation
+ of that core functionality, it is cleaner to use endOfLine to find the end of the line.
+
+ Test: platform/mac/accessibility/range-for-line-textarea.html
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::doAXRangeForLine):
+
+2010-10-04 Brent Fulgham <bfulgham@webkit.org>
+
+ Unreviewed, build fix for r68951.
+
+ Add stub implementation for ProxyServer logic.
+
+ * WebCore.vcproj/WebCore.vcproj: Add new WinCairo file.
+ * WebCore/platform/network/curl/ProxyServerCurl.cpp: Added
+
+2010-10-04 Alexey Proskuryakov <ap@apple.com>
+
+ Reviewed by Adam Barth.
+
+ https://bugs.webkit.org/show_bug.cgi?id=47035
+ Application cache selection algorithm should only be invoked after navigation
+
+ Tests: http/tests/appcache/document-write-html-element-2.html
+ http/tests/appcache/document-write-html-element.html
+ http/tests/appcache/insert-html-element-with-manifest-2.html
+ http/tests/appcache/insert-html-element-with-manifest.html
+
+ * dom/DocumentParser.cpp: (WebCore::DocumentParser::DocumentParser):
+ * dom/DocumentParser.h:
+ (WebCore::DocumentParser::setDocumentWasLoadedAsPartOfNavigation):
+ (WebCore::DocumentParser::documentWasLoadedAsPartOfNavigation):
+ Track whether the document being parsed is being loaded as part of navigation.
+
+ * html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::insertedByParser): Only run the
+ cache selection algorithm if the document is being loaded as part of navigation. We don't
+ want to switch associated appcache is someone document.writes <html manifest=...>.
+
+ * html/HTMLHtmlElement.h: We need to differentiate between parsing and DOM manipulation, so
+ this code can't be in HTMLHtmlElement::insertedIntoDocument().
+
+ * dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::startElementNs):
+ * dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parseStartElement):
+ * html/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure):
+ * html/MediaDocument.cpp: (WebCore::MediaDocumentParser::createDocumentStructure):
+ * html/PluginDocument.cpp: (WebCore::PluginDocumentParser::createDocumentStructure):
+ * html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
+ Check for manifest attribute in cases specified by HTML5.
+
+ * html/parser/HTMLConstructionSite.h: Removed unused insertHTMLHtmlElement().
+
+ * loader/DocumentWriter.cpp: (WebCore::DocumentWriter::setDocumentWasLoadedAsPartOfNavigation):
+ * loader/DocumentWriter.h:
+ Forward this call to DocumentParser, since DocumentWriter is supposed to encapsulate it.
+
+ * loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedFirstData): Receiving data from
+ loader means being loaded as part of navigation. This notion is used in HTML5 without a rigorous
+ definition that I could find - this seems to be a meaningful formalization.
+
+2010-10-04 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=47100
+
+ Convert clearFloats() to be block-flow-aware. Helpers that it calls have not been patched though.
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::clearFloats):
+ * rendering/RenderBlock.h:
+ (WebCore::RenderBlock::logicalTopForFloat):
+ (WebCore::RenderBlock::logicalLeftForFloat):
+ (WebCore::RenderBlock::logicalWidthForFloat):
+
+2010-10-04 Diego Gonzalez <diegohcg@webkit.org>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ [Qt] Hook up DeviceOrientation data for Qt support
+ https://bugs.webkit.org/show_bug.cgi?id=47052
+
+ Get DeviceOrientation necessary data via Qt mobility library
+ using a provider class.
+
+ * WebCore.pro:
+
+2010-10-01 Victoria Kirst <vrk@google.com>
+
+ Reviewed by James Robinson.
+
+ Fixing crash when audio media player is destructed
+ https://bugs.webkit.org/show_bug.cgi?id=47020
+
+ Adds assert for LayerRenderer in destructor.
+
+ * platform/graphics/chromium/VideoLayerChromium.cpp:
+ (WebCore::VideoLayerChromium::~VideoLayerChromium):
+
+2010-10-04 Pavel Podivilov <podivilov@chromium.org>
+
+ Reviewed by Pavel Feldman.
+
+ Web Inspector: do not show breakpoint in front-end if it was not set in v8
+ https://bugs.webkit.org/show_bug.cgi?id=46749
+
+ * bindings/v8/DebuggerScript.js:
+ ():
+
+2010-10-04 Alejandro G. Castro <alex@igalia.com>
+
+ Reviewed by Martin Robinson.
+
+ [cairo] Context shadow modifies the data of the surface without
+ flushing and marking as dirty
+ https://bugs.webkit.org/show_bug.cgi?id=47079
+
+ Added the cairo_surface_flush and cairo_surface_mark_dirty before
+ and after modifying the image pixels directly.
+
+ * platform/graphics/cairo/ContextShadowCairo.cpp:
+ (WebCore::ContextShadow::endShadowLayer):
+
+2010-10-04 Alejandro G. Castro <alex@igalia.com>
+
+ Reviewed by Xan Lopez.
+
+ Crashed caused by missing OwnPtrCairo include, for more
+ information check the issue in the bug 46268.
+
+ * platform/graphics/cairo/CairoUtilities.cpp:
+
+2010-10-04 Alejandro G. Castro <alex@igalia.com>
+
+ Reviewed by Martin Robinson.
+
+ [cairo] Move some cairo functions to the CairoUtilities
+ https://bugs.webkit.org/show_bug.cgi?id=47076
+
+ Moved some cairo functions to the CairoUtilities so we can use
+ them outside GraphicsContextCairo.
+
+ * platform/graphics/cairo/CairoUtilities.cpp:
+ (WebCore::appendPathToCairoContext):
+ (WebCore::setPathOnCairoContext):
+ (WebCore::appendWebCorePathToCairoContext):
+ (WebCore::toCairoOperator):
+ (WebCore::drawPatternToCairoContext):
+ * platform/graphics/cairo/CairoUtilities.h:
+ * platform/graphics/cairo/GraphicsContextCairo.cpp:
+ * platform/graphics/cairo/ImageCairo.cpp:
+ (WebCore::Image::drawPattern):
+
+2010-10-04 podivilov@chromium.org <podivilov@chromium.org>
+
+ Reviewed by Yury Semikhatsky.
+
+ Web Inspector: implement pausing on event listeners (back-end part)
+ https://bugs.webkit.org/show_bug.cgi?id=46624
+
+ * bindings/js/ScriptDebugServer.cpp:
+ (WebCore::ScriptDebugServer::setPauseOnNextStatement):
+ * bindings/js/ScriptDebugServer.h:
+ * bindings/v8/ScriptDebugServer.cpp:
+ (WebCore::ScriptDebugServer::setPauseOnNextStatement):
+ * bindings/v8/ScriptDebugServer.h:
+ * dom/Node.cpp:
+ (WebCore::Node::dispatchGenericEvent):
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::didCommitLoad):
+ (WebCore::InspectorController::setNativeBreakpoint):
+ (WebCore::InspectorController::removeNativeBreakpoint):
+ (WebCore::InspectorController::shouldBreakOnEvent):
+ (WebCore::InspectorController::shouldBreakOnXMLHttpRequest):
+ * inspector/InspectorController.h:
+ * inspector/InspectorDebuggerAgent.cpp:
+ (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
+ (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
+ (WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement):
+ (WebCore::InspectorDebuggerAgent::pause):
+ (WebCore::InspectorDebuggerAgent::didContinue):
+ (WebCore::InspectorDebuggerAgent::breakProgram):
+ * inspector/InspectorDebuggerAgent.h:
+ * inspector/InspectorInstrumentation.cpp:
+ (WebCore::eventHasListeners):
+ (WebCore::InspectorInstrumentation::instrumentWillDispatchEventImpl):
+ (WebCore::InspectorInstrumentation::instrumentDidDispatchEventImpl):
+ (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequestImpl):
+ * inspector/InspectorInstrumentation.h:
+ (WebCore::InspectorInstrumentation::instrumentWillDispatchEvent):
+ (WebCore::InspectorInstrumentation::instrumentDidDispatchEvent):
+ (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequest):
+ * inspector/InspectorTimelineAgent.cpp:
+ (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
+ * inspector/InspectorTimelineAgent.h:
+ (WebCore::InspectorTimelineAgent::id):
+ * inspector/front-end/CallStackSidebarPane.js:
+
+2010-10-04 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Yury Semikhatsky.
+
+ Web Inspector: add total bar to the network panel.
+ https://bugs.webkit.org/show_bug.cgi?id=47081
+
+ * English.lproj/localizedStrings.js:
+ * inspector/front-end/ConsoleView.js:
+ (WebInspector.ConsoleView.createDividerElement):
+ * inspector/front-end/DataGrid.js:
+ (WebInspector.DataGrid.prototype.removeChild):
+ (WebInspector.DataGrid.prototype.sortNodes):
+ (WebInspector.DataGrid.prototype._clickInHeaderCell):
+ (WebInspector.DataGrid.prototype.markColumnAsSortedBy):
+ * inspector/front-end/NetworkPanel.js:
+ (WebInspector.NetworkPanel):
+ (WebInspector.NetworkPanel.prototype.resize):
+ (WebInspector.NetworkPanel.prototype._positionSummaryBar):
+ (WebInspector.NetworkPanel.prototype._createTimelineGrid):
+ (WebInspector.NetworkPanel.prototype._createSortingFunctions):
+ (WebInspector.NetworkPanel.prototype._sortItems):
+ (WebInspector.NetworkPanel.prototype._sortByTimeline):
+ (WebInspector.NetworkPanel.prototype._createFilterStatusBarItems):
+ (WebInspector.NetworkPanel.prototype._createSummaryBar):
+ (WebInspector.NetworkPanel.prototype._updateSummaryBar):
+ (WebInspector.NetworkPanel.prototype._updateFilter):
+ (WebInspector.NetworkPanel.prototype.show):
+ (WebInspector.NetworkPanel.prototype.refresh):
+ (WebInspector.NetworkPanel.prototype.reset):
+ (WebInspector.NetworkDataGridNode.SizeComparator):
+ (WebInspector.NetworkDataGridNode.ResourcePropertyComparator):
+ (WebInspector.NetworkTotalGridNode):
+ (WebInspector.NetworkTotalGridNode.prototype.createCells):
+ * inspector/front-end/ResourcesPanel.js:
+ (WebInspector.ResourcesPanel.prototype.createFilterPanel):
+ * inspector/front-end/inspector.css:
+ (.scope-bar-divider):
+ * inspector/front-end/networkPanel.css:
+ (.network-timeline-grid):
+ (.network-summary-bar):
+ (.network-summary-bar-bottom):
+ (.data-grid td .network-summary-bar):
+
+2010-09-28 Luiz Agostini <luiz.agostini@openbossa.org>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Viewport data change notifications
+ https://bugs.webkit.org/show_bug.cgi?id=46755
+
+ Regarding viewport meta tags, what matters for browser developers is to know when the viewport data has
+ changed and its current value. Viewport data belongs to the document, but it is useful to keep the current
+ viewport data in Page as a reference, to be able to send notifications only when the current viewport
+ has changed.
+
+ * dom/Document.cpp:
+ (WebCore::Document::processViewport):
+ (WebCore::Document::setInPageCache):
+ * dom/ViewportArguments.h:
+ (WebCore::ViewportArguments::operator==):
+ * html/HTMLBodyElement.cpp:
+ (WebCore::HTMLBodyElement::HTMLBodyElement):
+ * page/Chrome.cpp:
+ (WebCore::Chrome::viewportDataChanged):
+ * page/Chrome.h:
+ * page/ChromeClient.h:
+ (WebCore::ChromeClient::viewportDataChanged):
+ * page/Page.cpp:
+ (WebCore::Page::updateViewportArguments):
+ * page/Page.h:
+ (WebCore::Page::viewportArguments):
+
+2010-10-03 Kent Tamura <tkent@chromium.org>
+
+ Unreviewed, build fix for r68996.
+
+ * html/BaseDateAndTimeInputType.cpp: Includes <wtf/MathExtras.h> for isfinite().
+ * html/MonthInputType.cpp: ditto.
+ * html/NumberInputType.cpp: ditto.
+ * html/RangeInputType.cpp: ditto.
+
+2010-10-03 Kent Tamura <tkent@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ Refactor HTMLInputElement: Move parseToDouble() and
+ parseToDateComponents() to InputType.
+ https://bugs.webkit.org/show_bug.cgi?id=46965
+
+ Introduce BaseDateAndTimeInputType, which is a super class of
+ date, datetime, datetime-local, month, time, and week types.
+
+ No new tests. Just a refactoring.
+
+ * Android.mk: Add BaseDateAndTimeInputType.
+ * CMakeLists.txt: ditto.
+ * GNUmakefile.am: ditto.
+ * WebCore.gypi: ditto.
+ * WebCore.pro: ditto.
+ * WebCore.vcproj/WebCore.vcproj: ditto.
+ * WebCore.xcodeproj/project.pbxproj: ditto.
+ * html/BaseDateAndTimeInputType.cpp: Added.
+ (WebCore::BaseDateAndTimeInputType::parseToDouble):
+ (WebCore::BaseDateAndTimeInputType::parseToDateComponents):
+ * html/BaseDateAndTimeInputType.h: Added.
+ (WebCore::BaseDateAndTimeInputType::BaseDateAndTimeInputType):
+ * html/DateInputType.cpp:
+ (WebCore::DateInputType::parseToDateComponentsInternal):
+ * html/DateInputType.h:
+ (WebCore::DateInputType::DateInputType):
+ * html/DateTimeInputType.cpp:
+ (WebCore::DateTimeInputType::parseToDateComponentsInternal):
+ * html/DateTimeInputType.h:
+ (WebCore::DateTimeInputType::DateTimeInputType):
+ * html/DateTimeLocalInputType.cpp:
+ (WebCore::DateTimeLocalInputType::parseToDateComponentsInternal):
+ * html/DateTimeLocalInputType.h:
+ (WebCore::DateTimeLocalInputType::DateTimeLocalInputType):
+ * html/HTMLInputElement.cpp: Replace parseToD* calls with m_inputType->parseToD*.
+ (WebCore::HTMLInputElement::typeMismatch):
+ (WebCore::HTMLInputElement::rangeUnderflow):
+ (WebCore::HTMLInputElement::rangeOverflow):
+ (WebCore::HTMLInputElement::minimum):
+ (WebCore::HTMLInputElement::maximum):
+ (WebCore::HTMLInputElement::stepBase):
+ (WebCore::HTMLInputElement::stepMismatch):
+ (WebCore::HTMLInputElement::applyStep):
+ (WebCore::HTMLInputElement::valueAsDate):
+ (WebCore::HTMLInputElement::valueAsNumber):
+ (WebCore::HTMLInputElement::handleKeyEventForRange):
+ (WebCore::HTMLInputElement::stepUpFromRenderer):
+ * html/HTMLInputElement.h:
+ * html/InputType.cpp:
+ (WebCore::InputType::parseToDouble):
+ (WebCore::InputType::parseToDateComponents):
+ * html/InputType.h:
+ * html/MonthInputType.cpp:
+ (WebCore::MonthInputType::parseToDouble):
+ (WebCore::MonthInputType::parseToDateComponentsInternal):
+ * html/MonthInputType.h:
+ (WebCore::MonthInputType::MonthInputType):
+ * html/NumberInputType.cpp:
+ (WebCore::NumberInputType::parseToDouble):
+ * html/NumberInputType.h:
+ * html/RangeInputType.cpp:
+ (WebCore::RangeInputType::parseToDouble):
+ * html/RangeInputType.h:
+ * html/TimeInputType.cpp:
+ (WebCore::TimeInputType::parseToDateComponentsInternal):
+ * html/TimeInputType.h:
+ (WebCore::TimeInputType::TimeInputType):
+ * html/WeekInputType.cpp:
+ (WebCore::WeekInputType::parseToDateComponentsInternal):
+ * html/WeekInputType.h:
+ (WebCore::WeekInputType::WeekInputType):
+
+2010-10-03 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Holger Freyther.
+
+ ASSERT(m_state = Open); is bad news bears
+ https://bugs.webkit.org/show_bug.cgi?id=47057
+
+ Added by ap (review by darin) in http://trac.webkit.org/changeset/50951
+ Too bad the compiler doesn't catch these errors. I don't believe this
+ is possible to test.
+
+ * platform/network/cf/SocketStreamHandleCFNet.cpp:
+ (WebCore::SocketStreamHandle::writeStreamCallback):
+
+2010-10-03 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Holger Freyther.
+
+ All the WebSocket tests crash
+ https://bugs.webkit.org/show_bug.cgi?id=47056
+
+ More code that tries to hold onto temporaries with references.
+
+ * websockets/WebSocketChannel.cpp:
+ (WebCore::WebSocketChannel::didOpen):
+
+2010-10-03 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Holger Freyther.
+
+ All the WebSocket tests crash
+ https://bugs.webkit.org/show_bug.cgi?id=47055
+
+ This code attempts to hold onto temporary objects using references.
+ That doesn't work in C++. Instead, we need to actually store the
+ objects somewhere.
+
+ * bindings/js/JSWebSocketCustom.cpp:
+ (WebCore::JSWebSocketConstructor::constructJSWebSocket):
+
+2010-10-02 Diego Gonzalez <diegohcg@webkit.org>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ [Qt] Provide Qt support for DeviceMotion/Orientation clients
+ https://bugs.webkit.org/show_bug.cgi?id=47051
+
+ Add Qt DeviceMotion/Orientation dummy clients in build system.
+
+ * WebCore.pro:
+
+2010-10-01 Nikolas Zimmermann <nzimmermann@rim.com>
+
+ Reviewed by Dirk Schulze.
+
+ Rewrite SVG text layout code
+ https://bugs.webkit.org/show_bug.cgi?id=45532
+
+ Modernize SVG text layout engine, split the layout process into three phases, so that each results can be cached (which will be done in a follow-up patch).
+
+ Phase #1) - SVGTextLayoutAttributesBuilder
+ ------------------------------------------
+
+ Parse x/y/dx/dy/rotate values of the <text> subtree (<text x="30 40">A<tspan>B<tspan x="50">C</tspan></tspan></text>)
+ This is done by SVGTextLayoutAttributesBuilder. It builds a SVGTextLayoutAttributes object for each RenderSVGInlineText renderer, and stores it there.
+ Phase #1 is started from RenderSVGText::layout(), before RenderBlockLineLayout is laying out the inline children, and thus before the InlineBox tree is created.
+
+ Now we know which character has an associated absolute x or y position, denoting the start of a new text chunk. Whenever we encounter a new text chunk
+ RenderBlockLineLayout should create a new SVGInlineTextBox. This is very important, as BiDi reordering shouldn't happen across text chunks, as well as ligature detection.
+
+ The text chunk concept is now merged right into the InlineBox tree, so we don't need to hack around the lack of that, as done for the previous years.
+
+ Phase #2) - SVGTextLayoutEngine
+ ------------------------------------------
+
+ RenderSVGText::layout() calls RenderBlock::layoutInlineChildren() right after phase #1 ends. The InlineBox tree is created. During that process findNextLineBreak()
+ decides how to split up the text into InlineTextBoxes. It has already been patched, to ask RenderSVGInlineText::characterStartsNewTextChunk(int position), whether the
+ current character should go in a new SVGInlineTextBox or not. This requires that phase #1 already stored these information in the RenderSVGInlineText objects.
+
+ For each <text> object a SVGRootInlineBox is created (in constructLine()) and all child boxes are added. After that SVGRootInlineBox::computePerCharacterLayoutInformation()
+ is called (unlike HTML text, which splits the vertical & horizontal layout in two phases, it's just one single phase for SVG). This function invokes SVGTextLayoutEngine
+ and starts phase #2 of the layout process.
+
+ SVGTextLayoutEngine lays out the content of each SVGInlineTextBox either on a line or a path. It contains all the logic handling, alignment-baseline, dominant-baseline,
+ letter-spacing, word-spacing, kerning, glyph-orientation-(horizontal|vertical), rotation, etc. etc.
+
+ As result it generates a set of SVGTextFragment objects which are stored in each SVGInlineTextBox. Each SVGTextFragment is a portion of text that can be rendered/measured
+ at once. Some examples to illustrate what's going on:
+
+ <text x="20">ABCD</text>:
+ - SVGInlineTextBox
+ - SVGTextFragment, start 0 length 4, "ABCD" (x=20)
+
+ <text x="20 100">ABCD</text>:
+ - SVGInlineTextBox
+ - SVGTextFragment, start 0 length 1, "A" (x=20)
+ - SVGInlineTextBox
+ - SVGTextFragment, start 0 length 1, "B" (x=100)
+ - SVGTextFragment, start 1 length 2, "CD" (x=100 + advance_of_last)
+
+ <text><textPath xlink:href="#somePath">ABCD</textPath></text>:
+ - SVGInlineTextBox
+ - SVGTextFragment, start 0 length 1, "A" (rotated!)
+ - SVGTextFragment, start 1 length 1, "B" (rotated!)
+ - SVGTextFragment, start 2 length 1, "C" (rotated!)
+ - SVGTextFragment, start 3 length 1, "D" (rotated!)
+
+ <text x="0 50 100">A<tspan>B</tspan>C</text>
+ - SVGInlineTextBox
+ - SVGTextFragment, start 0 length 1, "A" (x=0)
+ - SVGInlineFlowBox
+ - SVGInlineTextBox
+ - SVGTextFragment, start 0 length 1, "B" (x=50)
+ - SVGInlineTextBox
+ - SVGTextFragment, start 0 length 1, "C" (x=100)
+
+ When painting text SVGInlineTextBox just walks its fragments and paints them. Text selection works the same.
+ All text measurements (width/height etc.) have already been done in phase #2 and aren't required anymore while painting/selecting.
+ This is one of the main benefits of the new text layout engine, painting & selection is cheap now, compared to the layout process.
+
+ We're now doing phase #1 everytime RenderSVGText::layout() is called. This is not necessary, we only have to recompute these information
+ if the x/y/dx/dy or rotate list of an element in the <text> subtree changes or the text content itself -> this will be done in a follow-up patch.
+ It's likely that we'll also find ways to skip phase #2 in certain situations.
+
+ Phase #3) - SVGTextChunkBuilder
+ ------------------------------------------
+
+ After phase #2 finished, we can post-process the text fragments. Certain operations have to be applied on a "per chunk" basis.
+ text-anchor should be applied to individual text chunks, as well as textLength corrections (lengthAdjust="spacing" / lengthAdjust="spacingAndGlyphs").
+
+ SVGTextChunkBuilder just walks the SVGInlineTextBox, and collects all boxes belonging to a certain chunk. For each of the chunks all fragments
+ are post-processed. For instance for text-anchor="middle", all x positions of all fragments are shifted by -fragmentWidth/2 (for horizonal text).
+
+ After phase #1 - #3 finished, SVGRootInlineBox::computePerCharacterLayoutInformation() utilizies the stored SVGTextFragments to lay out all child
+ boxes in the InlineBox tree (setWidth/Height, etc.), the size and position of the SVGRootInlineBox and it's parent RenderSVGText object.
+
+ This should give interessted readers a good summary of how the new text layout engine works.
+ See LayoutTests/ChangeLog for more details on test progression.
+
+ Tests: svg/custom/text-rotation.svg
+ svg/custom/text-x-dy-lists.svg
+
+ * Android.mk: Add SVGTextLayoutEngine.* / SVGTextChunkBuilder.* to build. Remove SVGCharacterData.* / SVGTextChunkLayoutInfo.* / SVGTextLayoutUtilities.* from build.
+ * CMakeLists.txt: Ditto.
+ * GNUmakefile.am: Ditto.
+ * WebCore.gypi: Ditto.
+ * WebCore.pro: Ditto.
+ * WebCore.vcproj/WebCore.vcproj: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+ * rendering/InlineBox.h:
+ (WebCore::InlineBox::isSVGInlineFlowBox): Add helper function to identify SVGInlineFlowBoxes. The variants for SVGInlineTextBox etc. already exist.
+ * rendering/InlineTextBox.h: Devirtualize selectionStartEnd, SVG is no longer overriding it.
+ * rendering/RenderSVGAllInOne.cpp: removes
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::setTextInternal): Remove SVG specific hacks, moved to RenderSVGInlineText.
+ * rendering/SVGCharacterData.cpp: Removed.
+ * rendering/SVGCharacterData.h: Removed.
+ * rendering/SVGCharacterLayoutInfo.cpp: Removed.
+ * rendering/SVGCharacterLayoutInfo.h: Removed.
+ * rendering/SVGRenderTreeAsText.cpp: Hack DRT output to be somewhat compatible with the current output, the plan is to change it completly after this patch.
+ (WebCore::writeRenderSVGTextBox):
+ (WebCore::writeSVGInlineTextBox):
+ * rendering/SVGTextChunkLayoutInfo.cpp: Removed.
+ * rendering/SVGTextChunkLayoutInfo.h: Removed.
+ * rendering/SVGTextLayoutUtilities.cpp: Removed.
+ * rendering/SVGTextLayoutUtilities.h: Removed.
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::diff): Only return immediately if SVGRenderStyle::diff produced StyleDifferenceLayout, it it's sth. else be sure to ask RenderStyle itself what to do.
+ * rendering/style/SVGRenderStyle.h:
+ (WebCore::SVGRenderStyle::isVerticalWritingMode): New helper method, moved from SVGTextLayoutUtilities.
+ * rendering/svg/RenderSVGInlineText.cpp:
+ (WebCore::applySVGWhitespaceRules): Moved from RenderText into a SVG specific place.
+ (WebCore::RenderSVGInlineText::RenderSVGInlineText): Use applySVGWhitespaceRules on the incoming text.
+ (WebCore::RenderSVGInlineText::styleDidChange): Only apply SVG white space rules, when using xml:space="preserve", otherwhise the constructor already handled it.
+ (WebCore::RenderSVGInlineText::characterStartsNewTextChunk): Create text chunks for absolute y values as well, SVG 1.1 2nd Edition demands that.
+ (WebCore::RenderSVGInlineText::positionForPoint): New function operating on all SVGInlineTextBoxes and their SVGTextFragments.
+ * rendering/svg/RenderSVGInlineText.h:
+ (WebCore::RenderSVGInlineText::layoutAttributes): Stores the layout attributes generated by SVGTextLayoutAttributesBuilder.
+ (WebCore::toRenderSVGInlineText): New helper methods for casting.
+ * rendering/svg/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::layout): Add comment, that SVGTextLayoutAttributesBuilder is just phase one of the layout process.
+ (WebCore::RenderSVGText::positionForPoint): Simplified implementation for SVGs needs.
+ * rendering/svg/RenderSVGText.h:
+ * rendering/svg/SVGInlineFlowBox.cpp:
+ (WebCore::SVGInlineFlowBox::paintSelectionBackground): Seperated selection background drawing from actual text rendering, to make sure selection is always in background for SVG.
+ (WebCore::SVGInlineFlowBox::paint): Call computetextMatchMarkerRectForRenderer, before painting.
+ (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer): New method.
+ * rendering/svg/SVGInlineFlowBox.h:
+ (WebCore::SVGInlineFlowBox::isSVGInlineFlowBox):
+ * rendering/svg/SVGInlineTextBox.cpp: Completly rewritten, operates on SVGTextFragments, produced by the SVGTextLayoutEngine. Whole new concept, compared to the old hack.
+ * rendering/svg/SVGInlineTextBox.h:
+ (WebCore::SVGInlineTextBox::clearTextFragments): Only used by SVGTextLayoutEngine, to clean up previously computed fragments.
+ (WebCore::SVGInlineTextBox::textFragments): Offers access to the fragments in the box.
+ (WebCore::SVGInlineTextBox::startsNewTextChunk): Does this box start a new text chunk?
+ (WebCore::SVGInlineTextBox::setStartsNewTextChunk): SVGTextLayoutEngine marks this box, if it starts a new text chunk.
+ * rendering/svg/SVGRootInlineBox.cpp: Remove old code regarding text chunk parts.
+ (WebCore::SVGRootInlineBox::paint): Selection is now painted before text, to assure it's really in the background.
+ (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): Use new SVGTextLayoutEngine.
+ (WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes): Feed SVGTextLayoutEngine with SVGInlineTextBoxes, detect the begin/end of path layouts.
+ (WebCore::SVGRootInlineBox::layoutChildBoxes): Use new isSVGInlineTextBox() helper method.
+ (WebCore::SVGRootInlineBox::closestLeafChildForPosition): Simplified version for SVG.
+ * rendering/svg/SVGRootInlineBox.h: Remove access to text chunks, they're now longer stored in the SVGRootInlineBox.
+ * rendering/svg/SVGTextChunk.cpp: s/SVGTextChunkNew/SVGTextChunk/
+ * rendering/svg/SVGTextChunk.h:
+ * rendering/svg/SVGTextChunkBuilder.cpp: Added.
+ * rendering/svg/SVGTextChunkBuilder.h: Added.
+ * rendering/svg/SVGTextLayoutAttributes.cpp: Constify dump() method.
+ * rendering/svg/SVGTextLayoutAttributes.h:
+ (WebCore::SVGTextLayoutAttributes::textMetricsValues):
+ * rendering/svg/SVGTextLayoutAttributesBuilder.cpp: Rewritten, consume less memory, while building the layout attributes.
+ * rendering/svg/SVGTextLayoutAttributesBuilder.h:
+ * rendering/svg/SVGTextLayoutEngine.cpp: Added.
+ * rendering/svg/SVGTextLayoutEngine.h: Added.
+ * rendering/svg/SVGTextQuery.cpp: Rewritten to deal with the new SVGTextFragment/SVGTextLayoutAttributes logic.
+ * rendering/svg/SVGTextQuery.h:
+
+2010-10-02 Alpha Lam <hclam@chromium.org>
+
+ Build fix. Not reviewed.
+
+ An adhoc fix for a crash found by reliability bot. This will make the
+ reliability bot happy. A proper fix is pending commit.
+
+ * platform/graphics/chromium/VideoLayerChromium.cpp:
+ (WebCore::VideoLayerChromium::~VideoLayerChromium):
+
+2010-10-01 Ryosuke Niwa <rniwa@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ FormatBlockCommand and IndentOutdentCommand should use the same code to iterate paragraphs
+ https://bugs.webkit.org/show_bug.cgi?id=46840
+
+ Added ApplyBlockElementCommand, which is an abstract class inherited by FormatBlockCommand
+ and IndentOutdentCommand. It is intended to be inherited by InsertListCommand as well.
+
+ ApplyBlockElementCommand's doApply verifies the current selection and exits early
+ if it's invalid or orphaned or if the current selection is outside editable region.
+ It then calls formatSelection to apply the block element after which doApply restores the selection.
+ formatSelection iterates through paragraphs and calls formatParagraph, a pure virtual function
+ implemented by FormatBlockCommand and IndentOutdentCommand, on each paragraph.
+
+ No new tests are added since this is a refactoring.
+
+ * Android.mk: Added ApplyBlockElementCommand.cpp.
+ * CMakeLists.txt: Ditto.
+ * GNUmakefile.am: Added ApplyBlockElementCommand.cpp and ApplyBlockElementCommand.h.
+ * WebCore.gypi: Ditto.
+ * WebCore.pro: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+ * editing/ApplyBlockElementCommand.cpp: Added.
+ (WebCore::countParagraphs): Moved from IndentOutdentCommand.cpp
+ (WebCore::ApplyBlockElementCommand::ApplyBlockElementCommand): Added.
+ (WebCore::ApplyBlockElementCommand::doApply): Moved from IndentOutdentCommand::doApply.
+ (WebCore::ApplyBlockElementCommand::formatSelection): Moved from IndentOutdentCommand::indentRegion.
+ (WebCore::ApplyBlockElementCommand::createBlockElement): Added.
+ (WebCore::ApplyBlockElementCommand::splitTextNodes): Moved from IndentOutdentCommand::splitTextNodes.
+ * editing/ApplyBlockElementCommand.h: Added.
+ * editing/EditingAllInOne.cpp:
+ * editing/EditorCommand.cpp:
+ (WebCore::executeFormatBlock):
+ * editing/FormatBlockCommand.cpp: Removed doApply.
+ (WebCore::FormatBlockCommand::FormatBlockCommand): Calls ApplyBlockElementCommand's constructor.
+ (WebCore::FormatBlockCommand::formatParagraph): Renamed from doApplyForSingleParagraph.
+ * editing/FormatBlockCommand.h: FormatBlockCommand inherits from ApplyBlockElementCommand.
+ (WebCore::FormatBlockCommand::create): Uses QualifiedName for the tag name instead of AtomicString.
+ * editing/IndentOutdentCommand.cpp: Removed doApply, indentIntoBlockquote, and splitTextNodes.
+ (WebCore::IndentOutdentCommand::IndentOutdentCommand): Calls ApplyBlockElementCommand's constructor.
+ (WebCore::IndentOutdentCommand::indentIntoBlockquote): The code to nullify targetBlockquote
+ when the next paragraph is in a different table cell is moved to ApplyBlockElementCommand::formatSelection.
+ (WebCore::IndentOutdentCommand::formatSelection): Added. Calls outdentRegion when outdenting.
+ (WebCore::IndentOutdentCommand::formatParagraph): Added. Calls tryIndentingAsListItem and indentIntoBlockquote.
+ * editing/IndentOutdentCommand.h: IndentOutdentCommand inherits from ApplyBlockElementCommand.
+
+2010-10-01 Mark Rowe <mrowe@apple.com>
+
+ Build fix.
+
+ Clear the executable bit from a number of source files.
+
+ * page/Frame.cpp:
+ * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
+ * platform/graphics/win/WKCACFLayerRenderer.cpp:
+ * platform/graphics/win/WKCACFLayerRenderer.h:
+ * platform/network/ResourceRawHeaders.h:
+ * rendering/RenderLayerCompositor.cpp:
+ * rendering/RenderLayerCompositor.h:
+
+2010-10-01 Martin Robinson <mrobinson@igalia.com>
+
+ Reviewed by Adam Barth.
+
+ [GTK] r68923 broke some plugin tests
+ https://bugs.webkit.org/show_bug.cgi?id=47040
+
+ No longer pass focus and blur events to plugins when the "old" DOM Level
+ 2 DOMFocusIn/DOMFocusOut events occur. r68923 made a change which means
+ that the DOM Level 3 version is always fired for this event.
+
+ No new tests, as this should cause the failing tests to pass.
+
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::handleEvent): No longer pass focus and blur events to
+ plugins when DOMFocusIn / DOMFocusOut events occur.
+
+2010-10-01 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Plug-ins should have access to the private browsing state.
+ https://bugs.webkit.org/show_bug.cgi?id=47031
+ <rdar://problem/8505405>
+
+ * page/Page.cpp:
+ (WebCore::Page::privateBrowsingStateChanged):
+ When iterating over all widgets, also look for PluginViewBase classes and invoke their
+ privateBrowsingStateChange member function.
+
+ * plugins/PluginViewBase.h:
+ (WebCore::PluginViewBase::privateBrowsingStateChanged):
+ Add function.
+
+2010-10-01 Brian Weinstein <bweinstein@apple.com>
+
+ Build Fix for Windows.
+
+ * WebCore.vcproj/WebCore.vcproj: Don't have an empty post-build step, use
+ WebCoreCommon.vsprops to handle post-build step.
+ * WebCore.vcproj/WebCoreCommon.vsprops: Set the post-build step to delete
+ $(WebKitOutputDir)/buildfailed.
+
+2010-10-01 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ [Qt] Segmentation fault during zoom out
+ https://bugs.webkit.org/show_bug.cgi?id=46984
+
+ * platform/qt/QtMobileWebStyle.cpp:
+ (QtMobileWebStyle::drawChecker): Adjust checkerSize to be greater than or equals to middle.
+
+2010-10-01 Anders Carlsson <andersca@apple.com>
+
+ Another Qt build fix attempt.
+
+ * WebCore.pro:
+
+2010-10-01 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=47021
+
+ Patch the floatBottom function and its friends. Rename them and consolidate them to be block-flow-aware.
+
+ Nothing testable yet, since most of the float code is still unpatched.
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::layoutBlock):
+ (WebCore::RenderBlock::layoutBlockChildren):
+ (WebCore::RenderBlock::layoutBlockChild):
+ (WebCore::RenderBlock::positionNewFloats):
+ (WebCore::RenderBlock::newLine):
+ (WebCore::RenderBlock::nextFloatLogicalBottomBelow):
+ (WebCore::RenderBlock::lowestFloatLogicalBottom):
+ (WebCore::RenderBlock::clearFloats):
+ (WebCore::RenderBlock::addOverhangingFloats):
+ (WebCore::RenderBlock::getClearDelta):
+ * rendering/RenderBlock.h:
+ (WebCore::RenderBlock::logicalBottomForFloat):
+ (WebCore::RenderBlock::hasOverhangingFloats):
+ * rendering/RenderBlockLineLayout.cpp:
+ (WebCore::RenderBlock::fitBelowFloats):
+
+2010-10-01 Anders Carlsson <andersca@apple.com>
+
+ Fix typo.
+
+ * platform/network/qt/ProxyServerQt.cpp:
+ (WebCore::proxyServersForURL):
+
+2010-10-01 Anders Carlsson <andersca@apple.com>
+
+ Add Qt ProxyServer stub.
+
+ * WebCore.pro:
+ * platform/network/qt/ProxyServerQt.cpp: Added.
+ (WebCore::proxyServersForURL):
+
+2010-10-01 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Add proxy server query function proxyServersForURL and change the Mac plug-in code to use it
+ https://bugs.webkit.org/show_bug.cgi?id=47022
+ <rdar://problem/8504712>
+
+ * WebCore.exp.in:
+ Export proxyServersForURL and toString.
+
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ Add new files.
+
+ * platform/network/ProxyServer.cpp: Added.
+ (WebCore::appendProxyServerString):
+ (WebCore::toString):
+ New function that converts a vector of ProxyServers into a PAC style string.
+
+ * platform/network/ProxyServer.h: Added.
+ (WebCore::ProxyServer::ProxyServer):
+ (WebCore::ProxyServer::type):
+ (WebCore::ProxyServer::hostName):
+ (WebCore::ProxyServer::port):
+ Add ProxyServer class.
+
+ * platform/network/cf/ProxyServerCFNet.cpp: Added.
+ (WebCore::proxyServersForURL):
+ (WebCore::addProxyServersForURL):
+ Query CFNetwork for the proxy servers given a URL.
+
+2010-09-30 Zhenyao Mo <zmo@google.com>
+
+ Reviewed by Kenneth Russell.
+
+ texImage2D fails on 16-bit-per-channel images
+ https://bugs.webkit.org/show_bug.cgi?id=46947
+
+ * platform/graphics/GraphicsContext3D.cpp: Handling 16-bit-per-channel source formats.
+ (WebCore::convertColor16To8):
+ (WebCore::doPacking):
+ * platform/graphics/GraphicsContext3D.h: Ditto.
+ * platform/graphics/cg/GraphicsContext3DCG.cpp: Ditto.
+ (WebCore::GraphicsContext3D::getImageData):
+
+2010-10-01 Eric Uhrhane <ericu@chromium.org>
+
+ Reviewed by Nate Chapin.
+
+ Add v8 binding helpers to make FileWriter be an EventTarget.
+ https://bugs.webkit.org/show_bug.cgi?id=46910
+
+ No new tests; still waiting for the first complete implementation.
+
+ * bindings/v8/V8DOMWrapper.cpp:
+ (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
+
+2010-10-01 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=47015
+
+ Change FloatingObject to store its dimensions as a rect.
+ This will make it easier for logical access for block-flow later on if
+ top/bottom is no different from left/width. This change also simplifies
+ calling code a bit in places.
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::addOverflowFromFloats):
+ (WebCore::RenderBlock::repaintOverhangingFloats):
+ (WebCore::RenderBlock::paintFloats):
+ (WebCore::RenderBlock::fillSelectionGaps):
+ (WebCore::RenderBlock::insertFloatingObject):
+ (WebCore::RenderBlock::removeFloatingObject):
+ (WebCore::RenderBlock::removeFloatingObjectsBelow):
+ (WebCore::RenderBlock::positionNewFloats):
+ (WebCore::RenderBlock::positionNewFloatOnLine):
+ (WebCore::RenderBlock::logicalLeftOffsetForLine):
+ (WebCore::RenderBlock::logicalRightOffsetForLine):
+ (WebCore::RenderBlock::nextFloatBottomBelow):
+ (WebCore::RenderBlock::floatBottom):
+ (WebCore::RenderBlock::lowestPosition):
+ (WebCore::RenderBlock::rightmostPosition):
+ (WebCore::RenderBlock::leftmostPosition):
+ (WebCore::RenderBlock::leftBottom):
+ (WebCore::RenderBlock::rightBottom):
+ (WebCore::RenderBlock::clearFloats):
+ (WebCore::RenderBlock::addOverhangingFloats):
+ (WebCore::RenderBlock::addIntrudingFloats):
+ (WebCore::RenderBlock::hitTestFloats):
+ (WebCore::RenderBlock::adjustForBorderFit):
+ * rendering/RenderBlock.h:
+ (WebCore::RenderBlock::FloatingObject::FloatingObject):
+ (WebCore::RenderBlock::FloatingObject::left):
+ (WebCore::RenderBlock::FloatingObject::right):
+ (WebCore::RenderBlock::FloatingObject::top):
+ (WebCore::RenderBlock::FloatingObject::bottom):
+ (WebCore::RenderBlock::FloatingObject::width):
+ (WebCore::RenderBlock::FloatingObject::height):
+ (WebCore::RenderBlock::FloatingObject::setLeft):
+ (WebCore::RenderBlock::FloatingObject::setTop):
+ (WebCore::RenderBlock::FloatingObject::setWidth):
+ (WebCore::RenderBlock::FloatingObject::setHeight):
+ (WebCore::RenderBlock::FloatingObject::frameRect):
+ (WebCore::RenderBlock::FloatingObject::setFrameRect):
+ * rendering/RenderBlockLineLayout.cpp:
+ (WebCore::RenderBlock::layoutInlineChildren):
+ (WebCore::RenderBlock::matchedEndLine):
+
+2010-10-01 Enrica Casucci <enrica@apple.com>
+
+ Reviewed by Darin Adler.
+
+ DOMFocusIn/DOMFocusOut return focusin/focusout Event.type
+ https://bugs.webkit.org/show_bug.cgi?id=42580
+ <rdar://problem/8107311>
+
+ This change removes the aliased type machinery from the Event class.
+ We now fire the event with the new name and the oldname.
+
+ Tests: Modified fast/events/focusinout.html to check the event
+ type.
+
+ * dom/Document.cpp:
+ (WebCore::Document::setFocusedNode):
+ * dom/Event.cpp: Removed aliasedType and hasAliasedType.
+ * dom/Event.h: Removed aliasedType and hasAliasedType.
+ * dom/EventTarget.cpp:
+ (WebCore::EventTarget::fireEventListeners): Removed aliasedType related code.
+
+2010-10-01 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=46642, make replaced elements work with block-flow. This patch changes
+ all of the computeReplacedLogicalWidth and comuteReplacedLogicalHeight functions (and their helpers) to use logical width
+ and logical height instead.
+
+ Added fast/blockflow/block-level-images.html
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::computeLogicalWidth):
+ (WebCore::RenderBox::computeLogicalHeight):
+ (WebCore::RenderBox::computeReplacedLogicalWidth):
+ (WebCore::RenderBox::computeReplacedLogicalWidthUsing):
+ (WebCore::RenderBox::computeReplacedLogicalHeight):
+ (WebCore::RenderBox::computeReplacedLogicalHeightUsing):
+ (WebCore::RenderBox::computePositionedLogicalWidthReplaced):
+ (WebCore::RenderBox::computePositionedLogicalHeightReplaced):
+ * rendering/RenderBox.h:
+ (WebCore::RenderBox::intrinsicLogicalWidth):
+ (WebCore::RenderBox::intrinsicLogicalHeight):
+ * rendering/RenderImage.cpp:
+ (WebCore::RenderImage::isLogicalWidthSpecified):
+ (WebCore::RenderImage::isLogicalHeightSpecified):
+ (WebCore::RenderImage::computeReplacedLogicalWidth):
+ (WebCore::RenderImage::computeReplacedLogicalHeight):
+ (WebCore::RenderImage::calcAspectRatioLogicalWidth):
+ (WebCore::RenderImage::calcAspectRatioLogicalHeight):
+ * rendering/RenderImage.h:
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::layout):
+ (WebCore::RenderReplaced::computeReplacedLogicalWidth):
+ (WebCore::RenderReplaced::computeReplacedLogicalHeight):
+ (WebCore::RenderReplaced::calcAspectRatioLogicalWidth):
+ (WebCore::RenderReplaced::calcAspectRatioLogicalHeight):
+ (WebCore::RenderReplaced::computePreferredLogicalWidths):
+ * rendering/RenderReplaced.h:
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::computePreferredLogicalWidths):
+ (WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
+ (WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
+ * rendering/RenderSVGRoot.h:
+ * rendering/RenderVideo.cpp:
+ (WebCore::RenderVideo::computeReplacedLogicalWidth):
+ (WebCore::RenderVideo::computeReplacedLogicalHeight):
+ * rendering/RenderVideo.h:
+
+2010-10-01 Nate Chapin <japhet@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Remove unused Request::buffer() and Request::m_buffer.
+
+ https://bugs.webkit.org/show_bug.cgi?id=47003
+
+ * loader/Request.h:
+
+2010-10-01 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ <rdar://problem/7563219> Null dereference when dragging an element with generated content
+ https://bugs.webkit.org/show_bug.cgi?id=47005
+
+ Test: fast/css-generated-content/drag-state.html
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::updateDragState): Null-check node().
+
+2010-10-01 Robert Hogan <robert@webkit.org>
+
+ Reviewed by Adam Barth.
+
+ [Qt] Fix http/tests/loading/redirect-methods.html
+
+ Document our redirection behaviour too.
+
+ https://bugs.webkit.org/show_bug.cgi?id=41571
+
+ * platform/network/qt/QNetworkReplyHandler.cpp:
+ (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
+ (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
+ * platform/network/qt/QNetworkReplyHandler.h:
+
+2010-10-01 Adam Roben <aroben@apple.com>
+
+ Copy forwarding headers and Inspector JS files as part of
+ WebCoreGenerated.vcproj
+
+ WebCoreGenerated.vcproj runs on every build, while WebCore.vcproj only
+ runs when a .h or .cpp file changes. By moving the copying to
+ WebCoreGenerated, it will happen even when someone only changes a JS
+ file (as happened in r68887).
+
+ Fixes <http://webkit.org/b/46988> <rdar://problem/8502489> REGRESSION
+ (r68887): Web Inspector: inspector/extensions*.html are failing on
+ Windows
+
+ Reviewed by Anders Carlsson.
+
+ * WebCore.vcproj/WebCore.vcproj: Moved invocation of
+ copyForwardingHeaders and copyInspectorFiles from here...
+ * WebCore.vcproj/WebCoreGenerated.vcproj: ...to here.
+
+2010-09-30 Ryosuke Niwa <rniwa@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Implement queryCommandState('justifyFull')
+ https://bugs.webkit.org/show_bug.cgi?id=46954
+
+ Implemented queryCommandState('justifyFull').
+ New tests are added to editing/style/inline-style-container.html
+
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::getTextAlignment): Added support for CSSValueJustify.
+ * editing/EditorCommand.cpp:
+ (WebCore::stateJustifyFull): Added.
+ (WebCore::createCommandMap): Added stateJustifyFull.
+
+2010-10-01 Jia Pu <jpu@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Autocorrection shouldn't prompt the same correction after user has edited previous correction.
+ https://bugs.webkit.org/show_bug.cgi?id=46839
+ <rdar://problem/8476963>
+
+ * editing/Editor.cpp:
+ (WebCore::Editor::respondToChangedSelection): Remove "CorrectionIndicator" marker instead of
+ "Replacement" marker. Since the former controls whether we draw autocorrection underline,
+ and the latter is used to prevent autocorrection from being applied again on already auto-
+ corrected word. So the "Replacement" shouldn't be removed.
+
+2010-10-01 Patrick Gansterer <paroga@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ [CMake] Add handling for ENABLE(NETSCAPE_PLUGIN_API)
+ https://bugs.webkit.org/show_bug.cgi?id=46309
+
+ * CMakeLists.txt:
+ * CMakeListsEfl.txt:
+
+2010-10-01 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=46996, patch the functions dealing with the bottom of the block to
+ be block-flow-aware.
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::setCollapsedBottomMargin):
+ (WebCore::RenderBlock::handleAfterSideOfBlock):
+
+2010-10-01 Pratik Solanki <psolanki@apple.com>
+
+ Reviewed by Geoffrey Garen.
+ Specify ALWAYS_INLINE at function declaration not function definition
+ https://bugs.webkit.org/show_bug.cgi?id=46960
+
+ For functions defined with ALWAYS_INLINE, add the attribute to the declaration as well.
+
+ * css/CSSStyleSelector.h:
+ * rendering/InlineIterator.h:
+ * rendering/style/RenderStyle.h:
+
+2010-10-01 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ https://bugs.webkit.org/show_bug.cgi?id=46995, make direction propagate up to the viewport from the root element.
+
+ Added fast/css/rtl-to-viewport.html
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::styleForDocument):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::styleDidChange):
+
+2010-10-01 Alexey Proskuryakov <ap@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=44406
+ <rdar://problem/8310921> Application Cache crash when a fallback document has a manifest URL
+
+ Test: http/tests/appcache/foreign-fallback.html
+
+ * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache):
+ Changed ApplicationCacheResource lookup to find fallback resources correctly.
+
+2010-10-01 Kwang Yul Seo <skyul@company100.net>
+
+ Unreviewed, Brew MP build fix.
+
+ * platform/brew/ClipboardBrew.cpp:
+ (WebCore::ClipboardBrew::ClipboardBrew):
+
+2010-10-01 Rafael Antognolli <antognolli@profusion.mobi>
+
+ Unreviewed build fix.
+
+ [CMAKE] Build fix for r68878
+ https://bugs.webkit.org/show_bug.cgi?id=46985
+
+ Fix name of files added to CMakeLists.txt:
+ SVGTextLayoutBaseline.cpp -> SVGTextLayoutEngineBaseline.cpp
+ SVGTextLayoutSpacing.cpp -> SVGTextLayoutEngineSpacing.cpp
+
+ No features added, so no new tests.
+
+ * CMakeLists.txt:
+
+2010-10-01 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ [Qt] New buttons style for Qt Mobile theme
+ https://bugs.webkit.org/show_bug.cgi?id=46920
+
+ Rename Maemo5Webstyle to QtMobileWebStyle since it implements the style for all Qt mobile platform.
+ Adjust new Qt mobile style for buttons, radios, checks and combos.
+
+ * WebCore.pro:
+ * css/themeQtMobile.css: Adjust gradient color for buttons and combos.
+ (select):
+ (select:active):
+ * platform/qt/QtMobileWebStyle.cpp: Renamed from platform/qt/Maemo5Webstyle.cpp to match name scheme.
+ (QtMobileWebStyle::QtMobileWebStyle):
+ (drawRectangularControlBackground):
+ (QtMobileWebStyle::drawChecker):
+ (QtMobileWebStyle::findChecker):
+ (QtMobileWebStyle::drawRadio): Adjust gradient color for RadioButton.
+ (QtMobileWebStyle::findRadio):
+ (QtMobileWebStyle::drawControl): Adjust gradient color for CheckBox.
+ (QtMobileWebStyle::drawMultipleComboButton):
+ (QtMobileWebStyle::drawSimpleComboButton): Adjust ComboBox arrow.
+ (QtMobileWebStyle::getButtonImageSize):
+ (QtMobileWebStyle::findComboButton):
+ (QtMobileWebStyle::drawComplexControl):
+ * platform/qt/QtMobileWebStyle.h: Renamed from platform/qt/Maemo5Webstyle.h to match name scheme.
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::RenderThemeQt):
+
+2010-10-01 Andrey Kosyakov <caseq@chromium.org>
+
+ Reviewed by Pavel Feldman.
+
+ Web Inspector: [Extensions API] expose page load events timings
+ Added webInspector.resources.getPageTimings()
+
+ https://bugs.webkit.org/show_bug.cgi?id=45954
+
+ * inspector/front-end/ExtensionAPI.js:
+ (WebInspector.injectedExtensionAPI.Resources.prototype):
+ (WebInspector.injectedExtensionAPI.Resources.prototype.getPageTimings):
+ * inspector/front-end/ExtensionServer.js:
+ (WebInspector.ExtensionServer):
+ (WebInspector.ExtensionServer.prototype._onGetPageTimings):
+ * inspector/front-end/HAREntry.js: Return page event timings as -1 if start or event time unknown.
+ (WebInspector.HARLog.prototype._buildPages):
+ (WebInspector.HARLog.prototype.buildMainResourceTimings):
+ (WebInspector.HARLog.prototype._convertResource):
+ (WebInspector.HARLog.prototype._pageEventTime):
+
+2010-10-01 Patrick Gansterer <paroga@webkit.org>
+
+ Reviewed by Adam Roben.
+
+ [WIN] Add GDIExtras
+ https://bugs.webkit.org/show_bug.cgi?id=46974
+
+ Some, but not all WinCE environments have support for AlphaBlend().
+ Add this files to check for AlphaBlend (and SoftLink) on WinCE.
+ On WinNT alphaBlendIfSupported() inlines AlphaBlend and returns true.
+
+ * platform/graphics/win/GDIExtras.cpp: Added.
+ (WebCore::AlphaBlendPointer):
+ * platform/graphics/win/GDIExtras.h: Added.
+ (WebCore::hasAlphaBlendSupport):
+ (WebCore::alphaBlendIfSupported):
+
+2010-10-01 Patrick Gansterer <paroga@webkit.org>
+
+ Reviewed by Adam Roben.
+
+ [WINCE] Use alphaBlendIfSupported in GraphicsContext
+ https://bugs.webkit.org/show_bug.cgi?id=46979
+
+ * platform/graphics/wince/GraphicsContextWinCE.cpp:
+ (WebCore::GraphicsContextPlatformPrivate::paintBackTransparentLayerBitmap):
+
+2010-10-01 Nikolas Zimmermann <nzimmermann@rim.com>
+
+ Reviewed by Dirk Schulze.
+
+ Add two new helper files for the new SVGTextLayoutEngine
+ https://bugs.webkit.org/show_bug.cgi?id=46972
+
+ Refactor code from SVGTextLayoutUtilities into two seperated classes.
+ SVGTextLayoutUtilities will be removed, as soon as the main clss SVGTextLayoutEngine lands and gets used.
+
+ Doesn't affect any functionality yet, as the new classes are not used so far.
+
+ * Android.mk:
+ * CMakeLists.txt:
+ * GNUmakefile.am:
+ * WebCore.gypi:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * rendering/svg/SVGTextFragment.h:
+ * rendering/svg/SVGTextLayoutEngineBaseline.cpp: Added.
+ (WebCore::SVGTextLayoutEngineBaseline::SVGTextLayoutEngineBaseline):
+ (WebCore::SVGTextLayoutEngineBaseline::calculateBaselineShift):
+ (WebCore::SVGTextLayoutEngineBaseline::dominantBaselineToAlignmentBaseline):
+ (WebCore::SVGTextLayoutEngineBaseline::calculateAlignmentBaselineShift):
+ (WebCore::SVGTextLayoutEngineBaseline::calculateGlyphOrientationAngle):
+ (WebCore::glyphOrientationIsMultiplyOf180Degrees):
+ (WebCore::SVGTextLayoutEngineBaseline::calculateGlyphAdvanceAndOrientation):
+ * rendering/svg/SVGTextLayoutEngineBaseline.h: Added.
+ * rendering/svg/SVGTextLayoutEngineSpacing.cpp: Added.
+ (WebCore::SVGTextLayoutEngineSpacing::SVGTextLayoutEngineSpacing):
+ (WebCore::SVGTextLayoutEngineSpacing::calculateSVGKerning):
+ (WebCore::SVGTextLayoutEngineSpacing::calculateCSSKerningAndSpacing):
+ * rendering/svg/SVGTextLayoutEngineSpacing.h: Added.
+
+2010-10-01 Nikolas Zimmermann <nzimmermann@rim.com>
+
+ Reviewed by Andreas Kling.
+
+ Rename SVGTextLayoutBuilder to SVGTextLayoutAttributesBuilder
+ https://bugs.webkit.org/show_bug.cgi?id=46971
+
+ Doesn't affect any functionality, just moves files around.
+
+ * Android.mk:
+ * CMakeLists.txt:
+ * GNUmakefile.am:
+ * WebCore.gypi:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * rendering/svg/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::layout): Adopt to renaming.
+ * rendering/svg/SVGTextLayoutAttributesBuilder.cpp: Copied from rendering/svg/SVGTextLayoutBuilder.cpp.
+ * rendering/svg/SVGTextLayoutAttributesBuilder.h: Copied from rendering/svg/SVGTextLayoutBuilder.h.
+ * rendering/svg/SVGTextLayoutBuilder.cpp: Removed.
+ * rendering/svg/SVGTextLayoutBuilder.h: Removed.
+
+2010-10-01 MORITA Hajime <morrita@google.com>
+
+ Unreviewed build fix.
+
+ * platform/graphics/skia/PlatformContextSkia.cpp:
+ (WebCore::PlatformContextSkia::PlatformContextSkia):
+
+2010-10-01 Nikolas Zimmermann <nzimmermann@rim.com>
+
+ Reviewed by Andreas Kling.
+
+ Move SVG text related renderers into rendering/svg/
+ https://bugs.webkit.org/show_bug.cgi?id=46969
+
+ Doesn't affect any functionality, just moves files around.
+
+ * Android.mk:
+ * CMakeLists.txt:
+ * GNUmakefile.am:
+ * WebCore.gypi:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * rendering/RenderSVGAllInOne.cpp:
+ * rendering/RenderSVGInline.cpp: Removed.
+ * rendering/RenderSVGInline.h: Removed.
+ * rendering/RenderSVGInlineText.cpp: Removed.
+ * rendering/RenderSVGInlineText.h: Removed.
+ * rendering/RenderSVGTSpan.cpp: Removed.
+ * rendering/RenderSVGTSpan.h: Removed.
+ * rendering/RenderSVGText.cpp: Removed.
+ * rendering/RenderSVGText.h: Removed.
+ * rendering/RenderSVGTextPath.cpp: Removed.
+ * rendering/RenderSVGTextPath.h: Removed.
+ * rendering/SVGInlineFlowBox.cpp: Removed.
+ * rendering/SVGInlineFlowBox.h: Removed.
+ * rendering/SVGInlineTextBox.cpp: Removed.
+ * rendering/SVGInlineTextBox.h: Removed.
+ * rendering/SVGRootInlineBox.cpp: Removed.
+ * rendering/SVGRootInlineBox.h: Removed.
+ * rendering/SVGTextQuery.cpp: Removed.
+ * rendering/SVGTextQuery.h: Removed.
+ * rendering/svg/RenderSVGInline.cpp: Copied from rendering/RenderSVGInline.cpp.
+ * rendering/svg/RenderSVGInline.h: Copied from rendering/RenderSVGInline.h.
+ * rendering/svg/RenderSVGInlineText.cpp: Copied from rendering/RenderSVGInlineText.cpp.
+ * rendering/svg/RenderSVGInlineText.h: Copied from rendering/RenderSVGInlineText.h.
+ * rendering/svg/RenderSVGTSpan.cpp: Copied from rendering/RenderSVGTSpan.cpp.
+ * rendering/svg/RenderSVGTSpan.h: Copied from rendering/RenderSVGTSpan.h.
+ * rendering/svg/RenderSVGText.cpp: Copied from rendering/RenderSVGText.cpp.
+ * rendering/svg/RenderSVGText.h: Copied from rendering/RenderSVGText.h.
+ * rendering/svg/RenderSVGTextPath.cpp: Copied from rendering/RenderSVGTextPath.cpp.
+ * rendering/svg/RenderSVGTextPath.h: Copied from rendering/RenderSVGTextPath.h.
+ * rendering/svg/SVGInlineFlowBox.cpp: Copied from rendering/SVGInlineFlowBox.cpp.
+ * rendering/svg/SVGInlineFlowBox.h: Copied from rendering/SVGInlineFlowBox.h.
+ * rendering/svg/SVGInlineTextBox.cpp: Copied from rendering/SVGInlineTextBox.cpp.
+ * rendering/svg/SVGInlineTextBox.h: Copied from rendering/SVGInlineTextBox.h.
+ * rendering/svg/SVGRootInlineBox.cpp: Copied from rendering/SVGRootInlineBox.cpp.
+ * rendering/svg/SVGRootInlineBox.h: Copied from rendering/SVGRootInlineBox.h.
+ * rendering/svg/SVGTextQuery.cpp: Copied from rendering/SVGTextQuery.cpp.
+ * rendering/svg/SVGTextQuery.h: Copied from rendering/SVGTextQuery.h.
+
+2010-10-01 Nikolas Zimmermann <nzimmermann@rim.com>
+
+ Reviewed by Dirk Schulze.
+
+ Add SVGTextMetrics/SVGTextFragment/SVGTextChunk primitives used by the new layout engine
+ https://bugs.webkit.org/show_bug.cgi?id=46964
+
+ The new SVG text layout engine will use these new classes.
+ 1) SVGTextMetrics is used to measure either single glyphs (which may span multiple characters, when ligatures are defined) or a range of characters.
+
+ -> In "single glyph" mode, it returns the width/height of the glyph, the length of the glyph (> 1, when ligatures are used) and a "Glyph" object
+ describing the glyph (name of glyph, when used together with SVG Fonts and the unicode string the glyph describes).
+ -> In "range of characters" mode, it returns the width/height of the range, and its length.
+
+ All measurements are done using the regular Font::floatWidth() methods, this class just encapsulates its usage for the SVG text layout engine.
+
+ 2) SVGTextFragment describes a fragment of text, living in a SVGInlineTextBox, which can be measured/rendered in one shot.
+ It contains all necessary information to render the fragment (x/y/width/height, offset into characters() buffer for the first char of the fragment,
+ length, and an arbitary transformation, holding information about rotations/scale/glyph-orientation etc.)
+
+ In future the SVGTextLayoutEngine will generate SVGTextFragment objects for each SVGInlineTextBox. When painting no more measurements have to
+ be performed as SVGTextFragment contains all necessary information to render text / select text etc.
+
+ 3) SVGTextChunk describes a SVG text chunk, which may span multiple text boxes (and in turn text fragments).
+
+ Quotes from SVG spec:
+ Each absolute position adjustment defines a new "text chunk". Absolute position adjustments impact text layout in the following ways:
+ * Ligatures only occur when a set of characters which might map to a ligature are all in the same text chunk.
+ * Each text chunk represents a separate block of text for alignment due to "text-anchor" property values.
+ * Reordering of characters due to bidirectionality only occurs within a text chunk. Reordering does not happen across text chunks.
+
+ An absolute position adjustment occurs in the following circumstances:
+ * At the start of a <text> element
+ * At the start of each <textPath> element
+ * For each character within a <text>, <tspan>, <tref> and <altGlyph> element which has an "x" or "y" attribute value assigned to it explicitly
+
+ After the line-layout finishes, each "text chunk" is altered according to the textLength and text-anchor processing rules
+ (eg. for text-anchor="middle" moving the whole text chunk by -fragmentWidth/2, for horizontal text).
+
+ SVGTextChunk is just a simple helper class, that encapsulates measuring/altering a text chunk.
+
+ Doesn't affect any tests, as these classes aren't used so far.
+
+ * Android.mk: Add SVGTextMetrics.*, SVGTextFragment.h, SVGTextChunk.* to build.
+ * CMakeLists.txt: Ditto.
+ * GNUmakefile.am: Ditto.
+ * WebCore.gypi: Ditto.
+ * WebCore.pro: Ditto.
+ * WebCore.vcproj/WebCore.vcproj: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+ * rendering/svg/SVGTextChunk.cpp: Added.
+ * rendering/svg/SVGTextChunk.h: Added.
+ * rendering/svg/SVGTextFragment.h: Added.
+ * rendering/svg/SVGTextMetrics.cpp: Added.
+ * rendering/svg/SVGTextMetrics.h: Added.
+
+2010-10-01 Vincent Scheib <scheib@chromium.org>
+
+ Reviewed by James Robinson.
+
+ REGRESSION: Lots of fast canvas updates fail to completely render
+ https://bugs.webkit.org/show_bug.cgi?id=46319
+
+ Test: fast/repaint/canvas-putImageData.html
+
+ * html/canvas/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::putImageData):
+
+2010-10-01 Nikolas Zimmermann <nzimmermann@rim.com>
+
+ Reviewed by Dirk Schulze.
+
+ Add helper methods to cast between renderers & SVGTextContent/PositioningElement
+ https://bugs.webkit.org/show_bug.cgi?id=46963
+
+ Doesn't affect any tests.
+
+ * svg/SVGTextContentElement.cpp:
+ (WebCore::SVGTextContentElement::elementFromRenderer):
+ * svg/SVGTextContentElement.h:
+ * svg/SVGTextPositioningElement.cpp:
+ (WebCore::SVGTextPositioningElement::elementFromRenderer):
+ * svg/SVGTextPositioningElement.h:
+
+2010-09-30 MORITA Hajime <morrita@google.com>
+
+ Reviewed by James Robinson.
+
+ [Chromium] build fails unless ACCELERATED_2D_CANVAS defined
+ https://bugs.webkit.org/show_bug.cgi?id=46955
+
+ Added ifdef guard around SharedGraphicsContext3D.
+
+ No new tests. just a build fix.
+
+ * platform/graphics/skia/PlatformContextSkia.cpp:
+ (WebCore::PlatformContextSkia::~PlatformContextSkia):
+ (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
+ (WebCore::PlatformContextSkia::uploadSoftwareToHardware):
+ (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
+ * platform/graphics/skia/PlatformContextSkia.h:
+ (WebCore::PlatformContextSkia::gpuCanvas):
+
+2010-09-30 Kent Tamura <tkent@chromium.org>
+
+ Reviewed by Chris Fleizach.
+
+ [Windows] Implement <input type=number> UI
+ https://bugs.webkit.org/show_bug.cgi?id=38381
+
+ Implement theme drawing for inner-spin-button.
+ No new tests. Existing tests for type=number will cover this change.
+
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::RenderThemeWin::RenderThemeWin):
+ Handle m_spinButtonTheme.
+ (WebCore::RenderThemeWin::spinButtonTheme): ditto.
+ (WebCore::RenderThemeWin::close): ditto.
+ (WebCore::RenderThemeWin::determineClassicState):
+ Add ControlSubPart parameter, and add support for InnerSpinButtonPart.
+ (WebCore::RenderThemeWin::determineSpinButtonState): Added.
+ (WebCore::RenderThemeWin::getClassicThemeData):
+ Add ControlSubPart parameter, and handle InnerSpinButtonPart.
+ (WebCore::RenderThemeWin::getThemeData): ditto.
+ (WebCore::RenderThemeWin::adjustInnerSpinButtonStyle):
+ Set SM_CXVSCROLL value to the width.
+ (WebCore::RenderThemeWin::paintInnerSpinButton):
+ Call drawControl() for the upper part and the lower part.
+ * rendering/RenderThemeWin.h:
+
+2010-09-30 Kent Tamura <tkent@chromium.org>
+
+ Unreviewed, Windows build fix for r68854
+
+ * WebCore.vcproj/copyForwardingHeaders.cmd:
+ Copy WebCore/html/parser/*.h.
+
+2010-09-30 Abhishek Arya <inferno@chromium.org>
+
+ Reviewed by Dan Bernstein.
+
+ While updating :before and :after content, make sure that the generated
+ container is allowed to add the child type.
+ https://bugs.webkit.org/show_bug.cgi?id=46106
+
+ Test: fast/css-generated-content/text-before-table-col-crash.html
+
+ * rendering/RenderObjectChildList.cpp:
+ (WebCore::RenderObjectChildList::updateBeforeAfterContent):
+
+2010-09-30 Mario Sanchez Prada <msanchez@igalia.com>
+
+ Reviewed by Daniel Bates.
+
+ [GTK] Crash on testatk.c unittest because of a call to ASSERT_NOT_REACHED
+ https://bugs.webkit.org/show_bug.cgi?id=46886
+
+ Removed call to ASSERT_NOT_REACHED() from listMarkerSuffix().
+
+ So far, this assertion made sense because it was not possible that
+ a call to listMarkerSuffix() happened when the style of the list
+ item was one of the following: Asterisks, Circle, Discm Footnotes,
+ NoneListStyle or Square (it's easy to figure this out by checking
+ the functions where listMarkerSuffix() was called).
+
+ However, since revision 68415 (about bug 45381), there's a new
+ place where listMarkerSuffix() is being called (the suffix()
+ public method), regardless of the style of the item being or not
+ one of those pointed out, so the aforementioned assertion in
+ listMarkerSuffix() would no longer be correct, as now it's ok to
+ reach those cases in the switch statement.
+
+ * rendering/RenderListMarker.cpp:
+ (WebCore::listMarkerSuffix): Removed call to ASSERT_NOT_REACHED().
+
+2010-09-30 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=46948 Crash with all-
+ whitespace separators for mfenced
+
+ Check the size of characters instead of separators in case all the
+ separators were whitespace.
+
+ * mathml/RenderMathMLFenced.cpp:
+ (WebCore::RenderMathMLFenced::updateFromElement):
+
+2010-09-30 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Remove remaining calls to deprecatedParseURL
+ https://bugs.webkit.org/show_bug.cgi?id=26599
+
+ Test: fast/replaced/object-param-spaces.html
+
+ * css/CSSHelper.cpp: Removed.
+ * css/CSSHelper.h: Removed deprecatedParseURL.
+
+ * html/parser/HTMLParserIdioms.cpp:
+ (WebCore::stripLeadingAndTrailingHTMLSpaces):
+ Fixed bug where the function would turn the null string into the empty string.
+ Fixed bug where the function would not strip all trailing spaces.
+
+ * html/parser/CSSPreloadScanner.cpp:
+ (WebCore::CSSPreloadScanner::CSSPreloadScanner): Initialize m_state
+ instead of calling the reset function.
+ (WebCore::CSSPreloadScanner::scan): Tweaked coding style.
+ (WebCore::CSSPreloadScanner::tokenize): Use isHTMLSpace instead of
+ an identical local function named isWhitespace.
+ (WebCore::parseCSSStringOrURL): Added. This function does what
+ deprecatedParseURL did before, and this is the only place in WebKit
+ that needs it. The code implements the rules for a string or URL
+ token. The real CSS parser does this with flex and the code to hook
+ flex up to yacc, so the function is not needed there.
+ (WebCore::CSSPreloadScanner::emitRule): Streamlined the code a bit
+ and mae it call parseCSSStringOrURL.
+
+ * bindings/generic/BindingSecurity.h:
+ (WebCore::::allowSettingFrameSrcToJavascriptUrl):
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::allowSettingSrcToJavascriptURL):
+ * bindings/js/JSHTMLFrameElementCustom.cpp:
+ (WebCore::allowSettingJavascriptURL):
+ * bindings/objc/DOM.mm:
+ (-[DOMElement _getURLAttribute:]):
+ * bindings/objc/DOMHTML.mm:
+ (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
+ * dom/Document.cpp:
+ (WebCore::Document::processBaseElement):
+ * dom/Element.cpp:
+ (WebCore::isAttributeToRemove):
+ (WebCore::Element::getURLAttribute):
+ (WebCore::Element::getNonEmptyURLAttribute):
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::defaultEventHandler):
+ (WebCore::HTMLAnchorElement::parseMappedAttribute):
+ (WebCore::HTMLAnchorElement::href):
+ * html/HTMLBodyElement.cpp:
+ (WebCore::HTMLBodyElement::parseMappedAttribute):
+ * html/HTMLEmbedElement.cpp:
+ (WebCore::HTMLEmbedElement::parseMappedAttribute):
+ * html/HTMLFrameElementBase.cpp:
+ (WebCore::HTMLFrameElementBase::parseMappedAttribute):
+ * html/HTMLImageElement.cpp:
+ (WebCore::HTMLImageElement::parseMappedAttribute):
+ * html/HTMLImageLoader.cpp:
+ (WebCore::HTMLImageLoader::sourceURI):
+ * html/HTMLLinkElement.cpp:
+ (WebCore::HTMLLinkElement::parseMappedAttribute):
+ * html/HTMLMediaElement.cpp:
+ * html/HTMLObjectElement.cpp:
+ (WebCore::HTMLObjectElement::parseMappedAttribute):
+ (WebCore::HTMLObjectElement::parametersForPlugin):
+ * html/HTMLTableElement.cpp:
+ (WebCore::HTMLTableElement::parseMappedAttribute):
+ * html/HTMLTablePartElement.cpp:
+ (WebCore::HTMLTablePartElement::parseMappedAttribute):
+ * html/parser/HTMLPreloadScanner.cpp:
+ (WebCore::HTMLNames::PreloadTask::setUrlToLoad):
+ * loader/FormSubmission.cpp:
+ (WebCore::FormSubmission::Attributes::parseAction):
+ * platform/chromium/ClipboardChromium.cpp:
+ (WebCore::ClipboardChromium::declareAndWriteDragImage):
+ * platform/chromium/PasteboardChromium.cpp:
+ (WebCore::Pasteboard::writeImage):
+ * platform/qt/ClipboardQt.cpp:
+ (WebCore::ClipboardQt::declareAndWriteDragImage):
+ * platform/win/ClipboardWin.cpp:
+ (WebCore::ClipboardWin::declareAndWriteDragImage):
+ * rendering/HitTestResult.cpp:
+ (WebCore::HitTestResult::absoluteImageURL):
+ (WebCore::HitTestResult::absoluteMediaURL):
+ (WebCore::HitTestResult::absoluteLinkURL):
+ * svg/SVGAElement.cpp:
+ (WebCore::SVGAElement::defaultEventHandler):
+ * svg/SVGImageLoader.cpp:
+ (WebCore::SVGImageLoader::sourceURI):
+ * wml/WMLAElement.cpp:
+ (WebCore::WMLAElement::defaultEventHandler):
+ * wml/WMLImageLoader.cpp:
+ (WebCore::WMLImageLoader::sourceURI):
+ Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
+
+ * WebCore.exp.in: Updated.
+
+ * Android.mk: Removed CSSHelper.cpp.
+ * CMakeLists.txt: Ditto.
+ * GNUmakefile.am: Ditto.
+ * WebCore.gypi: Ditto.
+ * WebCore.pro: Ditto.
+ * WebCore.vcproj/WebCore.vcproj: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+
+ * bindings/js/JSAttrCustom.cpp:
+ * bindings/js/JSElementCustom.cpp:
+ * bindings/v8/custom/V8ElementCustom.cpp:
+ * bindings/v8/custom/V8LocationCustom.cpp:
+ * css/CSSParser.cpp:
+ * html/HTMLMediaElement.cpp:
+ * html/HTMLVideoElement.cpp:
+ * loader/ImageLoader.cpp:
+ * rendering/style/RenderStyle.h:
+ Removed unneeded include of CSSHelper.h.
+
+2010-09-30 Alexey Marinichev <amarinichev@chromium.org>
+
+ Reviewed by Chris Marrin.
+
+ Add GetGraphicsResetStatusARB entry point from ARB_robustness
+ extension to GraphicsContext3D
+ https://bugs.webkit.org/show_bug.cgi?id=46850
+
+ Added stubs for GraphicsContext3D::getGraphicsResetStatusARB for
+ Mac and QT.
+
+ * platform/graphics/GraphicsContext3D.h:
+ * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
+ (WebCore::GraphicsContext3D::getGraphicsResetStatusARB):
+ * platform/graphics/qt/GraphicsContext3DQt.cpp:
+ (WebCore::GraphicsContext3D::getGraphicsResetStatusARB):
+
+2010-09-30 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ https://bugs.webkit.org/show_bug.cgi?id=46938
+
+ Rewrite margin collapsing to be block-flow-aware. Eliminate a bunch of the margin functions on RenderBox in favor of a single
+ master function for grabbing all the margin values for a child: marginValuesForChild on RenderBlock. Introduce a new
+ MarginValues struct to make returning the collection of 4 margin values easy.
+
+ fast/blockflow/inline-direction-positioning.html progresses to have the correct results.
+ Added fast/blockflow/margin-collapse.html
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::MarginInfo::MarginInfo):
+ (WebCore::RenderBlock::adjustPositionedBlock):
+ (WebCore::RenderBlock::collapseMargins):
+ (WebCore::RenderBlock::clearFloatsIfNeeded):
+ (WebCore::RenderBlock::setCollapsedBottomMargin):
+ (WebCore::RenderBlock::layoutBlockChild):
+ (WebCore::RenderBlock::setMaxMarginBeforeValues):
+ (WebCore::RenderBlock::setMaxMarginAfterValues):
+ (WebCore::RenderBlock::marginValuesForChild):
+ * rendering/RenderBlock.h:
+ (WebCore::RenderBlock::MarginValues::MarginValues):
+ (WebCore::RenderBlock::MarginValues::positiveMarginBefore):
+ (WebCore::RenderBlock::MarginValues::negativeMarginBefore):
+ (WebCore::RenderBlock::MarginValues::positiveMarginAfter):
+ (WebCore::RenderBlock::MarginValues::negativeMarginAfter):
+ (WebCore::RenderBlock::MarginValues::setPositiveMarginBefore):
+ (WebCore::RenderBlock::MarginValues::setNegativeMarginBefore):
+ (WebCore::RenderBlock::MarginValues::setPositiveMarginAfter):
+ (WebCore::RenderBlock::MarginValues::setNegativeMarginAfter):
+ (WebCore::RenderBlock::maxPositiveMarginBefore):
+ (WebCore::RenderBlock::maxNegativeMarginBefore):
+ (WebCore::RenderBlock::maxPositiveMarginAfter):
+ (WebCore::RenderBlock::maxNegativeMarginAfter):
+ (WebCore::RenderBlock::initMaxMarginValues):
+ (WebCore::RenderBlock::collapsedMarginBefore):
+ (WebCore::RenderBlock::collapsedMarginAfter):
+ (WebCore::RenderBlock::MarginInfo::clearMargin):
+ (WebCore::RenderBlock::MarginInfo::setPositiveMargin):
+ (WebCore::RenderBlock::MarginInfo::setNegativeMargin):
+ (WebCore::RenderBlock::MarginInfo::setPositiveMarginIfLarger):
+ (WebCore::RenderBlock::MarginInfo::setNegativeMarginIfLarger):
+ (WebCore::RenderBlock::MarginInfo::setMargin):
+ (WebCore::RenderBlock::MarginInfo::positiveMargin):
+ (WebCore::RenderBlock::MarginInfo::negativeMargin):
+ (WebCore::RenderBlock::MarginInfo::margin):
+ (WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):
+ (WebCore::RenderBlock::RenderBlockRareData::positiveMarginBeforeDefault):
+ (WebCore::RenderBlock::RenderBlockRareData::negativeMarginBeforeDefault):
+ (WebCore::RenderBlock::RenderBlockRareData::positiveMarginAfterDefault):
+ (WebCore::RenderBlock::RenderBlockRareData::negativeMarginAfterDefault):
+ * rendering/RenderBox.h:
+ (WebCore::RenderBox::collapsedMarginBefore):
+ (WebCore::RenderBox::collapsedMarginAfter):
+ * rendering/RenderFlexibleBox.cpp:
+ (WebCore::RenderFlexibleBox::layoutBlock):
+
+2010-09-30 Patrick Gansterer <paroga@webkit.org>
+
+ Reviewed by Adam Roben.
+
+ [WINCE] Fix InternetGetCookie in CookieJarWin.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=46929
+
+ If the InternetGetCookie fails the output size won't be set.
+ Set the default size to 0, so we always get the correct size
+ and check the return value of InternetGetCookie.
+
+ * platform/network/win/CookieJarWin.cpp:
+ (WebCore::cookies):
+
+2010-09-30 Patrick Gansterer <paroga@webkit.org>
+
+ Reviewed by Adam Roben.
+
+ [WINCE] Use OwnPtr for HBRUSH and HPEN in GraphicsContext
+ https://bugs.webkit.org/show_bug.cgi?id=46881
+
+ Also add some missing SelectObject calls.
+
+ * platform/graphics/wince/GraphicsContextWinCE.cpp:
+ (WebCore::createPen):
+ (WebCore::createBrush):
+ (WebCore::GraphicsContext::drawRect):
+ (WebCore::GraphicsContext::drawLine):
+ (WebCore::GraphicsContext::drawEllipse):
+ (WebCore::GraphicsContext::strokeArc):
+ (WebCore::GraphicsContext::drawConvexPolygon):
+ (WebCore::GraphicsContext::strokeRect):
+ (WebCore::GraphicsContext::fillRoundedRect):
+ (WebCore::GraphicsContext::fillPath):
+ (WebCore::GraphicsContext::strokePath):
+
+2010-09-30 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Dan Bernstein and Darin Adler.
+
+ WebCore uses the main thread to process sleep notifications
+ https://bugs.webkit.org/show_bug.cgi?id=46935
+ <rdar://problem/8495374>
+
+ Rewrite the old WebCorePowerNotifier to use IOKit directly.
+
+ On Snow Leopard, set up power notifications to arrive on a dispatch queue,
+ so that we can handle them quickly even if the main thread is hung.
+
+ (Tiger and Leopard will still get the old behavior).
+
+ * WebCore.xcodeproj/project.pbxproj:
+ Link with IOKit.
+
+ * platform/mac/SharedTimerMac.mm:
+ (WebCore::PowerObserver::PowerObserver):
+ Initialize the IOKit machinery.
+
+ (WebCore::PowerObserver::~PowerObserver):
+ Tear down the IOKit notifications.
+
+ (WebCore::PowerObserver::didReceiveSystemPowerNotification):
+ Acknowledge the event immediately and then call the shared timer functions. On Snow Leopard, we
+ make sure to call the shared timer functions on the main thread.
+
+2010-09-30 James Simonsen <simonjam@chromium.org>
+
+ Reviewed by Adam Barth.
+
+ [Web Timing] Make requestEnd equal to start of response
+ https://bugs.webkit.org/show_bug.cgi?id=46302
+
+ * page/Timing.cpp:
+ (WebCore::Timing::requestEnd):
+
+2010-09-30 Zhenyao Mo <zmo@google.com>
+
+ Reviewed by Kenneth Russell.
+
+ fast/canvas/webgl/draw-elements-out-of-bounds.html is crashing on Snow Leopard
+ https://bugs.webkit.org/show_bug.cgi?id=46870
+
+ * platform/graphics/ANGLEWebKitBridge.cpp:
+ (WebCore::ANGLEWebKitBridge::~ANGLEWebKitBridge): Remove ShFinalize().
+
+2010-09-30 Ryosuke Niwa <rniwa@webkit.org>
+
+ Reviewed by Tony Chang.
+
+ WebKit nests font element when applying different font styles
+ https://bugs.webkit.org/show_bug.cgi?id=45568
+
+ The bug was caused by fixRangeAndApplyInlineStyle's not including fully selected ancestors,
+ and addInlineStyleIfNeeded's always surrounding the contents by new elements as supposed to
+ adding font attributes or style attribute.
+
+ Fixed the bug by extending the node range in fixRangeAndApplyInlineStyle and finding
+ the appropriate container node to add attributes in addInlineStyleIfNeeded.
+ addInlineStyleIfNeeded now tires to add font and style attributes to the inner most font and
+ span elements respectively.
+
+ Also added an early exit check to removeStyleFromRunBeforeApplyingStyle so that WebKit does not
+ modify the contents when the entire contents already have the desired style.
+
+ Test: editing/style/inline-style-container.html
+
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle):
+ (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle):
+ (WebCore::ApplyStyleCommand::removeInlineStyleFromElement):
+ (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
+
+2010-09-30 Jarred Nicholls <jarred@sencha.com>
+
+ Reviewed by Darin Adler.
+
+ Removed unnecessary calls to ceil() on an int
+ Removing the call fixes MSVC build errors
+ https://bugs.webkit.org/show_bug.cgi?id=46931
+
+ * platform/graphics/ContextShadow.cpp:
+ (WebCore::ContextShadow::calculateLayerBoundingRect):
+
+2010-09-30 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ https://bugs.webkit.org/show_bug.cgi?id=46932
+
+ Get fast/blockflow/root-lr-basic.html results to be correct by patching a few more
+ height() calls to be logicalHeight().
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::collapseMargins):
+ (WebCore::RenderBlock::handleAfterSideOfBlock):
+
+2010-09-30 Cris Neckar <cdn@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Added check to test for removed counter node when calling findPlaceForCounter() in updateCounters().
+ Added refcounting to counternodes in countermaps.
+ https://bugs.webkit.org/show_bug.cgi?id=46387
+
+ Test: fast/css/counters/counter-traverse-table-cell.html
+
+ * rendering/CounterNode.cpp:
+ (WebCore::CounterNode::create):
+ * rendering/CounterNode.h:
+ * rendering/RenderCounter.cpp:
+ (WebCore::makeCounterNode):
+ (WebCore::destroyCounterNodeWithoutMapRemoval):
+ (WebCore::RenderCounter::destroyCounterNodes):
+ (WebCore::RenderCounter::destroyCounterNode):
+ (WebCore::updateCounters):
+
+2010-09-30 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ https://bugs.webkit.org/show_bug.cgi?id=46928
+
+ Add isLeftToRightDirection() to RenderStyle and change callers that did direction() == LTR and direction() == RTL to use this instead.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::isLeftPage):
+ (WebCore::CSSStyleSelector::applyProperty):
+ * editing/Editor.cpp:
+ (WebCore::Editor::hasBidiSelection):
+ * editing/VisiblePosition.cpp:
+ (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
+ (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
+ * html/canvas/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::drawTextInternal):
+ * rendering/InlineBox.h:
+ (WebCore::InlineBox::isLeftToRightDirection):
+ (WebCore::InlineBox::caretLeftmostOffset):
+ (WebCore::InlineBox::caretRightmostOffset):
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
+ (WebCore::InlineFlowBox::placeBoxesInInlineDirection):
+ (WebCore::InlineFlowBox::paintTextDecorations):
+ * rendering/InlineIterator.h:
+ (WebCore::InlineIterator::direction):
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::selectionRect):
+ (WebCore::InlineTextBox::placeEllipsisBox):
+ (WebCore::InlineTextBox::paint):
+ (WebCore::InlineTextBox::paintSelection):
+ (WebCore::InlineTextBox::paintCompositionBackground):
+ (WebCore::InlineTextBox::paintDecoration):
+ (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
+ (WebCore::InlineTextBox::paintTextMatchMarker):
+ (WebCore::InlineTextBox::computeRectForReplacementMarker):
+ (WebCore::InlineTextBox::textPos):
+ (WebCore::InlineTextBox::offsetForPosition):
+ (WebCore::InlineTextBox::positionForOffset):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::adjustPositionedBlock):
+ (WebCore::RenderBlock::determineLogicalLeftPositionForChild):
+ (WebCore::RenderBlock::paintColumnRules):
+ (WebCore::RenderBlock::paintColumnContents):
+ (WebCore::RenderBlock::getHorizontalSelectionGapInfo):
+ (WebCore::RenderBlock::logicalLeftOffsetForLine):
+ (WebCore::RenderBlock::logicalRightOffsetForLine):
+ (WebCore::RenderBlock::rightmostPosition):
+ (WebCore::RenderBlock::leftmostPosition):
+ (WebCore::RenderBlock::columnRectAt):
+ (WebCore::RenderBlock::layoutColumns):
+ (WebCore::getBorderPaddingMargin):
+ (WebCore::RenderBlock::localCaretRect):
+ (WebCore::RenderBlock::marginStartForChild):
+ (WebCore::RenderBlock::marginEndForChild):
+ (WebCore::RenderBlock::setMarginStartForChild):
+ (WebCore::RenderBlock::setMarginEndForChild):
+ * rendering/RenderBlockLineLayout.cpp:
+ (WebCore::getBorderPaddingMargin):
+ (WebCore::RenderBlock::constructLine):
+ (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
+ (WebCore::RenderBlock::determineStartPosition):
+ (WebCore::RenderBlock::skipTrailingWhitespace):
+ (WebCore::RenderBlock::skipLeadingWhitespace):
+ (WebCore::RenderBlock::findNextLineBreak):
+ (WebCore::RenderBlock::checkLinesForTextOverflow):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::marginStart):
+ (WebCore::RenderBox::marginEnd):
+ (WebCore::RenderBox::setMarginStart):
+ (WebCore::RenderBox::setMarginEnd):
+ (WebCore::RenderBox::scrollWidth):
+ (WebCore::RenderBox::computeInlineDirectionMargins):
+ (WebCore::RenderBox::containingBlockWidthForPositioned):
+ (WebCore::RenderBox::computePositionedLogicalWidthUsing):
+ (WebCore::RenderBox::computePositionedLogicalWidthReplaced):
+ (WebCore::RenderBox::localCaretRect):
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::relativePositionOffsetX):
+ * rendering/RenderFieldset.cpp:
+ (WebCore::RenderFieldset::layoutLegend):
+ * rendering/RenderFileUploadControl.cpp:
+ (WebCore::RenderFileUploadControl::paintObject):
+ * rendering/RenderFlexibleBox.cpp:
+ (WebCore::FlexBoxIterator::FlexBoxIterator):
+ (WebCore::RenderFlexibleBox::layoutHorizontalBox):
+ (WebCore::RenderFlexibleBox::layoutVerticalBox):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::computeScrollDimensions):
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::paintItemForeground):
+ * rendering/RenderListItem.cpp:
+ (WebCore::RenderListItem::positionListMarker):
+ (WebCore::RenderListItem::markerTextWithSuffix):
+ * rendering/RenderListMarker.cpp:
+ (WebCore::RenderListMarker::paint):
+ (WebCore::RenderListMarker::updateMargins):
+ (WebCore::RenderListMarker::suffix):
+ * rendering/RenderMarquee.cpp:
+ (WebCore::RenderMarquee::computePosition):
+ * rendering/RenderMeter.cpp:
+ (WebCore::RenderMeter::valuePartRect):
+ * rendering/RenderProgress.cpp:
+ (WebCore::RenderProgress::valuePartRect):
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::calcBorderLeft):
+ (WebCore::RenderTable::calcBorderRight):
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::clippedOverflowRectForRepaint):
+ (WebCore::RenderTableCell::borderHalfLeft):
+ (WebCore::RenderTableCell::borderHalfRight):
+ (WebCore::RenderTableCell::collectBorderStyles):
+ (WebCore::RenderTableCell::paintCollapsedBorder):
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::layoutRows):
+ (WebCore::RenderTableSection::recalcOuterBorder):
+ (WebCore::RenderTableSection::paintObject):
+ (WebCore::RenderTableSection::nodeAtPoint):
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::localCaretRect):
+ (WebCore::RenderText::positionLineBox):
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::forwardEvent):
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::levelIndicatorFor):
+ (WebCore::RenderThemeMac::paintProgressBar):
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::writeTextRun):
+ * rendering/SVGInlineTextBox.cpp:
+ (WebCore::SVGInlineTextBox::measureCharacter):
+ (WebCore::SVGInlineTextBox::buildLayoutInformation):
+ * rendering/SVGRenderTreeAsText.cpp:
+ (WebCore::writeSVGInlineTextBox):
+ * rendering/SVGTextLayoutUtilities.cpp:
+ (WebCore::svgTextRunForInlineTextBox):
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::borderStartWidth):
+ (WebCore::RenderStyle::borderEndWidth):
+ (WebCore::RenderStyle::marginStart):
+ (WebCore::RenderStyle::marginEnd):
+ (WebCore::RenderStyle::marginStartUsing):
+ (WebCore::RenderStyle::marginEndUsing):
+ (WebCore::RenderStyle::paddingStart):
+ (WebCore::RenderStyle::paddingEnd):
+ * rendering/style/RenderStyle.h:
+ (WebCore::InheritedFlags::isLeftToRightDirection):
+ * wml/WMLTableElement.cpp:
+ (WebCore::WMLTableElement::alignCells):
+
+2010-09-30 David Hyatt <hyatt@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=46923
+
+ Make determineLogicalLeftPositionForChild block-flow-aware. Rewrite the function so that there aren't
+ completely separate LTR/RTL cases.
+
+ Added fast/blockflow/inline-direction-positioning.html
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::determineLogicalLeftPositionForChild):
+ (WebCore::RenderBlock::setLogicalLeftForChild):
+ * rendering/RenderBlock.h:
+ (WebCore::RenderBlock::logicalWidthForChild):
+ (WebCore::RenderBlock::logicalRightOffsetForContent):
+ (WebCore::RenderBlock::logicalLeftOffsetForContent):
+
+2010-09-29 Adam Roben <aroben@apple.com>
+
+ Fix color media queries on Windows
+
+ Fixes <http://webkit.org/b/42973> <rdar://problem/8234072> (color:8)
+ media query does not evaluate to true for 32bpp displays on Windows
+
+ Test: fast/media/color-does-not-include-alpha.html
+
+ Reviewed by Darin Adler.
+
+ * platform/win/PlatformScreenWin.cpp:
+ (WebCore::screenDepthPerComponent): Use screenDepth instead of trying
+ to interpret DEVMODE directly, since screenDepth knows how to correct
+ for video drivers that return 32 instead of 24.
+
+2010-09-29 Adam Roben <aroben@apple.com>
+
+ Make sure screen.colorDepth/screen.pixelDepth don't include the bits
+ used for alpha
+
+ Fixes <http://webkit.org/b/42972> <rdar://problem/8234071>
+ screen.colorDepth and screen.pixelDepth return 32 on Windows, but
+ should return 24 (according to CSSOM View and Firefox)
+
+ Reviewed by Darin Adler.
+
+ * platform/win/PlatformScreenWin.cpp:
+ (WebCore::screenDepth): If Windows says there are 32 bits per pixel,
+ return 24 instead, as 32 includes the alpha component but this
+ function is supposed to ignore the alpha component.
+
+2010-09-30 Daniel Cheng <dcheng@chromium.org>
+
+ Reviewed by Tony Chang.
+
+ [chromium] Refactor ChromiumDataObject to use getters/setters.
+ https://bugs.webkit.org/show_bug.cgi?id=46559
+
+ This is an intermediate step to converting ChromiumDataObject to use
+ callbacks to the browser to retrieve data.
+
+ This is covered by existing tests.
+
+ * editing/chromium/EditorChromium.cpp:
+ (WebCore::Editor::newGeneralClipboard):
+ * page/chromium/EventHandlerChromium.cpp:
+ (WebCore::EventHandler::createDraggingClipboard):
+ * platform/chromium/ChromiumDataObject.cpp:
+ (WebCore::ChromiumDataObject::clearData):
+ (WebCore::ChromiumDataObject::clearAll):
+ (WebCore::ChromiumDataObject::clearAllExceptFiles):
+ (WebCore::ChromiumDataObject::hasData):
+ (WebCore::ChromiumDataObject::types):
+ (WebCore::ChromiumDataObject::getData):
+ (WebCore::ChromiumDataObject::setData):
+ (WebCore::ChromiumDataObject::ChromiumDataObject):
+ * platform/chromium/ChromiumDataObject.h:
+ (WebCore::ChromiumDataObject::create):
+ (WebCore::ChromiumDataObject::urlTitle):
+ (WebCore::ChromiumDataObject::setUrlTitle):
+ (WebCore::ChromiumDataObject::htmlBaseUrl):
+ (WebCore::ChromiumDataObject::setHtmlBaseUrl):
+ (WebCore::ChromiumDataObject::containsFilenames):
+ (WebCore::ChromiumDataObject::filenames):
+ (WebCore::ChromiumDataObject::setFilenames):
+ (WebCore::ChromiumDataObject::fileExtension):
+ (WebCore::ChromiumDataObject::setFileExtension):
+ (WebCore::ChromiumDataObject::fileContentFilename):
+ (WebCore::ChromiumDataObject::setFileContentFilename):
+ (WebCore::ChromiumDataObject::fileContent):
+ (WebCore::ChromiumDataObject::setFileContent):
+ * platform/chromium/ClipboardChromium.cpp:
+ (WebCore::normalizeType):
+ (WebCore::ClipboardChromium::clearData):
+ (WebCore::ClipboardChromium::clearAllData):
+ (WebCore::ClipboardChromium::getData):
+ (WebCore::ClipboardChromium::setData):
+ (WebCore::ClipboardChromium::types):
+ (WebCore::ClipboardChromium::files):
+ (WebCore::writeImageToDataObject):
+ (WebCore::ClipboardChromium::declareAndWriteDragImage):
+ (WebCore::ClipboardChromium::writeURL):
+ (WebCore::ClipboardChromium::writeRange):
+ (WebCore::ClipboardChromium::writePlainText):
+ * platform/chromium/ClipboardChromiumWin.cpp:
+ (WebCore::ClipboardChromium::validateFileName):
+ * platform/chromium/ClipboardMimeTypes.cpp:
+ * platform/chromium/ClipboardMimeTypes.h:
+ * platform/chromium/DragDataChromium.cpp:
+ (WebCore::containsHTML):
+ (WebCore::DragData::containsURL):
+ (WebCore::DragData::asURL):
+ (WebCore::DragData::containsFiles):
+ (WebCore::DragData::asFilenames):
+ (WebCore::DragData::containsPlainText):
+ (WebCore::DragData::asPlainText):
+ (WebCore::DragData::canSmartReplace):
+ (WebCore::DragData::asFragment):
+ * platform/chromium/ReadableDataObject.cpp:
+ (WebCore::ReadableDataObject::getURL):
+ (WebCore::ReadableDataObject::getHTML):
+ * platform/chromium/WritableDataObject.cpp:
+ (WebCore::WritableDataObject::clearData):
+ (WebCore::WritableDataObject::setData):
+ (WebCore::WritableDataObject::setURL):
+ (WebCore::WritableDataObject::setHTML):
+
+2010-09-30 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ Make 2D accelerated canvas rendering build on Mac
+ https://bugs.webkit.org/show_bug.cgi?id=46007
+
+ Add accelerated 2D rendering files to Mac build, fix build errors,
+ add ifdefs to compile only when the ACCELERATED_2D_CANVAS flag is
+ enabled, and add a skeleton of the mac specific file so it builds.
+
+ DrawingBufferMac.mm, the Mac specific file does nothing right now
+ other than initialize and create a layer. The rest will be added
+ when I do the actual implementation.
+
+ The most significant change was to SharedGraphicsContext3D, which
+ had a static local OwnPtr in one of the methods. This was causing
+ the exit time destructor warning. Getting rid of the OwnPtr fixed
+ the problem. Since the pointer that was being wrapped was to a
+ static object that would never get destroyed, the OwnPtr was not
+ necessary.
+
+ I also added the ACCELERATED_2D_CANVAS flag to build-webkit
+ and FeatureDefines.xcconfig for WebCore, WebKit and JavaScriptCore.
+ But right now the flag is off by default.
+
+ * Configurations/FeatureDefines.xcconfig:
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/graphics/gpu/DrawingBuffer.cpp:
+ * platform/graphics/gpu/DrawingBuffer.h:
+ (WebCore::DrawingBuffer::WillPublishCallback::~WillPublishCallback):
+ * platform/graphics/gpu/LoopBlinnClassifier.cpp:
+ * platform/graphics/gpu/LoopBlinnMathUtils.cpp:
+ * platform/graphics/gpu/LoopBlinnTextureCoords.cpp:
+ * platform/graphics/gpu/Shader.cpp:
+ * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
+ (WebCore::SharedGraphicsContext3D::allContexts):
+ * platform/graphics/gpu/SolidFillShader.cpp:
+ * platform/graphics/gpu/TexShader.cpp:
+ * platform/graphics/gpu/Texture.cpp:
+ * platform/graphics/gpu/Texture.h:
+ * platform/graphics/gpu/TilingData.cpp:
+ * platform/graphics/gpu/mac: Added.
+ * platform/graphics/gpu/mac/DrawingBufferMac.mm: Added.
+ (WebCore::DrawingBuffer::DrawingBuffer):
+ (WebCore::DrawingBuffer::~DrawingBuffer):
+ (WebCore::DrawingBuffer::reset):
+ (WebCore::DrawingBuffer::platformLayer):
+
+2010-09-30 Renata Hodovan <reni@inf.u-szeged.hu>
+
+ Reviewed by Dirk Schulze.
+
+ SVGFECompositeElement doesn't support dynamic invalidation, when attributes change.
+ https://bugs.webkit.org/show_bug.cgi?id=46902
+
+ Tests: svg/dynamic-updates/SVGFECompositeElement-dom-in-attr.html
+ svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr.html
+ svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr.html
+ svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr.html
+ svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr.html
+ svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr.html
+ svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr.html
+ svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop.html
+ svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop.html
+ svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop.html
+ svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop.html
+ svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop.html
+ svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop.html
+ svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop.html
+
+ * svg/SVGFECompositeElement.cpp:
+ (WebCore::SVGFECompositeElement::svgAttributeChanged):
+ * svg/SVGFECompositeElement.h:
+
+2010-09-29 Jeremy Orlow <jorlow@chromium.org>
+
+ Reviewed by Steve Block.
+
+ Finished IDBTransaction for IndexedDB
+ https://bugs.webkit.org/show_bug.cgi?id=46823
+
+ Switch the rest of IndexedDB to use transactions.
+ Implement most of setVersion.
+ Add IDBTransactions to IDBAny, IDBCursor, IDBRequest, etc.
+ Switch to using the standard cross thread task stuff.
+ Make everything threadsafe so it works with cross thread copy
+ (will be useful in the future).
+ Fix some subtle bugs in transactions.
+
+ Various bits of clean up (when I couldn't resist).
+
+ * bindings/js/JSIDBAnyCustom.cpp:
+ (WebCore::toJS):
+ * bindings/v8/IDBBindingUtilities.cpp:
+ (WebCore::LocalContext::LocalContext):
+ (WebCore::LocalContext::~LocalContext):
+ (WebCore::createIDBKeyFromSerializedValueAndKeyPath):
+ * bindings/v8/SerializedScriptValue.cpp:
+ (WebCore::SerializedScriptValue::release):
+ (WebCore::SerializedScriptValue::SerializedScriptValue):
+ * bindings/v8/SerializedScriptValue.h:
+ * bindings/v8/custom/V8IDBAnyCustom.cpp:
+ (WebCore::toV8):
+ * platform/CrossThreadCopier.cpp:
+ * storage/IDBAny.cpp:
+ (WebCore::IDBAny::idbFactory):
+ (WebCore::IDBAny::idbTransaction):
+ (WebCore::IDBAny::set):
+ * storage/IDBAny.h:
+ * storage/IDBCallbacks.h:
+ * storage/IDBCursor.cpp:
+ (WebCore::IDBCursor::IDBCursor):
+ (WebCore::IDBCursor::update):
+ (WebCore::IDBCursor::continueFunction):
+ (WebCore::IDBCursor::remove):
+ * storage/IDBCursor.h:
+ (WebCore::IDBCursor::create):
+ * storage/IDBCursorBackendImpl.cpp:
+ (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
+ (WebCore::IDBCursorBackendImpl::update):
+ (WebCore::IDBCursorBackendImpl::updateInternal):
+ (WebCore::IDBCursorBackendImpl::continueFunction):
+ (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
+ (WebCore::IDBCursorBackendImpl::remove):
+ (WebCore::IDBCursorBackendImpl::removeInternal):
+ * storage/IDBCursorBackendImpl.h:
+ (WebCore::IDBCursorBackendImpl::create):
+ * storage/IDBDatabase.cpp:
+ (WebCore::IDBDatabase::setSetVersionTransaction):
+ (WebCore::IDBDatabase::createObjectStore):
+ (WebCore::IDBDatabase::removeObjectStore):
+ (WebCore::IDBDatabase::setVersion):
+ (WebCore::IDBDatabase::close):
+ * storage/IDBDatabase.h:
+ * storage/IDBDatabase.idl:
+ * storage/IDBDatabaseBackendImpl.cpp:
+ (WebCore::IDBDatabaseBackendImpl::createObjectStore):
+ (WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
+ (WebCore::IDBDatabaseBackendImpl::removeObjectStore):
+ (WebCore::IDBDatabaseBackendImpl::removeObjectStoreInternal):
+ (WebCore::IDBDatabaseBackendImpl::setVersion):
+ (WebCore::IDBDatabaseBackendImpl::setVersionInternal):
+ (WebCore::IDBDatabaseBackendImpl::close):
+ * storage/IDBDatabaseBackendImpl.h:
+ * storage/IDBDatabaseBackendInterface.h:
+ * storage/IDBFactory.cpp:
+ (WebCore::IDBFactory::open):
+ * storage/IDBIndex.cpp:
+ (WebCore::IDBIndex::IDBIndex):
+ (WebCore::IDBIndex::openObjectCursor):
+ (WebCore::IDBIndex::openCursor):
+ (WebCore::IDBIndex::getObject):
+ (WebCore::IDBIndex::get):
+ * storage/IDBIndex.h:
+ (WebCore::IDBIndex::create):
+ * storage/IDBIndexBackendImpl.cpp:
+ (WebCore::IDBIndexBackendImpl::openCursorInternal):
+ (WebCore::IDBIndexBackendImpl::openObjectCursor):
+ (WebCore::IDBIndexBackendImpl::openCursor):
+ (WebCore::IDBIndexBackendImpl::getInternal):
+ (WebCore::IDBIndexBackendImpl::getObject):
+ (WebCore::IDBIndexBackendImpl::get):
+ * storage/IDBIndexBackendImpl.h:
+ * storage/IDBIndexBackendInterface.h:
+ * storage/IDBKey.cpp:
+ (WebCore::IDBKey::IDBKey):
+ * storage/IDBKey.h:
+ * storage/IDBKeyRange.h:
+ * storage/IDBObjectStore.cpp:
+ (WebCore::IDBObjectStore::IDBObjectStore):
+ (WebCore::IDBObjectStore::add):
+ (WebCore::IDBObjectStore::put):
+ (WebCore::IDBObjectStore::remove):
+ (WebCore::IDBObjectStore::createIndex):
+ (WebCore::IDBObjectStore::index):
+ (WebCore::IDBObjectStore::removeIndex):
+ (WebCore::IDBObjectStore::openCursor):
+ * storage/IDBObjectStore.idl:
+ * storage/IDBObjectStoreBackendImpl.cpp:
+ (WebCore::IDBObjectStoreBackendImpl::get):
+ (WebCore::IDBObjectStoreBackendImpl::getInternal):
+ (WebCore::IDBObjectStoreBackendImpl::put):
+ (WebCore::IDBObjectStoreBackendImpl::putInternal):
+ (WebCore::IDBObjectStoreBackendImpl::remove):
+ (WebCore::IDBObjectStoreBackendImpl::removeInternal):
+ (WebCore::IDBObjectStoreBackendImpl::createIndex):
+ (WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
+ (WebCore::IDBObjectStoreBackendImpl::removeIndex):
+ (WebCore::IDBObjectStoreBackendImpl::removeIndexInternal):
+ (WebCore::IDBObjectStoreBackendImpl::openCursor):
+ (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
+ * storage/IDBObjectStoreBackendImpl.h:
+ * storage/IDBObjectStoreBackendInterface.h:
+ * storage/IDBRequest.cpp:
+ (WebCore::IDBRequest::IDBRequest):
+ (WebCore::IDBRequest::resetReadyState):
+ (WebCore::IDBRequest::onSuccess):
+ (WebCore::IDBRequest::timerFired):
+ * storage/IDBRequest.h:
+ (WebCore::IDBRequest::create):
+ * storage/IDBTransactionBackendImpl.cpp:
+ (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
+ (WebCore::IDBTransactionBackendImpl::scheduleTask):
+ (WebCore::IDBTransactionBackendImpl::didCompleteTaskEvents):
+ (WebCore::IDBTransactionBackendImpl::run):
+ (WebCore::IDBTransactionBackendImpl::start):
+ (WebCore::IDBTransactionBackendImpl::commit):
+ (WebCore::IDBTransactionBackendImpl::timerFired):
+ * storage/IDBTransactionBackendImpl.h:
+
+2010-09-30 Csaba Osztrogonác <ossy@webkit.org>
+
+ Reviewed by Martin Robinson.
+
+ [Gtk] build still broken since r68521
+ https://bugs.webkit.org/show_bug.cgi?id=46795
+
+ makevalues.pl and makeprop.pl generate 3 files in one run.
+ Double or triple target is incorrect, because on a multicore
+ machine make processes targets in parallel.
+
+ Setting a->b->c dependencies for 3 generated files guarantees
+ that make doesn't execute the recipe of the rule more than one.
+
+ * GNUmakefile.am: Dependencies and missing headers added.
+
+2010-09-30 Andrey Kosyakov <caseq@chromium.org>
+
+ Unreviewed build fix (marked ResourceRawHeaders.h as private)
+
+ * WebCore.xcodeproj/project.pbxproj:
+
+2010-09-29 Andrey Kosyakov <caseq@chromium.org>
+
+ Reviewed by Pavel Feldman.
+
+ Web Inspector: display headers actually used by network stack in Resources tab
+ https://bugs.webkit.org/show_bug.cgi?id=46092
+
+ * GNUmakefile.am:
+ * WebCore.gypi:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::willSendRequest): enable raw headers reporting if front-end is visible.
+ * inspector/InspectorResource.cpp:
+ (WebCore::InspectorResource::updateResponse):
+ * platform/network/ResourceRawHeaders.h: Added.
+ * platform/network/ResourceRequestBase.h: Added flag to enable raw headers reporting.
+ (WebCore::ResourceRequestBase::reportRawHeaders):
+ (WebCore::ResourceRequestBase::setReportRawHeaders):
+ (WebCore::ResourceRequestBase::ResourceRequestBase):
+ * platform/network/ResourceResponseBase.cpp: Added support for raw headers.
+ (WebCore::ResourceResponseBase::resourceRawHeaders):
+ (WebCore::ResourceResponseBase::setResourceRawHeaders):
+ * platform/network/ResourceResponseBase.h:
+
+2010-09-29 Andrey Kosyakov <caseq@chromium.org>
+
+ Reviewed by Pavel Feldman.
+
+ Web Inspector: display headers actually used by network stack in Resources tab
+ https://bugs.webkit.org/show_bug.cgi?id=46092
+
+ * GNUmakefile.am:
+ * WebCore.gypi:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::willSendRequest): enable raw headers reporting if front-end is visible.
+ * inspector/InspectorResource.cpp:
+ (WebCore::InspectorResource::updateResponse):
+ * platform/network/ResourceRawHeaders.h: Added.
+ * platform/network/ResourceRequestBase.h: Added flag to enable raw headers reporting.
+ (WebCore::ResourceRequestBase::reportRawHeaders):
+ (WebCore::ResourceRequestBase::setReportRawHeaders):
+ (WebCore::ResourceRequestBase::ResourceRequestBase):
+ * platform/network/ResourceResponseBase.cpp: Added support for raw headers.
+ (WebCore::ResourceResponseBase::resourceRawHeaders):
+ (WebCore::ResourceResponseBase::setResourceRawHeaders):
+ * platform/network/ResourceResponseBase.h:
+
+2010-09-30 Andreas Kling <andreas.kling@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ [Qt] V8 port: Unbreak build
+
+ Add missing <wtf/text/CString.h> include.
+
+ * loader/PingLoader.cpp:
+
+2010-09-29 Ilya Tikhonovsky <loislo@chromium.org>
+
+ Reviewed by Pavel Feldman.
+
+ Web Inspector: assign the resource loading finish time which was obtained from the network stack
+ as the end time for the corresponding event in Timeline.
+ See related change for Resources panel https://bugs.webkit.org/show_bug.cgi?id=45664
+
+ https://bugs.webkit.org/show_bug.cgi?id=46789
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::didFinishLoading):
+ (WebCore::InspectorController::didFailLoading):
+ * inspector/InspectorTimelineAgent.cpp:
+ (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
+ * inspector/InspectorTimelineAgent.h:
+
+2010-09-29 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Web Inspector: implement sorting by timeline in network panel + filtering.
+ https://bugs.webkit.org/show_bug.cgi?id=45657
+
+ A number of drive-by fixes, sorting by timeline added,
+ 0-based timeline for duration added, filters added,
+ more love for detailed view + nice headers.
+
+ * English.lproj/localizedStrings.js:
+ * inspector/front-end/DataGrid.js:
+ (WebInspector.DataGrid):
+ (WebInspector.DataGrid.prototype.markColumnAsSortedBy):
+ (WebInspector.DataGrid.prototype.headerTableHeader):
+ * inspector/front-end/NetworkPanel.js:
+ (WebInspector.NetworkPanel):
+ (WebInspector.NetworkPanel.prototype.get statusBarItems):
+ (WebInspector.NetworkPanel.prototype._createTable):
+ (WebInspector.NetworkPanel.prototype._makeHeaderInnerHTML):
+ (WebInspector.NetworkPanel.prototype._createSortingFunctions):
+ (WebInspector.NetworkPanel.prototype._sortByTimeline):
+ (WebInspector.NetworkPanel.prototype._sortItems):
+ (WebInspector.NetworkPanel.prototype._createFilterPanel):
+ (WebInspector.NetworkPanel.prototype._showCategory):
+ (WebInspector.NetworkPanel.prototype._hideCategory):
+ (WebInspector.NetworkPanel.prototype._updateFilter):
+ (WebInspector.NetworkPanel.prototype._filter):
+ (WebInspector.NetworkPanel.prototype._updateDividersIfNeeded):
+ (WebInspector.NetworkPanel.prototype.reset):
+ (WebInspector.NetworkPanel.prototype._setLargerResources):
+ (WebInspector.NetworkDataGridNode.prototype.createCells):
+ (WebInspector.NetworkDataGridNode.prototype._createDivInTD):
+ (WebInspector.NetworkDataGridNode.prototype._refreshURLCell):
+ (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
+ (WebInspector.NetworkDataGridNode.prototype._appendSubtitle):
+ (WebInspector.NetworkDataGridNode.SizeComparator):
+ (WebInspector.NetworkDataGridNode.ResourcePropertyComparator):
+ * inspector/front-end/ProfilesPanel.js:
+ (WebInspector.ProfilesPanel):
+ (WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
+ * inspector/front-end/StoragePanel.js:
+ (WebInspector.StoragePanel):
+ * inspector/front-end/TimelineGrid.js:
+ (WebInspector.TimelineGrid.prototype.updateDividers):
+ * inspector/front-end/TimelineOverviewPane.js:
+ (WebInspector.TimelineOverviewPane):
+ (WebInspector.TimelineOverviewPane.prototype.updateMainViewWidth):
+ * inspector/front-end/inspector.css:
+ (.data-grid th.sort-ascending > div::after):
+ (.data-grid th.sort-descending > div::after):
+ (.status-bar-items):
+ * inspector/front-end/networkPanel.css:
+ (.network.panel .data-grid td):
+ (.network.panel .data-grid th):
+ (.network.panel .data-grid.small th):
+ (.network.panel .data-grid .data-container):
+ (.network.panel .data-grid.small .data-container):
+ (.network.panel .data-grid select):
+ (.network.panel .data-grid td.time-column):
+ (.network-cell-subtitle):
+ (.network-header-subtitle):
+ (.network-event-divider):
+ (.network.panel .network-timeline-grid.small .network-event-divider):
+ (.network.panel .resources-dividers-label-bar):
+ (.network.panel .network-timeline-grid.small .resources-dividers-label-bar):
+ (.network.panel .resources-divider-label):
+ (.network.panel .resources-dividers-label-bar .resources-divider):
+ (.network.panel .network-timeline-grid.small .resources-dividers-label-bar .resources-divider):
+ (.network.panel .resources-divider.first .resources-divider-label):
+ (.network.panel .resources-dividers-label-bar .resources-divider.first):
+ (#network-filter):
+ (.data-grid table.data tr.revealed.network-category-websockets, .data-grid table.data tr.revealed.network-category-other):
+ (.data-grid.filter-all table.data tr.revealed.network-category-other, .data-grid.filter-other table.data tr.revealed.network-category-other):
+
+2010-09-30 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Ensure we always report a valid size for the video
+
+ Some QtMultimedia-backends require a paint before even giving us
+ a size, so we start out by using the default video size, and then
+ update it once QtMultimedia starts feeding us valid sizes.
+
+ * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
+ (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
+ (WebCore::MediaPlayerPrivateQt::nativeSizeChanged):
+ (WebCore::MediaPlayerPrivateQt::setSize):
+ (WebCore::MediaPlayerPrivateQt::naturalSize):
+ * platform/graphics/qt/MediaPlayerPrivateQt.h:
+
+2010-09-30 Nikolas Zimmermann <nzimmermann@rim.com>
+
+ Reviewed by Andreas Kling.
+
+ RenderSVGTextPath lacks isSVGTextPath() method
+ https://bugs.webkit.org/show_bug.cgi?id=46888
+
+ Make RenderSVGTextPath objects easily detectable, using a isSVGTextPath() method, like all other SVG renderers have.
+
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::isSVGTextPath): Return false.
+ * rendering/RenderSVGTextPath.h: Changed indentation of whole file.
+ (WebCore::RenderSVGTextPath::isSVGTextPath): Return true.
+ (WebCore::RenderSVGTextPath::renderName):
+ (WebCore::toRenderSVGTextPath): Add helper casting methods.
+
+2010-09-30 Nikolas Zimmermann <nzimmermann@rim.com>
+
+ Reviewed by Dirk Schulze.
+
+ AffineTransform should expose methods calculating the x/y scale factors
+ https://bugs.webkit.org/show_bug.cgi?id=46887
+
+ Expose methods calculating the x/y scale factors for an AffineTransform.
+
+ * platform/graphics/transforms/AffineTransform.cpp:
+ (WebCore::affineTransformDecompose): Move xScale / yScale calculations in their own functions.
+ (WebCore::AffineTransform::xScale):
+ (WebCore::AffineTransform::yScale):
+ * platform/graphics/transforms/AffineTransform.h:
+
+2010-09-30 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Ensure that the media player backend does not leave any resources around
+
+ * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
+ (WebCore::MediaPlayerPrivateQt::~MediaPlayerPrivateQt):
+
+2010-09-30 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Minor cleanup of MediaPlayerPrivateQt
+
+ * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
+ (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
+ (WebCore::MediaPlayerPrivateQt::currentTime):
+ (WebCore::MediaPlayerPrivateQt::positionChanged):
+ (WebCore::MediaPlayerPrivateQt::paint):
+
+2010-09-30 Jochen Eisinger <jochen@chromium.org>
+
+ Reviewed by Jeremy Orlow.
+
+ Mark unused parameters as such.
+ https://bugs.webkit.org/show_bug.cgi?id=46880
+
+ * inspector/InspectorDOMAgent.cpp:
+ * page/Geolocation.cpp:
+ (WebCore::Geolocation::clearWatch):
+
+2010-09-29 Pavel Podivilov <podivilov@chromium.org>
+
+ Reviewed by Pavel Feldman.
+
+ Web Inspector: extract Inspector Instrumentation API as a class.
+ https://bugs.webkit.org/show_bug.cgi?id=46614
+
+ * CMakeLists.txt:
+ * GNUmakefile.am:
+ * WebCore.gypi:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ (WebCore::JSXMLHttpRequest::send):
+ * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
+ (WebCore::V8XMLHttpRequest::sendCallback):
+ * dom/CharacterData.cpp:
+ (WebCore::CharacterData::dispatchModifiedEvent):
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::insertBefore):
+ (WebCore::ContainerNode::parserInsertBefore):
+ (WebCore::ContainerNode::replaceChild):
+ (WebCore::ContainerNode::appendChild):
+ (WebCore::ContainerNode::parserAddChild):
+ (WebCore::notifyChildInserted):
+ (WebCore::dispatchChildRemovalEvents):
+ * dom/Element.cpp:
+ (WebCore::Element::setAttribute):
+ (WebCore::Element::removeAttribute):
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::InspectorController):
+ (WebCore::InspectorController::~InspectorController):
+ (WebCore::InspectorController::connectFrontend):
+ (WebCore::InspectorController::disconnectFrontend):
+ (WebCore::InspectorController::instrumentWillSendXMLHttpRequest):
+ * inspector/InspectorController.h:
+ * inspector/InspectorInstrumentation.cpp: Added.
+ (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
+ (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
+ (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
+ (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
+ (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
+ (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl):
+ (WebCore::InspectorInstrumentation::characterDataModifiedImpl):
+ (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequestImpl):
+ * inspector/InspectorInstrumentation.h: Added.
+ (WebCore::InspectorInstrumentation::frontendCreated):
+ (WebCore::InspectorInstrumentation::frontendDeleted):
+ (WebCore::InspectorInstrumentation::hasFrontends):
+ (WebCore::InspectorInstrumentation::willInsertDOMNode):
+ (WebCore::InspectorInstrumentation::didInsertDOMNode):
+ (WebCore::InspectorInstrumentation::willRemoveDOMNode):
+ (WebCore::InspectorInstrumentation::willModifyDOMAttr):
+ (WebCore::InspectorInstrumentation::didModifyDOMAttr):
+ (WebCore::InspectorInstrumentation::characterDataModified):
+ (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequest):
+ (WebCore::InspectorInstrumentation::inspectorControllerForScriptExecutionContext):
+ (WebCore::InspectorInstrumentation::inspectorControllerForDocument):
+ (WebCore::InspectorInstrumentation::inspectorControllerForPage):
+ * workers/SharedWorker.cpp:
+
+2010-09-30 Kwang Yul Seo <skyul@company100.net>
+
+ Reviewed by Darin Adler.
+
+ Build fix: Add ENABLE(INSPECTOR) guard
+ https://bugs.webkit.org/show_bug.cgi?id=46852
+
+ Page does not have inspectorController() when ENABLE(INSPECTOR) is 0.
+
+ * inspector/InspectorController.h:
+ (WebCore::InspectorController::inspectorControllerForDocument):
+
+2010-09-30 Michael Nordman <michaeln@google.com>
+
+ Reviewed by David Levin.
+
+ Make it possible to copy platform specific data members of ResourceRequest and ResourceResponse
+ across threads and to compare platform specific data members of ResourceRequest.
+ - Added two instance methods to the platform specific subclasses: doPlatformAdopt and doPlatformCopyData.
+ - Also added a "shadowable" static method for platformCompare to ResourceRequestBase, a similar method
+ is already present on ResourceResponseBase.
+ - Converted the cross thread structs defined in ResourceRequest/ResponseBase.h to base
+ classes and extended those base classes in the platform specific headers to provide a place
+ to hold additional fields.
+ - Used this mechanism to have the chromium port's data members make the hop.
+ https://bugs.webkit.org/show_bug.cgi?id=46430
+
+ No new tests. Just plumbing.
+
+ * WebCore.exp.in: removed the symbol for the now inlined == operator
+ * WebCore.gypi: added chromium/ResourceResponse.cpp
+ * platform/network/ResourceRequestBase.cpp:
+ (WebCore::ResourceRequestBase::adopt):
+ (WebCore::ResourceRequestBase::copyData):
+ (WebCore::ResourceRequestBase::compare):
+ * platform/network/ResourceRequestBase.h:
+ (WebCore::ResourceRequestBase::platformCompare):
+ (WebCore::operator==):
+ (WebCore::operator!=):
+ * platform/network/ResourceResponseBase.cpp:
+ (WebCore::ResourceResponseBase::asResourceResponse):
+ (WebCore::ResourceResponseBase::adopt):
+ (WebCore::ResourceResponseBase::copyData):
+ * platform/network/ResourceResponseBase.h:
+ * platform/network/android/ResourceRequest.h:
+ (WebCore::ResourceRequest::doPlatformCopyData):
+ (WebCore::ResourceRequest::doPlatformAdopt):
+ * platform/network/android/ResourceResponse.h:
+ (WebCore::ResourceResponse::doPlatformCopyData):
+ (WebCore::ResourceResponse::doPlatformAdopt):
+ * platform/network/cf/ResourceRequest.h:
+ (WebCore::ResourceRequest::doPlatformCopyData):
+ (WebCore::ResourceRequest::doPlatformAdopt):
+ * platform/network/cf/ResourceResponse.h:
+ (WebCore::ResourceResponse::doPlatformCopyData):
+ (WebCore::ResourceResponse::doPlatformAdopt):
+ * platform/network/chromium/ResourceRequest.cpp:
+ (WebCore::ResourceRequest::doPlatformCopyData):
+ (WebCore::ResourceRequest::doPlatformAdopt):
+ * platform/network/chromium/ResourceRequest.h:
+ * platform/network/chromium/ResourceResponse.cpp: Added.
+ (WebCore::ResourceResponse::doPlatformCopyData):
+ (WebCore::ResourceResponse::doPlatformAdopt):
+ * platform/network/chromium/ResourceResponse.h:
+ * platform/network/curl/ResourceRequest.h:
+ (WebCore::ResourceRequest::doPlatformCopyData):
+ (WebCore::ResourceRequest::doPlatformAdopt):
+ * platform/network/curl/ResourceResponse.h:
+ (WebCore::ResourceResponse::doPlatformCopyData):
+ (WebCore::ResourceResponse::doPlatformAdopt):
+ * platform/network/mac/ResourceRequest.h:
+ (WebCore::ResourceRequest::doPlatformCopyData):
+ (WebCore::ResourceRequest::doPlatformAdopt):
+ * platform/network/mac/ResourceResponse.h:
+ (WebCore::ResourceResponse::doPlatformCopyData):
+ (WebCore::ResourceResponse::doPlatformAdopt):
+ * platform/network/qt/ResourceRequest.h:
+ (WebCore::ResourceRequest::doPlatformCopyData):
+ (WebCore::ResourceRequest::doPlatformAdopt):
+ * platform/network/qt/ResourceResponse.h:
+ (WebCore::ResourceResponse::doPlatformCopyData):
+ (WebCore::ResourceResponse::doPlatformAdopt):
+ * platform/network/soup/ResourceRequest.h:
+ (WebCore::ResourceRequest::doPlatformCopyData):
+ (WebCore::ResourceRequest::doPlatformAdopt):
+ * platform/network/soup/ResourceResponse.h:
+ (WebCore::ResourceResponse::doUpdateResourceResponse):
+ (WebCore::ResourceResponse::doPlatformCopyData):
+ (WebCore::ResourceResponse::doPlatformAdopt):
+
+2010-09-29 Chris Rogers <crogers@google.com>
+
+ Reviewed by Kenneth Russell.
+
+ Put default initialize() and uninitialize() methods in AudioNode
+ https://bugs.webkit.org/show_bug.cgi?id=46767
+
+ No new tests since audio API is not yet implemented.
+
+ * webaudio/AudioNode.cpp:
+ (WebCore::AudioNode::initialize):
+ (WebCore::AudioNode::uninitialize):
+ * webaudio/AudioNode.h:
+
+2010-09-29 Kent Tamura <tkent@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ Refactor HTMLInputElement: Make DeprecatedInputType private.
+ https://bugs.webkit.org/show_bug.cgi?id=46791
+
+ No new tests because this doesn't change any behavior.
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::createTypeMap):
+ * html/HTMLInputElement.h:
+ Move DeprecatedInputType, deprecatedInputType() and
+ parseToDateComponents() to the private section, make
+ createTypeMap() a member function of HTMLInputElement.
+ (WebCore::HTMLInputElement::deprecatedInputType):
+
2010-09-29 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Fisher.
« no previous file with comments | « LayoutTests/fast/table/simple_paint-expected.png ('k') | WebCore/rendering/RenderTableSection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698