Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 3586006: Begin a more aggressive refactoring of the Compiler interface. (Closed)

Created:
10 years, 2 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Begin a more aggressive refactoring of the Compiler interface. The plan is to use the CompilationInfo class to communicate inputs and outputs to compilation pipeline phases, which each return a boolean success/failure flag. The intent is to make it easier to compose small pieces of the pipeline without having to grow a custom function each time, each taking a half dozen arguments. This change modifies the very front end (the parser). Committed: http://code.google.com/p/v8/source/detail?r=5581

Patch Set 1 #

Patch Set 2 : Always return false on a parse failure. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -237 lines) Patch
M src/arm/codegen-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler.h View 1 2 chunks +65 lines, -93 lines 0 comments Download
M src/compiler.cc View 11 chunks +85 lines, -70 lines 0 comments Download
M src/handles.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/liveedit.cc View 9 chunks +12 lines, -20 lines 0 comments Download
M src/parser.h View 1 2 chunks +5 lines, -11 lines 0 comments Download
M src/parser.cc View 1 1 chunk +33 lines, -34 lines 0 comments Download
M src/x64/codegen-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
10 years, 2 months ago (2010-10-01 14:17:21 UTC) #1
fschneider
10 years, 2 months ago (2010-10-04 10:14:05 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698