src/x64/code-stubs-x64.cc - Issue 3574002: Rename some x64 macros to be more precise about their semantics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/code-stubs-x64.cc

Issue 3574002: Rename some x64 macros to be more precise about their semantics. (Closed)

Patch Set: Addressing Lasse's comments Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/code-stubs-x64.cc

diff --git a/src/x64/code-stubs-x64.cc b/src/x64/code-stubs-x64.cc

index 9d82e0e31abfc70475b112ac8d28756517bcebd5..b050ec85dd3ddeaef043a0554aefb127459bb6a4 100644

--- a/src/x64/code-stubs-x64.cc

+++ b/src/x64/code-stubs-x64.cc

@@ -3801,7 +3801,7 @@ void SubStringStub::Generate(MacroAssembler* masm) {

Label result_longer_than_two;

__ movq(rcx, Operand(rsp, kToOffset));

__ movq(rdx, Operand(rsp, kFromOffset));

- __ JumpIfNotBothPositiveSmi(rcx, rdx, &runtime);

+ __ JumpUnlessBothNonNegativeSmi(rcx, rdx, &runtime);

__ SmiSub(rcx, rcx, rdx); // Overflow doesn't happen.

__ cmpq(FieldOperand(rax, String::kLengthOffset), rcx);

« no previous file with comments | « src/x64/builtins-x64.cc ('k') | src/x64/codegen-x64.cc » ('j') | no next file with comments »