src/x64/builtins-x64.cc - Issue 3574002: Rename some x64 macros to be more precise about their semantics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/builtins-x64.cc

Issue 3574002: Rename some x64 macros to be more precise about their semantics. (Closed)

Patch Set: Addressing Lasse's comments Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/builtins-x64.cc

diff --git a/src/x64/builtins-x64.cc b/src/x64/builtins-x64.cc

index 08c19ba6dbb54111d3da039030f95fe94282b2b6..0dead6b793cfe0077f0c1ed527bf8657563527b5 100644

--- a/src/x64/builtins-x64.cc

+++ b/src/x64/builtins-x64.cc

@@ -715,7 +715,7 @@ static void ArrayNativeCode(MacroAssembler* masm,

__ cmpq(rax, Immediate(1));

__ j(not_equal, &argc_two_or_more);

__ movq(rdx, Operand(rsp, kPointerSize)); // Get the argument from the stack.

- __ JumpIfNotPositiveSmi(rdx, call_generic_code);

+ __ JumpUnlessNonNegativeSmi(rdx, call_generic_code);

// Handle construction of an empty array of a certain size. Bail out if size

// is to large to actually allocate an elements array.

« no previous file with comments | « no previous file | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »