Issue 356007: Add a way to mark a test as missing expectations. We avoided added this...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 356007: Add a way to mark a test as missing expectations. We avoided added this... (Closed)

Created:
11 years, 1 month ago by ojan

Modified:
9 years, 7 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add a way to mark a test as missing expectations. We avoided added this in the past saying that these should be fixed immediately, but this impedes our ability to run the tests on the bots without turning them red. Needing to skip these tests to avoid making the bots red is silly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30872

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	webkit/tools/layout_tests/layout_package/compare_failures.py	View		2 chunks	+5 lines, -2 lines	0 comments	Download
	M	webkit/tools/layout_tests/layout_package/test_expectations.py	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

11 years, 1 month ago (2009-11-03 21:55:25 UTC) #2

lgtm. I not fond of the fact that we have to add this, but I can't think of any
better alternatives.

Expand Messages | Collapse Messages