Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1755)

Unified Diff: webkit/tools/layout_tests/layout_package/compare_failures.py

Issue 356007: Add a way to mark a test as missing expectations. We avoided added this... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/tools/layout_tests/layout_package/test_expectations.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/tools/layout_tests/layout_package/compare_failures.py
===================================================================
--- webkit/tools/layout_tests/layout_package/compare_failures.py (revision 30861)
+++ webkit/tools/layout_tests/layout_package/compare_failures.py (working copy)
@@ -118,7 +118,8 @@
'CRASH')
PrintFilesFromSet(self._missing,
"Missing expected results",
- output)
+ output,
+ 'MISSING')
def _CalculateRegressions(self):
"""Calculate regressions from this run through the layout tests."""
@@ -156,7 +157,9 @@
# expected files.
elif (is_missing and
not self._expectations.IsRebaselining(test) and
- not self._expectations.IsIgnored(test)):
+ not self._expectations.IsIgnored(test) and
+ (test_expectations.MISSING not in
+ self._expectations.GetExpectations(test))):
missing.add(test)
elif is_image_failure and is_text_failure:
if (not test_expectations.FAIL in expectations and
« no previous file with comments | « no previous file | webkit/tools/layout_tests/layout_package/test_expectations.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698