Addin a time-out to view base tests to prevent them from...

Addin a time-out to view base tests to prevent them from
potentially hanging the interactive ui tests.

BUG=None
TEST=Run the interactive ui tests.
R=sky

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30972

[Paweł Hajdan Jr., 2009-11-04 17:34:19]

Drive-by.

It would be nice to have a more general timeout, for all UI tests. I have a
patch ready at http://codereview.chromium.org/195106, but landing it is
complicated (nsylvain and huanr can explain it).

[sky, 2009-11-04 17:48:06]

http://codereview.chromium.org/355024/diff/1002/2002
File chrome/test/interactive_ui/view_event_test_base.cc (right):

http://codereview.chromium.org/355024/diff/1002/2002#newcode122
Line 122: NewRunnableMethod(this, &ViewEventTestBase::TimedOut), kTimeoutInMS);
Shouldn't this timer get canceled if the test completes?

[jcampan, 2009-11-04 18:06:12]

http://codereview.chromium.org/355024/diff/1002/2002
File chrome/test/interactive_ui/view_event_test_base.cc (right):

http://codereview.chromium.org/355024/diff/1002/2002#newcode122
Line 122: NewRunnableMethod(this, &ViewEventTestBase::TimedOut), kTimeoutInMS);
On 2009/11/04 17:48:06, sky wrote:
> Shouldn't this timer get canceled if the test completes?

I guess when the MessageLoop goes away, the pending time-out task is not
executed. Anyway, I added a method factory and cancel the task on Done().

[sky, 2009-11-04 18:17:15]

On 2009/11/04 18:06:12, jcampan wrote:
> http://codereview.chromium.org/355024/diff/1002/2002
> File chrome/test/interactive_ui/view_event_test_base.cc (right):
> 
> http://codereview.chromium.org/355024/diff/1002/2002#newcode122
> Line 122: NewRunnableMethod(this, &ViewEventTestBase::TimedOut),
kTimeoutInMS);
> On 2009/11/04 17:48:06, sky wrote:
> > Shouldn't this timer get canceled if the test completes?
> 
> I guess when the MessageLoop goes away, the pending time-out task is not
> executed. Anyway, I added a method factory and cancel the task on Done().

I wasn't sure if this is the case. It seems like all view event tests share the
same message loop, which means without the method factory you could end up with
a bunch of pending tasks for deleted objects.

LGTM

  -Scott