Implement per-test timeout for UI tests.

Implement per-test timeout for UI tests.

Doing it on the browser side makes things simpler - we don't have to deal
with preempting sync IPC messages and things like that.

It's possible that this will hit other problems, but seems like a good start.

TEST=none
BUG=22054

[huanr, 2009-09-16 21:58:47]

What is the benefit of setting per test timeout?

http://codereview.chromium.org/195106/diff/1/7
File chrome/test/ui/ui_test.cc (right):

http://codereview.chromium.org/195106/diff/1/7#newcode48
Line 48: static const int kPerTestTimeoutMsec = 60000;
We have different timeout value for running ui_test under purify. There need to
be a command line for it.

[Paweł Hajdan Jr., 2009-09-17 19:15:33]

On 2009/09/16 21:58:47, huanr wrote:
> What is the benefit of setting per test timeout?

Having the UI tests not hang.

> http://codereview.chromium.org/195106/diff/1/7
> File chrome/test/ui/ui_test.cc (right):
> 
> http://codereview.chromium.org/195106/diff/1/7#newcode48
> Line 48: static const int kPerTestTimeoutMsec = 60000;
> We have different timeout value for running ui_test under purify. There need
to
> be a command line for it.

Indeed. Done.

[huanr, 2009-09-17 19:48:20]

http://codereview.chromium.org/195106/diff/3002/3008
File chrome/test/ui/ui_test.cc (right):

http://codereview.chromium.org/195106/diff/3002/3008#newcode112
Line 112: terminate_timeout_ms_(kWaitForTerminateMsec) {
set per_test_timeout default.

[Paweł Hajdan Jr., 2009-09-17 19:50:08]

Could you explain the comment? I'm not sure what to do...

On Thu, Sep 17, 2009 at 12:48, <huanr@chromium.org> wrote:

>
> http://codereview.chromium.org/195106/diff/3002/3008
> File chrome/test/ui/ui_test.cc (right):
>
> http://codereview.chromium.org/195106/diff/3002/3008#newcode112
> Line 112: terminate_timeout_ms_(kWaitForTerminateMsec) {
> set per_test_timeout default.
>
>
> http://codereview.chromium.org/195106
>

[Paweł Hajdan Jr., 2009-09-18 17:33:13]

Should be fixed. Please take a look.

[huanr, 2009-09-18 17:34:45]

LGTM

[jcampan, 2009-11-04 17:42:30]

> It would be nice to have a more general timeout, for all UI tests. I have a
> patch ready at http://codereview.chromium.org/195106, but landing it is
> complicated (nsylvain and huanr can explain it).
ViewEventTest are not UI tests, they are unit-tests (run in-process)
that do UI magic.

Jay

[Paweł Hajdan Jr., 2009-11-04 17:47:59]

On Wed, Nov 4, 2009 at 18:42, Jay Campan <jcampan@chromium.org> wrote:

> > It would be nice to have a more general timeout, for all UI tests. I have
> a
> > patch ready at http://codereview.chromium.org/195106, but landing it is
> > complicated (nsylvain and huanr can explain it).
> ViewEventTest are not UI tests, they are unit-tests (run in-process)
> that do UI magic.
>

I see. Please ignore my earlier comment then.