Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 355009: Fix a latent bug in the top-level compilation of function calls.... (Closed)

Created:
11 years, 1 month ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix a latent bug in the top-level compilation of function calls. Calls to a non-global variable would go through the "call to a global" path, rather than the "call to an arbitrary (other) expression" path. Committed: http://code.google.com/p/v8/source/detail?r=3204

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -89 lines) Patch
M src/arm/fast-codegen-arm.cc View 1 2 chunks +20 lines, -23 lines 0 comments Download
M src/compiler.cc View 1 2 chunks +7 lines, -20 lines 0 comments Download
M src/ia32/fast-codegen-ia32.cc View 1 2 chunks +19 lines, -24 lines 0 comments Download
M src/x64/fast-codegen-x64.cc View 1 2 chunks +19 lines, -22 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
I've also restructured the code for clarity and cleaned up the comments for accuracy.
11 years, 1 month ago (2009-11-03 11:21:29 UTC) #1
fschneider
11 years, 1 month ago (2009-11-03 12:05:43 UTC) #2
Yes, it's good to have the same cases for calls in the CodeGenSelector and the
FastCodeGenerator.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698