Fix a latent bug in the top-level compilation of function calls....

src/compiler.cc

 // Copyright 2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 782 matching lines @@
 }
 
 
 void CodeGenSelector::VisitCall(Call* expr) {
   Expression* fun = expr->expression();
   ZoneList<Expression*>* args = expr->arguments();
   Variable* var = fun->AsVariableProxy()->AsVariable();
 
   // Check for supported calls
   if (var != NULL && var->is_possibly_eval()) {
-    // ----------------------------------
-    // JavaScript example: 'eval(arg)'  // eval is not known to be shadowed
-    // ----------------------------------
-    BAILOUT("Call to a function named 'eval'");
+    BAILOUT("call to the identifier 'eval'");
   } else if (var != NULL && !var->is_this() && var->is_global()) {
-    // ----------------------------------
-    // JavaScript example: 'foo(1, 2, 3)'  // foo is global
-    // ----------------------------------
+    // Calls to global variables are supported.
+  } else if (var != NULL && var->slot() != NULL &&
+             var->slot()->type() == Slot::LOOKUP) {
+    BAILOUT("call to a lookup slot");
   } else if (fun->AsProperty() != NULL) {
-    // ------------------------------------------------------------------
-    // JavaScript example: 'object.foo(1, 2, 3)' or 'map["key"](1, 2, 3)'
-    // ------------------------------------------------------------------
     Property* prop = fun->AsProperty();
     Literal* literal_key = prop->key()->AsLiteral();
     if (literal_key != NULL && literal_key->handle()->IsSymbol()) {
       ProcessExpression(prop->obj(), Expression::kValue);
       CHECK_BAILOUT;
     } else {
       ProcessExpression(prop->obj(), Expression::kValue);
       CHECK_BAILOUT;
       ProcessExpression(prop->key(), Expression::kValue);
       CHECK_BAILOUT;
     }
-  } else if (var != NULL && var->slot() != NULL &&
-             var->slot()->type() == Slot::LOOKUP) {
-    // ----------------------------------
-    // JavaScript example: 'with (obj) foo(1, 2, 3)'  // foo is in obj
-    // ----------------------------------
-    BAILOUT("Call inside a with-statement");
   } else {
-    // ----------------------------------
-    // JavaScript example: 'foo(1, 2, 3)'  // foo is any expression, not global
-    // ----------------------------------
+    // Otherwise the call is supported if the function expression is.
     ProcessExpression(fun, Expression::kValue);
   }
-  // Check all arguments to the call.  (Relies on TEMP meaning STACK.)
+  // Check all arguments to the call.
   for (int i = 0; i < args->length(); i++) {
     ProcessExpression(args->at(i), Expression::kValue);
     CHECK_BAILOUT;
   }
 }
 
 
 void CodeGenSelector::VisitCallNew(CallNew* expr) {
   ProcessExpression(expr->expression(), Expression::kValue);
   CHECK_BAILOUT;
@@ skipping 128 matching lines @@
 
 void CodeGenSelector::VisitThisFunction(ThisFunction* expr) {
   BAILOUT("ThisFunction");
 }
 
 #undef BAILOUT
 #undef CHECK_BAILOUT
 
 
 } }  // namespace v8::internal