Fix gcl to look for newly-added codereview.settings files as well as modified...

Fix gcl to look for newly-added codereview.settings files as well as modified
codereview.settings files.

  BUG=none
  TEST=none
  R=maruel@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30910

[M-A Ruel, 2009-11-03 16:25:57]

http://codereview.chromium.org/354023/diff/1/2
File gcl.py (right):

http://codereview.chromium.org/354023/diff/1/2#newcode160
Line 160: content, rc = RunShellWithReturnCode(["svn", "status", local_path])
Can you use gclient_scm.CaptureSVNStatus() instead?

[Dirk Pranke, 2009-11-03 23:48:12]

http://codereview.chromium.org/354023/diff/1/2
File gcl.py (right):

http://codereview.chromium.org/354023/diff/1/2#newcode160
Line 160: content, rc = RunShellWithReturnCode(["svn", "status", local_path])
On 2009/11/03 16:25:57, Marc-Antoine Ruel wrote:
> Can you use gclient_scm.CaptureSVNStatus() instead?

Done.

[M-A Ruel, 2009-11-04 00:38:19]

lgtm

http://codereview.chromium.org/354023/diff/2001/2002
File gcl.py (right):

http://codereview.chromium.org/354023/diff/2001/2002#newcode165
Line 165: if not rc and (status.startswith('A') or status.startswith('M')):
you can do status[0] in ('A', 'M') since it's guaranteed to be a valid non-empty
string.

[Dirk Pranke, 2009-11-04 01:05:18]

http://codereview.chromium.org/354023/diff/2001/2002
File gcl.py (right):

http://codereview.chromium.org/354023/diff/2001/2002#newcode165
Line 165: if not rc and (status.startswith('A') or status.startswith('M')):
On 2009/11/04 00:38:19, Marc-Antoine Ruel wrote:
> you can do status[0] in ('A', 'M') since it's guaranteed to be a valid
non-empty
> string.

Done.