Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Unified Diff: gcl.py

Issue 354023: Fix gcl to look for newly-added codereview.settings files as well as modified... (Closed) Base URL: http://src.chromium.org/svn/trunk/tools/depot_tools/
Patch Set: Fix gcl to look for newly-added codereview.settings files as well as modified... Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gcl.py
===================================================================
--- gcl.py (revision 30888)
+++ gcl.py (working copy)
@@ -157,8 +157,12 @@
while True:
# First, look for a locally modified version of the file.
local_path = os.path.join(local_dir, local_base)
- content, rc = RunShellWithReturnCode(["svn", "status", local_path])
- if not rc and content.startswith('M'):
+ r = gclient_scm.CaptureSVNStatus((local_path,))
+ rc = -1
+ if r:
+ (status, file) = r[0]
+ rc = 0
+ if not rc and (status.startswith('A') or status.startswith('M')):
M-A Ruel 2009/11/04 00:38:19 you can do status[0] in ('A', 'M') since it's guar
Dirk Pranke 2009/11/04 01:05:18 Done.
content = ReadFile(local_path)
rc = 0
else:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698